From patchwork Thu Feb 5 08:38:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasant Hegde X-Patchwork-Id: 436674 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 682611401DE for ; Thu, 5 Feb 2015 19:38:36 +1100 (AEDT) Received: from ozlabs.org (ozlabs.org [103.22.144.67]) by lists.ozlabs.org (Postfix) with ESMTP id 460371A0D71 for ; Thu, 5 Feb 2015 19:38:36 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from e28smtp08.in.ibm.com (e28smtp08.in.ibm.com [122.248.162.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 6FFAC1A0CD0 for ; Thu, 5 Feb 2015 19:38:33 +1100 (AEDT) Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 5 Feb 2015 14:08:30 +0530 Received: from d28dlp01.in.ibm.com (9.184.220.126) by e28smtp08.in.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 5 Feb 2015 14:08:29 +0530 Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id E240DE0054 for ; Thu, 5 Feb 2015 14:09:57 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t158cRI866322506 for ; Thu, 5 Feb 2015 14:08:27 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t158cRbw022485 for ; Thu, 5 Feb 2015 14:08:27 +0530 Received: from localhost.localdomain ([9.124.35.64]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t158cR5Q022482 for ; Thu, 5 Feb 2015 14:08:27 +0530 From: Vasant Hegde To: skiboot@lists.ozlabs.org Date: Thu, 05 Feb 2015 14:08:27 +0530 Message-ID: <20150205083827.12859.6328.stgit@localhost.localdomain> In-Reply-To: <20150205083611.12859.41225.stgit@localhost.localdomain> References: <20150205083611.12859.41225.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15020508-0029-0000-0000-00000455A61A Subject: [Skiboot] [PATCH 02/22] FSP/LEDS: Remove duplicate fsp_msg allocation X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Remove duplicate fsp_msg allocation introduced by commit fa79cecc45c2. Signed-off-by: Vasant Hegde --- hw/fsp/fsp-leds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c index 1c45ccc..c6232d5 100644 --- a/hw/fsp/fsp-leds.c +++ b/hw/fsp/fsp-leds.c @@ -281,7 +281,7 @@ static void fsp_spcn_set_led_completion(struct fsp_msg *msg) if (!smsg) { prerror("LED: Failed to allocate FSP_RSP_SET_LED_STATE\n"); } else { - if (fsp_queue_msg(msg, fsp_freemsg)) { + if (fsp_queue_msg(smsg, fsp_freemsg)) { prerror("LED: Failed to queue FSP_RSP_SET_LED_STATE\n"); } } @@ -335,7 +335,7 @@ static int fsp_msg_set_led_state(char *loc_code, bool command, bool state) prerror("LED: Could not allocate " "FSP_RSP_SET_LED_STATE|FSP_STATUS_INVALID_LC\n"); } else { - if (fsp_queue_msg(fsp_mkmsg(cmd, 0), fsp_freemsg)) { + if (fsp_queue_msg(msg, fsp_freemsg)) { prerror("LED: Couldn't queue " "FSP_RSP_SET_LED_STATE" "|FSP_STATUS_INVALID_LC\n");