diff mbox series

[9/9] npu2: Replace open coded dt_find_by_name_addr()

Message ID 1547049531-759-9-git-send-email-arbab@linux.ibm.com
State Accepted
Headers show
Series [1/9] Remove duplicate npu2-common.o from $(HW_OBJS) | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master

Commit Message

Reza Arbab Jan. 9, 2019, 3:58 p.m. UTC 
We now have a dt function to do this. Use it.

Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
---
 hw/npu2.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

Comments

Andrew Donnellan Jan. 9, 2019, 11:55 p.m. UTC | #1 
On 10/1/19 2:58 am, Reza Arbab wrote:
> We now have a dt function to do this. Use it.
> 
> Signed-off-by: Reza Arbab <arbab@linux.ibm.com>

This looks much nicer.

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
diff mbox series

Patch

diff --git a/hw/npu2.c b/hw/npu2.c
index 68a5382..d6b634d 100644
--- a/hw/npu2.c
+++ b/hw/npu2.c
@@ -605,20 +605,9 @@  static void npu2_append_phandle(struct dt_node *dn,
 static struct dt_node *npu2_create_memory_dn(uint64_t addr, uint64_t size)
 {
 	struct dt_node *mem;
-	char *name;
-	size_t namesz;
 	static u32 chip_id = 255;
 
-	/*
-	 * Find and return the node if it already exists.
-	 */
-	namesz = sizeof("memory@") + STR_MAX_CHARS(addr);
-	name = malloc(namesz);
-	if (!name)
-		return NULL;
-	snprintf(name, namesz, "memory@%llx", (long long)addr);
-	mem = dt_find_by_name(dt_root, name);
-	free(name);
+	mem = dt_find_by_name_addr(dt_root, "memory", addr);
 	if (mem)
 		return mem;