diff mbox series

[5/9] npu2: Remove unused npu2_dev::procedure_data

Message ID 1547049531-759-5-git-send-email-arbab@linux.ibm.com
State Accepted
Headers show
Series [1/9] Remove duplicate npu2-common.o from $(HW_OBJS) | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success master/apply_patch Successfully applied
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master

Commit Message

Reza Arbab Jan. 9, 2019, 3:58 p.m. UTC
This variable is never used. Remove it.

Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
---
 hw/npu2-hw-procedures.c | 2 --
 include/npu2.h          | 1 -
 2 files changed, 3 deletions(-)

Comments

Andrew Donnellan Jan. 9, 2019, 11:39 p.m. UTC | #1
On 10/1/19 2:58 am, Reza Arbab wrote:
> This variable is never used. Remove it.
> 
> Signed-off-by: Reza Arbab <arbab@linux.ibm.com>

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
diff mbox series

Patch

diff --git a/hw/npu2-hw-procedures.c b/hw/npu2-hw-procedures.c
index fa64075..5214cdd 100644
--- a/hw/npu2-hw-procedures.c
+++ b/hw/npu2-hw-procedures.c
@@ -908,7 +908,6 @@  static int64_t npu_dev_procedure_write(struct npu2_dev *dev, uint32_t offset,
 		dev->procedure_status = PROCEDURE_INPROGRESS;
 		dev->procedure_number = data;
 		dev->procedure_step = 0;
-		dev->procedure_data = 0;
 		dev->procedure_tb = mftb();
 		break;
 
@@ -961,7 +960,6 @@  static uint32_t run_procedure(struct npu2_dev *dev, uint16_t procedure_number)
 	dev->procedure_status = PROCEDURE_INPROGRESS;
 	dev->procedure_number = procedure_number;
 	dev->procedure_step = 0;
-	dev->procedure_data = 0;
 	dev->procedure_tb = mftb();
 
 	result = get_procedure_status(dev);
diff --git a/include/npu2.h b/include/npu2.h
index f2b5a23..8906723 100644
--- a/include/npu2.h
+++ b/include/npu2.h
@@ -136,7 +136,6 @@  struct npu2_dev {
 	/* Track currently running procedure and step number */
 	uint16_t		procedure_number;
 	uint16_t		procedure_step;
-	uint64_t		procedure_data;
 	unsigned long		procedure_tb;
 	uint32_t		procedure_status;