diff mbox

[RFC,04/12] opal-prd: Add occ reset to usage text

Message ID 1495695955-30718-5-git-send-email-jk@ozlabs.org
State Superseded
Headers show

Commit Message

Jeremy Kerr May 25, 2017, 7:05 a.m. UTC 
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---
 external/opal-prd/opal-prd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vasant Hegde May 25, 2017, 10:05 a.m. UTC | #1 
On 05/25/2017 12:35 PM, Jeremy Kerr wrote:
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> ---
>  external/opal-prd/opal-prd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
> index fec9770..6ac8a20 100644
> --- a/external/opal-prd/opal-prd.c
> +++ b/external/opal-prd/opal-prd.c
> @@ -1958,7 +1958,7 @@ static void usage(const char *progname)
>  	printf("Usage:\n");
>  	printf("\t%s [--debug] [--file <hbrt-image>] [--pnor <device>]\n",
>  			progname);
> -	printf("\t%s occ <enable|disable>\n", progname);
> +	printf("\t%s occ <enable|disable|reset [chip]>\n", progname);

Do we really want to reset chip 0 if chip number is not specified?

Also can you update "process-error" option as well?

-Vasant
Jeremy Kerr May 25, 2017, 11:37 p.m. UTC | #2 
Hi Vasant,

>> diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
>> index fec9770..6ac8a20 100644
>> --- a/external/opal-prd/opal-prd.c
>> +++ b/external/opal-prd/opal-prd.c
>> @@ -1958,7 +1958,7 @@ static void usage(const char *progname)
>>      printf("Usage:\n");
>>      printf("\t%s [--debug] [--file <hbrt-image>] [--pnor <device>]\n",
>>              progname);
>> -    printf("\t%s occ <enable|disable>\n", progname);
>> +    printf("\t%s occ <enable|disable|reset [chip]>\n", progname);
> 
> Do we really want to reset chip 0 if chip number is not specified?

That's the current behaviour, so I'd like to preserve compatibility
there.

> Also can you update "process-error" option as well?

Yep, can do.

Cheers,


Jeremy
diff mbox

Patch

diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
index fec9770..6ac8a20 100644
--- a/external/opal-prd/opal-prd.c
+++ b/external/opal-prd/opal-prd.c
@@ -1958,7 +1958,7 @@  static void usage(const char *progname)
 	printf("Usage:\n");
 	printf("\t%s [--debug] [--file <hbrt-image>] [--pnor <device>]\n",
 			progname);
-	printf("\t%s occ <enable|disable>\n", progname);
+	printf("\t%s occ <enable|disable|reset [chip]>\n", progname);
 	printf("\t%s htmgt-passthru <bytes...>\n", progname);
 	printf("\t%s override <FILE>\n", progname);
 	printf("\t%s run [arg 0] [arg 1]..[arg n]\n", progname);