| Message ID | 1466808476-32690-21-git-send-email-benh@kernel.crashing.org |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, 2016-06-25 at 08:47 +1000, Benjamin Herrenschmidt wrote: > It's not necessary and not in PAPR. HostBoot should probably do a > similar change. This breaks make check but it's fixed by the patch 2 later: interrupts: Remove #interrupt-cells from ICP nodes Can you merge it with that one? Mikey > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > hdata/paca.c | 1 - > hdata/pcia.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/hdata/paca.c b/hdata/paca.c > index 6d001fd..7284a6e 100644 > --- a/hdata/paca.c > +++ b/hdata/paca.c > @@ -190,7 +190,6 @@ static void add_icps(void) > irange, sizeof(irange)); > dt_add_property(icp, "interrupt-controller", NULL, 0); > dt_add_property_cells(icp, "#address-cells", 0); > - dt_add_property_cells(icp, "#interrupt-cells", 1); > dt_add_property_string(icp, "device_type", > "PowerPC-External-Interrupt- > Presentation"); > for (i = 0; i < num_threads*2; i += 2) { > diff --git a/hdata/pcia.c b/hdata/pcia.c > index 8d11437..a54d4cf 100644 > --- a/hdata/pcia.c > +++ b/hdata/pcia.c > @@ -93,7 +93,6 @@ static void add_icp(const void *pcia, u32 tcount, const > char *compat) > dt_add_property(icp, "interrupt-controller", NULL, 0); > dt_add_property(icp, "reg", reg, rsize); > dt_add_property_cells(icp, "#address-cells", 0); > - dt_add_property_cells(icp, "#interrupt-cells", 1); > dt_add_property_string(icp, "device_type", > "PowerPC-External-Interrupt- > Presentation"); > free(reg);
diff --git a/hdata/paca.c b/hdata/paca.c index 6d001fd..7284a6e 100644 --- a/hdata/paca.c +++ b/hdata/paca.c @@ -190,7 +190,6 @@ static void add_icps(void) irange, sizeof(irange)); dt_add_property(icp, "interrupt-controller", NULL, 0); dt_add_property_cells(icp, "#address-cells", 0); - dt_add_property_cells(icp, "#interrupt-cells", 1); dt_add_property_string(icp, "device_type", "PowerPC-External-Interrupt-Presentation"); for (i = 0; i < num_threads*2; i += 2) { diff --git a/hdata/pcia.c b/hdata/pcia.c index 8d11437..a54d4cf 100644 --- a/hdata/pcia.c +++ b/hdata/pcia.c @@ -93,7 +93,6 @@ static void add_icp(const void *pcia, u32 tcount, const char *compat) dt_add_property(icp, "interrupt-controller", NULL, 0); dt_add_property(icp, "reg", reg, rsize); dt_add_property_cells(icp, "#address-cells", 0); - dt_add_property_cells(icp, "#interrupt-cells", 1); dt_add_property_string(icp, "device_type", "PowerPC-External-Interrupt-Presentation"); free(reg);
It's not necessary and not in PAPR. HostBoot should probably do a similar change. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- hdata/paca.c | 1 - hdata/pcia.c | 1 - 2 files changed, 2 deletions(-)