diff mbox

[3/5] fsp-epow: add FWTS annotation

Message ID 1466732206-23684-3-git-send-email-stewart@linux.vnet.ibm.com
State Superseded
Headers show

Commit Message

Stewart Smith June 24, 2016, 1:36 a.m. UTC 
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 hw/fsp/fsp-epow.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff mbox

Patch

diff --git a/hw/fsp/fsp-epow.c b/hw/fsp/fsp-epow.c
index df36c462a6b7..512a15c1cb3c 100644
--- a/hw/fsp/fsp-epow.c
+++ b/hw/fsp/fsp-epow.c
@@ -69,6 +69,10 @@  static void fsp_process_epow(struct fsp_msg *msg, int epow_type)
 
 	/* Basic EPOW signature */
 	if (msg->data.bytes[0] != 0xF2) {
+		/**
+		 * @fwts-label EPOWSignatureMismatch
+		 * @fwts-advice Bug in skiboot/FSP code for EPOW event handling
+		 */
 		prlog(PR_ERR, "Signature mismatch\n");
 		return;
 	}
@@ -105,6 +109,12 @@  static void fsp_process_epow(struct fsp_msg *msg, int epow_type)
 	if (epow_changed) {
 		rc = opal_queue_msg(OPAL_MSG_EPOW, NULL, NULL);
 		if (rc) {
+			/**
+			 * @fwts-label EPOWMessageQueueFailed
+			 * @fwts-advice Queueing a message from OPAL to FSP
+			 * failed. This is likely due to either an OPAL bug
+			 * or the FSP going away.
+			 */
 			prlog(PR_ERR, "OPAL EPOW message queuing failed\n");
 			return;
 		}