Message ID | 1424415680-21726-2-git-send-email-alistair@popple.id.au |
---|---|
State | Accepted |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 88F40140188 for <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2015 18:02:32 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id E384F1A0EEE for <incoming@patchwork.ozlabs.org>; Fri, 20 Feb 2015 18:02:31 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 80FC11A0310 for <skiboot@lists.ozlabs.org>; Fri, 20 Feb 2015 18:02:26 +1100 (AEDT) Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <skiboot@lists.ozlabs.org> from <alistair.popple@au1.ibm.com>; Fri, 20 Feb 2015 17:02:24 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 20 Feb 2015 17:02:22 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id D9CF53578048 for <skiboot@lists.ozlabs.org>; Fri, 20 Feb 2015 18:02:21 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t1K72DMG46399546 for <skiboot@lists.ozlabs.org>; Fri, 20 Feb 2015 18:02:21 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t1K71mio000468 for <skiboot@lists.ozlabs.org>; Fri, 20 Feb 2015 18:01:48 +1100 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t1K71m05032401; Fri, 20 Feb 2015 18:01:48 +1100 Received: from localhost (haven.au.ibm.com [9.192.253.15]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 1377CA037F; Fri, 20 Feb 2015 18:01:25 +1100 (AEDT) From: Alistair Popple <alistair@popple.id.au> To: skiboot@lists.ozlabs.org Date: Fri, 20 Feb 2015 18:01:20 +1100 Message-Id: <1424415680-21726-2-git-send-email-alistair@popple.id.au> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1424415680-21726-1-git-send-email-alistair@popple.id.au> References: <1424415680-21726-1-git-send-email-alistair@popple.id.au> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15022007-0013-0000-0000-000000D63B91 Subject: [Skiboot] [PATCH 2/2] bt: Minor locking fix for bt_get_resp() X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
diff --git a/hw/bt.c b/hw/bt.c index 3278896..93df22e 100644 --- a/hw/bt.c +++ b/hw/bt.c @@ -254,7 +254,6 @@ static void bt_get_resp(void) prlog(PR_INFO, "BT: Nobody cared about a response to an BT/IPMI message\n"); bt_flush_msg(); bt_set_state(BT_STATE_B_BUSY); - unlock(&bt.lock); return; }
bt_get_resp() should return with the bt lock held. Under very rare error conditions bt_get_resp() would drop the lock before returning. Signed-off-by: Alistair Popple <alistair@popple.id.au> --- hw/bt.c | 1 - 1 file changed, 1 deletion(-)