mbox series

[v3,0/9] Implement PLDM self test

Message ID 20220518074304.42497-1-abhishek@linux.ibm.com
Headers show
Series Implement PLDM self test | expand

Message

Abhishek Singh Tomar May 18, 2022, 7:42 a.m. UTC 
These patches contains self test for PLDM. These self test
are not hardware dependent as they bypass hardware dependent code.
They tries to test codeflow for following PLDM message types
1. PLDM FILE I/O
2. PLDM BIOS
3. PLDM PLATFORM
4. PLDM FRU

This patch set should be applied on top of these previous sets:
- Implement virtual flash content using PLDM.
- Import external libraries for MCTP/PLDM protocols.
- Implement MCTP and PLDM features.
- Complete PLDM responder and enable PLDM support

Signed-off-by: Abhishek Singh Tomar <abhishek@linux.ibm.com>

Abhishek Singh Tomar (9):
  core/pldm/test : Implement PLDM self test common api
  core/pldm/test :  Initialize pldm file I/O test
  core/pldm/test :  Write file with PLDM file I/O message
  core/pldm/test : Read file with PLDM file I/O message
  core/pldm/test : Implement pldm bios specification test
  core/pldm/test : Initialize pldm platform specification test
  core/pldm/test : Implement pldm platform restart and power off request
    test
  core/pldm/test : Implement PLDM FRU table self test
  core/pldm/test : Retrieve the BMC information with the FRU PLDM
    message

 core/pldm/pldm.h                         |   2 +-
 core/pldm/test/Makefile.check            |  46 +++
 core/pldm/test/common/test-pldm-common.c | 191 +++++++++++
 core/pldm/test/test-pldm-bios.c          | 289 +++++++++++++++++
 core/pldm/test/test-pldm-fileio.c        | 321 +++++++++++++++++++
 core/pldm/test/test-pldm-fru.c           | 327 +++++++++++++++++++
 core/pldm/test/test-pldm-platform.c      | 386 +++++++++++++++++++++++
 7 files changed, 1561 insertions(+), 1 deletion(-)
 create mode 100644 core/pldm/test/Makefile.check
 create mode 100644 core/pldm/test/common/test-pldm-common.c
 create mode 100644 core/pldm/test/test-pldm-bios.c
 create mode 100644 core/pldm/test/test-pldm-fileio.c
 create mode 100644 core/pldm/test/test-pldm-fru.c
 create mode 100644 core/pldm/test/test-pldm-platform.c

Comments

Christophe Lombard May 23, 2022, 11:29 a.m. UTC | #1 
Le 18/05/2022 à 09:42, Abhishek Singh Tomar a écrit :
> These patches contains self test for PLDM. These self test
> are not hardware dependent as they bypass hardware dependent code.
> They tries to test codeflow for following PLDM message types
> 1. PLDM FILE I/O
> 2. PLDM BIOS
> 3. PLDM PLATFORM
> 4. PLDM FRU
>
> This patch set should be applied on top of these previous sets:
> - Implement virtual flash content using PLDM.
> - Import external libraries for MCTP/PLDM protocols.
> - Implement MCTP and PLDM features.
> - Complete PLDM responder and enable PLDM support

Hi Abhishek,

I think we should go further with the tool PLDM test. For the time
being, PLDM test "just" responds to some Skiboot PLDM requests
and the responses are modeled on the Skiboot requests so it is
difficult to fault the host code.

So, it would be, perhaps, more judicious, among others, to look
at the model of test hiomap. The idea is to have a more open
model which, in addition to what you did, also tests for error cases.

Thanks

> Signed-off-by: Abhishek Singh Tomar<abhishek@linux.ibm.com>
>
> Abhishek Singh Tomar (9):
>    core/pldm/test : Implement PLDM self test common api
>    core/pldm/test :  Initialize pldm file I/O test
>    core/pldm/test :  Write file with PLDM file I/O message
>    core/pldm/test : Read file with PLDM file I/O message
>    core/pldm/test : Implement pldm bios specification test
>    core/pldm/test : Initialize pldm platform specification test
>    core/pldm/test : Implement pldm platform restart and power off request
>      test
>    core/pldm/test : Implement PLDM FRU table self test
>    core/pldm/test : Retrieve the BMC information with the FRU PLDM
>      message
>
>   core/pldm/pldm.h                         |   2 +-
>   core/pldm/test/Makefile.check            |  46 +++
>   core/pldm/test/common/test-pldm-common.c | 191 +++++++++++
>   core/pldm/test/test-pldm-bios.c          | 289 +++++++++++++++++
>   core/pldm/test/test-pldm-fileio.c        | 321 +++++++++++++++++++
>   core/pldm/test/test-pldm-fru.c           | 327 +++++++++++++++++++
>   core/pldm/test/test-pldm-platform.c      | 386 +++++++++++++++++++++++
>   7 files changed, 1561 insertions(+), 1 deletion(-)
>   create mode 100644 core/pldm/test/Makefile.check
>   create mode 100644 core/pldm/test/common/test-pldm-common.c
>   create mode 100644 core/pldm/test/test-pldm-bios.c
>   create mode 100644 core/pldm/test/test-pldm-fileio.c
>   create mode 100644 core/pldm/test/test-pldm-fru.c
>   create mode 100644 core/pldm/test/test-pldm-platform.c
>