mbox series

[v2,0/9] PLDM implementation self test

Message ID 20220507063602.66309-1-abhishek@linux.ibm.com
Headers show
Series PLDM implementation self test | expand

Message

Abhishek Singh Tomar May 7, 2022, 6:35 a.m. UTC 
These patches contains PLDM implementation self test. These self test
are not hardare dependent as they bypass harware dependent code.
They tries to test codeflow for following PLDM type
 1. PLDM FILE I/O
 2. PLDM BIOS
 3. PLDM PLATFORM
 4. PLDM FRU

This patch set is to be applied over
commit 1e4b3b38db54f2e770d44119d5eb5c887df01d44

Abhishek Singh Tomar (9):
  core/pldm/test :  pldm self test common
  core/pldm/test :  pldm file I/O init Self test
  core/pldm/test :  pldm file I/O write file Self test
  core/pldm/test :  pldm file I/O read file Self test
  core/pldm/test :  pldm BIOS Specification Self test
  core/pldm/test :  pldm platform specification Init self test
  core/pldm/test :  pldm platform restart and platform power off self
    test
  core/pldm/test :  pldm FRU Table selftest
  core/pldm/test :  pldm FRU implementation to retrieve the bmc
    information

 core/pldm/pldm-file-io-requests.c        |  12 +-
 core/pldm/pldm-lid-files.c               |  16 +-
 core/pldm/pldm.h                         |   2 +-
 core/pldm/test/Makefile.check            |  45 +++
 core/pldm/test/common/test_pldm-common.c | 195 ++++++++++++
 core/pldm/test/test_pldm-bios.c          | 259 ++++++++++++++++
 core/pldm/test/test_pldm-fileio.c        | 315 +++++++++++++++++++
 core/pldm/test/test_pldm-fru.c           | 336 ++++++++++++++++++++
 core/pldm/test/test_pldm-platform.c      | 378 +++++++++++++++++++++++
 9 files changed, 1552 insertions(+), 6 deletions(-)
 create mode 100644 core/pldm/test/Makefile.check
 create mode 100644 core/pldm/test/common/test_pldm-common.c
 create mode 100644 core/pldm/test/test_pldm-bios.c
 create mode 100644 core/pldm/test/test_pldm-fileio.c
 create mode 100644 core/pldm/test/test_pldm-fru.c
 create mode 100644 core/pldm/test/test_pldm-platform.c

Comments

Christophe Lombard May 10, 2022, 2:46 p.m. UTC | #1 
Le 07/05/2022 à 08:35, Abhishek Singh Tomar a écrit :
> These patches contains PLDM implementation self test. These self test
> are not hardare dependent as they bypass harware dependent code.
> They tries to test codeflow for following PLDM type
>   1. PLDM FILE I/O
>   2. PLDM BIOS
>   3. PLDM PLATFORM
>   4. PLDM FRU
>
> This patch set is to be applied over
> commit 1e4b3b38db54f2e770d44119d5eb5c887df01d44

The patch set, you are referencing, is not committed yet.
You could write:

This patch set should be applied on top of these previous sets:
- Implement virtual flash content using PLDM.
- Import external libraries for MCTP/PLDM protocols.
- Implement MCTP and PLDM features.
- Complete PLDM responder and enable PLDM support


> Abhishek Singh Tomar (9):
>    core/pldm/test :  pldm self test common
>    core/pldm/test :  pldm file I/O init Self test
>    core/pldm/test :  pldm file I/O write file Self test
>    core/pldm/test :  pldm file I/O read file Self test
>    core/pldm/test :  pldm BIOS Specification Self test
>    core/pldm/test :  pldm platform specification Init self test
>    core/pldm/test :  pldm platform restart and platform power off self
>      test
>    core/pldm/test :  pldm FRU Table selftest
>    core/pldm/test :  pldm FRU implementation to retrieve the bmc
>      information
>
>   core/pldm/pldm-file-io-requests.c        |  12 +-
>   core/pldm/pldm-lid-files.c               |  16 +-
>   core/pldm/pldm.h                         |   2 +-
>   core/pldm/test/Makefile.check            |  45 +++
>   core/pldm/test/common/test_pldm-common.c | 195 ++++++++++++
>   core/pldm/test/test_pldm-bios.c          | 259 ++++++++++++++++
>   core/pldm/test/test_pldm-fileio.c        | 315 +++++++++++++++++++
>   core/pldm/test/test_pldm-fru.c           | 336 ++++++++++++++++++++
>   core/pldm/test/test_pldm-platform.c      | 378 +++++++++++++++++++++++
>   9 files changed, 1552 insertions(+), 6 deletions(-)
>   create mode 100644 core/pldm/test/Makefile.check
>   create mode 100644 core/pldm/test/common/test_pldm-common.c
>   create mode 100644 core/pldm/test/test_pldm-bios.c
>   create mode 100644 core/pldm/test/test_pldm-fileio.c
>   create mode 100644 core/pldm/test/test_pldm-fru.c
>   create mode 100644 core/pldm/test/test_pldm-platform.c
>
Abhishek Singh Tomar May 11, 2022, 7:31 a.m. UTC | #2 
On Tue, May 10, 2022 at 04:46:45PM +0200, Christophe Lombard wrote:
> 
> Le 07/05/2022 à 08:35, Abhishek Singh Tomar a écrit :
> > These patches contains PLDM implementation self test. These self test
> > are not hardare dependent as they bypass harware dependent code.
> > They tries to test codeflow for following PLDM type
> >   1. PLDM FILE I/O
> >   2. PLDM BIOS
> >   3. PLDM PLATFORM
> >   4. PLDM FRU
> > 
> > This patch set is to be applied over
> > commit 1e4b3b38db54f2e770d44119d5eb5c887df01d44
> 
> The patch set, you are referencing, is not committed yet.
> You could write:
> 
> This patch set should be applied on top of these previous sets:
> - Implement virtual flash content using PLDM.
> - Import external libraries for MCTP/PLDM protocols.
> - Implement MCTP and PLDM features.
> - Complete PLDM responder and enable PLDM support
OK, I will do this in v3 of the patch set.
> 
> 
> > Abhishek Singh Tomar (9):
> >    core/pldm/test :  pldm self test common
> >    core/pldm/test :  pldm file I/O init Self test
> >    core/pldm/test :  pldm file I/O write file Self test
> >    core/pldm/test :  pldm file I/O read file Self test
> >    core/pldm/test :  pldm BIOS Specification Self test
> >    core/pldm/test :  pldm platform specification Init self test
> >    core/pldm/test :  pldm platform restart and platform power off self
> >      test
> >    core/pldm/test :  pldm FRU Table selftest
> >    core/pldm/test :  pldm FRU implementation to retrieve the bmc
> >      information
> > 
> >   core/pldm/pldm-file-io-requests.c        |  12 +-
> >   core/pldm/pldm-lid-files.c               |  16 +-
> >   core/pldm/pldm.h                         |   2 +-
> >   core/pldm/test/Makefile.check            |  45 +++
> >   core/pldm/test/common/test_pldm-common.c | 195 ++++++++++++
> >   core/pldm/test/test_pldm-bios.c          | 259 ++++++++++++++++
> >   core/pldm/test/test_pldm-fileio.c        | 315 +++++++++++++++++++
> >   core/pldm/test/test_pldm-fru.c           | 336 ++++++++++++++++++++
> >   core/pldm/test/test_pldm-platform.c      | 378 +++++++++++++++++++++++
> >   9 files changed, 1552 insertions(+), 6 deletions(-)
> >   create mode 100644 core/pldm/test/Makefile.check
> >   create mode 100644 core/pldm/test/common/test_pldm-common.c
> >   create mode 100644 core/pldm/test/test_pldm-bios.c
> >   create mode 100644 core/pldm/test/test_pldm-fileio.c
> >   create mode 100644 core/pldm/test/test_pldm-fru.c
> >   create mode 100644 core/pldm/test/test_pldm-platform.c
> >