From patchwork Thu Mar 7 14:07:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Miroshnichenko X-Patchwork-Id: 1052933 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44FXZL4ysrz9sMQ for ; Fri, 8 Mar 2019 01:09:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=yadro.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yadro.com header.i=@yadro.com header.b="vk1e8B14"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44FXZL3nMkzDqJs for ; Fri, 8 Mar 2019 01:09:46 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=yadro.com (client-ip=89.207.88.251; helo=mta-01.yadro.com; envelope-from=s.miroshnichenko@yadro.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=yadro.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=yadro.com header.i=@yadro.com header.b="vk1e8B14"; dkim-atps=neutral Received: from mta-01.yadro.com (mta-01.yadro.com [89.207.88.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44FXYH4y9YzDqCD for ; Fri, 8 Mar 2019 01:08:51 +1100 (AEDT) Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id B20204197C; Thu, 7 Mar 2019 14:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= content-type:content-type:content-transfer-encoding:mime-version :x-mailer:message-id:date:date:subject:subject:from:from :received:received:received; s=mta-01; t=1551967723; x= 1553782124; bh=Eg1mqRLFqlfZ+fZ4S75S/xzhUw2D23djjTUvmcePPco=; b=v k1e8B14GKrNP844mU3jnxf3MW8hNDGsXHOJn0Fc4F7dnAMnMXIvxGI7jtL5OBj5n 2lIOacUh10bOpfR9D6HhmKR48MYLl+8HNxT1S5BvgZdpQ/Kw7qKZARrrVQFoPfn1 bGRYiDKq0k2B48RkEA/d9UGVUghssMlnkN6yDtfwvM= X-Virus-Scanned: amavisd-new at yadro.com Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JvoqdzRzDe_7; Thu, 7 Mar 2019 17:08:43 +0300 (MSK) Received: from T-EXCH-02.corp.yadro.com (t-exch-02.corp.yadro.com [172.17.10.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 7845041973; Thu, 7 Mar 2019 17:08:42 +0300 (MSK) Received: from NB-148.yadro.com (172.17.15.60) by T-EXCH-02.corp.yadro.com (172.17.10.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Thu, 7 Mar 2019 17:08:42 +0300 From: Sergey Miroshnichenko To: Date: Thu, 7 Mar 2019 17:07:30 +0300 Message-ID: <20190307140736.26787-1-s.miroshnichenko@yadro.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [172.17.15.60] X-ClientProxiedBy: T-EXCH-01.corp.yadro.com (172.17.10.101) To T-EXCH-02.corp.yadro.com (172.17.10.102) Subject: [Skiboot] [PATCH RFC v2 0/6] core/pci: Sync VFs and the changes of bdfns between the firmware and the OS X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stewart Smith , linux@yadro.com Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" An OS may re-enumerate the PCIe tree during boot or after hot-plugging a bridge, but this leads to de-sync of the cached and actual BDF addresses. This patchset tracks the changes in bus numbers and updates the cached topology (a tree consisting of struct pci_device nodes) correspondingly, including allocation of newly discovered devices and activated virtual functions within SR-IOV. Tested on POWER8 PowerNV+PHB3 ppc64le (our Vesnin server) with: * Linux kernel 5.0; - the pciehp driver active; - the pnv_php driver disabled; - Extra pacthes applied: "powerpc/powernv/pci: Make hotplug self-sufficient, independent of FW and DT"; - surprise hotplug of an NVME disk works; - controlled hotplug of a network card with SR-IOV works; - activating of SR-IOV on a network card works; - [with extra patches] manually initiated (via sysfs) rescan has found and turned on a hotplugged bridge; * Ubuntu's 4.15.0-45-generic kernel from 18.04.2 LTS: - boots and works just fine. Changes since v1: - Fixed comparing 32-bit constant with uint16_t and uint8_t. Sergey Miroshnichenko (6): core/pci: Add functions to find accessible devices by bdfn core/pci: Make the pci_scan_one() function public core/pci: Create the struct pci_device nodes automatically pci-iov: Fix device allocation for VFs pci-iov: Set parent of VFs to the bridge's downstream instead of PF core/pci: Hook up the writes to PRIMARY/SECONDARY/SUBORDINATE_BUS registers core/pci-iov.c | 27 +++++++------ core/pci-opal.c | 101 +++++++++++++++++++++++++++++++++++++++++++++--- core/pci.c | 87 ++++++++++++++++++++++++++++++++++++++++- include/pci.h | 4 ++ 4 files changed, 201 insertions(+), 18 deletions(-)