From patchwork Mon Jan 6 19:21:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Deb McLemore X-Patchwork-Id: 1218454 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47s5wC1zqJz9sR8 for ; Tue, 7 Jan 2020 07:00:27 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47s5wC08z3zDqHq for ; Tue, 7 Jan 2020 07:00:27 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=debmc@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47s5lC1J3czDqG8 for ; Tue, 7 Jan 2020 06:52:38 +1100 (AEDT) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 006JqS2J102104 for ; Mon, 6 Jan 2020 14:52:35 -0500 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0b-001b2d01.pphosted.com with ESMTP id 2xb8wfvupb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 Jan 2020 14:52:35 -0500 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 006JoF8I021831 for ; Mon, 6 Jan 2020 19:52:41 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma01wdc.us.ibm.com with ESMTP id 2xajb64ug5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 Jan 2020 19:52:41 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 006JqXI744958152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 6 Jan 2020 19:52:34 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D31CA136053 for ; Mon, 6 Jan 2020 19:52:33 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B78AD136055 for ; Mon, 6 Jan 2020 19:52:33 +0000 (GMT) Received: from oc4402612711.ibm.com (unknown [9.41.175.242]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP for ; Mon, 6 Jan 2020 19:52:33 +0000 (GMT) Received: by oc4402612711.ibm.com (Postfix, from userid 1000) id 4980AAE034B; Mon, 6 Jan 2020 13:22:20 -0600 (CST) From: Deb McLemore To: skiboot@lists.ozlabs.org Date: Mon, 6 Jan 2020 13:21:35 -0600 Message-Id: <1578338508-13424-1-git-send-email-debmc@linux.ibm.com> X-Mailer: git-send-email 1.8.3.1 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95, 18.0.572 definitions=2020-01-06_06:2020-01-06, 2020-01-06 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 suspectscore=1 phishscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=757 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001060165 Subject: [Skiboot] [PATCH v3 00/13] ipmi-hiomap: Enablement for Async opal_flash_op's X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Deb McLemore MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" From: Deb McLemore This series optimizes opal_flash_op's by breaking the buffer sizes into smaller chunks. The IPMI window movements are re-worked to not re-enter OPAL since the poller design is a limiting factor. The smaller buffer chunk sizes allow operations to be re-queued, which allows OPAL to jump back out to Linux to prevent RCU or scheduler issues. v3: Patch 6 updated some comments, removed MASK's and new name for define FLASH_ERR_ASYNC_WORK (old was FLASH_ERR_MISSED_CC). v2: Patch 7 fixed irqmask handling Patch 8 removed (the SuperIO handling, misunderstanding clarified) Patch 12 fixed root bug for ipmi timer scheduling Patch 13 added log helpers v1: Patch 1-5 were inherited from previous foundation work which provide base enablement. Patch 6 is the core of the re-work for IPMI window moving and re-queue'ing. Patch 7 and 8 were issues addressed during test which surfaced and needed fixing. Patch 9-11 are additional logging which aides debug where timing paths become critical. Patch 12 enables the IPMI messages to be efficiently returned since re-queues need to be turned around more readily. Cyril Bur (4): core/flash: Allow OPAL flash calls for size equal to flash core/flash: Make flash_reserve() and flash_release() use any flash core/flash: Don't hold flash_lock for the entirety of an opal_flash_op() core/flash: Make opal_flash_op() actually asynchronous Deb McLemore (8): hiomap: Enable Async IPMI messaging lpc: Fix lpc probe irqmask handling hw/bt: Add some more queue debug core/flash: Update some logging libflash/ipmi-hiomap: Add some debug logging lpc: Add logging for hardware diagnostics hw/bt: Allow ipmi regular intervals libflash/ipmi-hiomap: Add helpers for logging Stewart Smith (1): qemu: 1ms heartbeat time core/flash.c | 327 +++++++++++-- core/timer.c | 8 + hw/bt.c | 8 +- hw/ipmi/ipmi-sel.c | 4 +- hw/lpc.c | 39 +- include/skiboot.h | 4 +- libflash/blocklevel.h | 2 + libflash/errors.h | 1 + libflash/ipmi-hiomap.c | 1186 +++++++++++++++++++++++++++++++++++++----------- libflash/ipmi-hiomap.h | 41 +- platforms/qemu/qemu.c | 9 + 11 files changed, 1292 insertions(+), 337 deletions(-)