Message ID | 4D3E574B.4070700@nvidia.com |
---|---|
State | Rejected |
Headers | show
Return-Path: <rtc-linux+bncCIvl7-yPBRDPrvnpBBoEHP1MOg@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pz0-f56.google.com (mail-pz0-f56.google.com [209.85.210.56]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 9AB7FB70F1 for <incoming@patchwork.ozlabs.org>; Tue, 25 Jan 2011 15:53:38 +1100 (EST) Received: by pzk2 with SMTP id 2sf1664657pzk.11 for <incoming@patchwork.ozlabs.org>; Mon, 24 Jan 2011 20:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:x-beenthere:received-spf:x-pgp-universal :message-id:date:from:organization:user-agent:mime-version:to:cc :subject:x-original-sender:x-original-authentication-results :reply-to:precedence:mailing-list:list-id:list-post:list-help :list-archive:sender:list-subscribe:list-unsubscribe:content-type; bh=vgpOMoPtUktlkzJ9PGIC/1RpgOO6gPLBzZQ2nyUOQeI=; b=PEp9yMyaMcsKY6aRe31LD9B62f61brMZrp3suZaqFb0E8aFE/i1YmLtGLHrhcSPHH3 oBc1raYoIxRcd25gP4Y4WZS3CO+OpsqZf/sK6dVleW2zLBXuIq4baAD+jZ61y9org8sf 5SEGGuxRbPpP3yxqyNCfvfFxcTGOn4Oenw6JE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:x-pgp-universal:message-id:date:from :organization:user-agent:mime-version:to:cc:subject :x-original-sender:x-original-authentication-results:reply-to :precedence:mailing-list:list-id:list-post:list-help:list-archive :sender:list-subscribe:list-unsubscribe:content-type; b=Pi7a99v82bTLPmGa3XLIUOyiV7JstCThgr97HYLzvna/LjqF1GJXKU527+tFXtY5oW 9aw2qgB97jjlqtxdCChqyv5VTQsvJUR2n4/DiGeGc/8AmPANU3rhxUg25KmQY6dQ7k8p 0PmpFtbWL3MSl9XYIwz+hIiIQSby0re36IcaQ= Received: by 10.142.239.11 with SMTP id m11mr274512wfh.2.1295931215612; Mon, 24 Jan 2011 20:53:35 -0800 (PST) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.142.2.41 with SMTP id 41ls144291wfb.0.p; Mon, 24 Jan 2011 20:53:35 -0800 (PST) Received: by 10.142.51.16 with SMTP id y16mr368383wfy.47.1295931215397; Mon, 24 Jan 2011 20:53:35 -0800 (PST) Received: by 10.142.51.16 with SMTP id y16mr368382wfy.47.1295931215373; Mon, 24 Jan 2011 20:53:35 -0800 (PST) Received: from hqemgate03.nvidia.com (hqemgate03.nvidia.com [216.228.121.140]) by gmr-mx.google.com with ESMTPS id w1si3402225wfo.1.2011.01.24.20.53.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 24 Jan 2011 20:53:35 -0800 (PST) Received-SPF: pass (google.com: domain of vwadekar@nvidia.com designates 216.228.121.140 as permitted sender) client-ip=216.228.121.140; Received: from hqnvupgp05.nvidia.com (Not Verified[216.228.121.13]) by hqemgate03.nvidia.com id <B4d3e58e10003>; Mon, 24 Jan 2011 21:00:17 -0800 Received: from hqemhub01.nvidia.com ([172.17.108.22]) by hqnvupgp05.nvidia.com (PGP Universal service); Mon, 24 Jan 2011 20:42:28 -0800 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Mon, 24 Jan 2011 20:42:28 -0800 Received: from [10.24.109.4] (172.20.144.16) by hqemhub01.nvidia.com (172.17.98.26) with Microsoft SMTP Server id 8.2.254.0; Mon, 24 Jan 2011 20:53:34 -0800 Message-ID: <4D3E574B.4070700@nvidia.com> Date: Tue, 25 Jan 2011 10:23:31 +0530 From: Varun Wadekar <vwadekar@nvidia.com> Organization: NVIDIA Corporation User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: <rtc-linux@googlegroups.com> CC: Alessandro Zummo <a.zummo@towertech.it>, "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>, Andy Ritger <ARitger@nvidia.com>, Stephen Warren <swarren@nvidia.com>, Bharat Nihalani <bnihalani@nvidia.com>, Varun Wadekar <vwadekar@nvidia.com> Subject: [rtc-linux] [PATCH 2/2] rtc: tps6586x: fix error in tick calculations. X-Original-Sender: vwadekar@nvidia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of vwadekar@nvidia.com designates 216.228.121.140 as permitted sender) smtp.mail=vwadekar@nvidia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: <rtc-linux.googlegroups.com> List-Post: <http://groups.google.com/group/rtc-linux/post?hl=en_US>, <mailto:rtc-linux@googlegroups.com> List-Help: <http://groups.google.com/support/?hl=en_US>, <mailto:rtc-linux+help@googlegroups.com> List-Archive: <http://groups.google.com/group/rtc-linux?hl=en_US> Sender: rtc-linux@googlegroups.com List-Subscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+subscribe@googlegroups.com> List-Unsubscribe: <http://groups.google.com/group/rtc-linux/subscribe?hl=en_US>, <mailto:rtc-linux+unsubscribe@googlegroups.com> Content-Type: text/plain; charset=ISO-8859-1 |
diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c index 9ab93cb..ca6138b 100644 --- a/drivers/rtc/rtc-tps6586x.c +++ b/drivers/rtc/rtc-tps6586x.c @@ -95,7 +95,7 @@ static int tps6586x_rtc_set_time(struct device *dev, struct rtc_time *tm) seconds -= rtc->epoch_start; - ticks = seconds << 10; + ticks = (unsigned long long)seconds << 10; buff[0] = (ticks >> 32) & 0xff; buff[1] = (ticks >> 24) & 0xff;
This patch depends on patch 1: ---- rtc: tps6586x: fix error in tick calculations. when converting from seconds to ticks using a shift operator, the most significant bits were being lost due to seconds being a 32-bit value and ticks being a 64-bit value. a hard cast was added to avoid this loss. Signed-off-by: Lowell Dennis <ldennis@nvidia.com> buff[2] = (ticks >> 16) & 0xff; @@ -148,7 +148,7 @@ static int tps6586x_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) } seconds -= rtc->epoch_start; - ticks = (seconds << 10) & 0xffffff; + ticks = (unsigned long long)seconds << 10; buff[0] = (ticks >> 16) & 0xff; buff[1] = (ticks >> 8) & 0xff; nvpublic