From patchwork Tue Jun 22 08:35:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wan ZongShun X-Patchwork-Id: 56413 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-pw0-f56.google.com (mail-pw0-f56.google.com [209.85.160.56]) by ozlabs.org (Postfix) with ESMTP id A802BB6EF0 for ; Tue, 22 Jun 2010 18:39:37 +1000 (EST) Received: by pwi5 with SMTP id 5sf949964pwi.11 for ; Tue, 22 Jun 2010 01:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=domainkey-signature:received:x-beenthere:received:received:received :received:received-spf:received:received:received:message-id:date :from:user-agent:mime-version:to:subject:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; bh=WsgXFg1VrDTH8/cPzXexi2BzFJZt04pbWZqoARIHjY4=; b=bZdv3maWRf2BgPRjs5XGP6jwVOCfoLzpZWCCkYjI6KXInvYfkqD9pelipO/yC3EHJW D19ktSIMkYnoUE/FtdLSSTVPEly37ejb/jQzHjXyB/NIYJ0DE/RkCRFpflRGMD82qw4e uST12zXNd89hHQJ4E8sv0W3i/lz7yK74v7F4I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:message-id:date:from:user-agent :mime-version:to:subject:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:sender:list-subscribe :list-unsubscribe:content-type; b=JbVrqWuzmSm57GeDSVINRdZMiKCtHhnyPsZOP6NA8Ye+JU37H9VuzRUlnbd44qJpnV EMllycD+gX8OXNTK/dj1PSynOQ9BR8DklwXSk9/OoymeU4jA4ePYbnH8MOEQ4Q57+4w5 Eyc3iJ3ZoZBW3TEPhhDK0IF0V4wUk7RjzwADU= Received: by 10.115.38.26 with SMTP id q26mr459707waj.26.1277195714264; Tue, 22 Jun 2010 01:35:14 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.115.135.31 with SMTP id m31ls3106442wan.1.p; Tue, 22 Jun 2010 01:35:13 -0700 (PDT) Received: by 10.115.25.19 with SMTP id c19mr1026874waj.34.1277195713014; Tue, 22 Jun 2010 01:35:13 -0700 (PDT) Received: by 10.115.25.19 with SMTP id c19mr1026873waj.34.1277195712956; Tue, 22 Jun 2010 01:35:12 -0700 (PDT) Received: from mail-px0-f177.google.com (mail-px0-f177.google.com [209.85.212.177]) by gmr-mx.google.com with ESMTP id e19si29625895wam.4.2010.06.22.01.35.11; Tue, 22 Jun 2010 01:35:11 -0700 (PDT) Received-SPF: pass (google.com: domain of mcuos.com@gmail.com designates 209.85.212.177 as permitted sender) client-ip=209.85.212.177; Received: by mail-px0-f177.google.com with SMTP id 8so233012pxi.8 for ; Tue, 22 Jun 2010 01:35:11 -0700 (PDT) Received: by 10.114.18.19 with SMTP id 19mr5230906war.174.1277195711730; Tue, 22 Jun 2010 01:35:11 -0700 (PDT) Received: from [192.168.1.10] ([116.226.201.224]) by mx.google.com with ESMTPS id n29sm32346863wae.16.2010.06.22.01.35.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 22 Jun 2010 01:35:11 -0700 (PDT) Message-ID: <4C2075B5.3040700@gmail.com> Date: Tue, 22 Jun 2010 16:35:01 +0800 From: Wan ZongShun User-Agent: Thunderbird 2.0.0.24 (X11/20100411) MIME-Version: 1.0 To: Wan ZongShun , Alessandro Zummo , rtc-linux , Andrew Morton Subject: [rtc-linux] [PATCH] RTC/m41t80: use rtc_valid_tm to check returning tm X-Original-Sender: mcuos.com@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of mcuos.com@gmail.com designates 209.85.212.177 as permitted sender) smtp.mail=mcuos.com@gmail.com; dkim=pass (test mode) header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , This patch is to use rtc_valid_tm for checking returning struct rtc_time *tm, it can avoid returning wrong tm value. Signed-off-by: Wan ZongShun --- drivers/rtc/rtc-m41t80.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index 6dc4e62..66377f3 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -121,7 +121,7 @@ static int m41t80_get_datetime(struct i2c_client *client, /* assume 20YY not 19YY, and ignore the Century Bit */ tm->tm_year = bcd2bin(buf[M41T80_REG_YEAR]) + 100; - return 0; + return rtc_valid_tm(tm); } /* Sets the given date and time to the real time clock. */ @@ -364,7 +364,7 @@ static int m41t80_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *t) t->time.tm_isdst = -1; t->enabled = !!(reg[M41T80_REG_ALARM_MON] & M41T80_ALMON_AFE); t->pending = !!(reg[M41T80_REG_FLAGS] & M41T80_FLAGS_AF); - return 0; + return rtc_valid_tm(t); } static struct rtc_class_ops m41t80_rtc_ops = {