diff mbox series

[v3,1/6] dt-bindings: watchdog: rockchip: Add rockchip,rv1126-wdt string

Message ID 20240912142451.2952633-2-karthikeyan@linumiz.com
State Handled Elsewhere
Headers show
Series Add support Relfor Saib board which is based on Rockchip RV1109 SoC | expand

Commit Message

karthikeyan Sept. 12, 2024, 2:24 p.m. UTC
Add rockchip,rv1126-wdt compatible string.

Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v3:
    - add watchdog compatible string

 Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Sept. 12, 2024, 5:30 p.m. UTC | #1
On Thu, Sep 12, 2024 at 07:54:46PM +0530, Karthikeyan Krishnasamy wrote:
> Add rockchip,rv1126-wdt compatible string.
> 
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> ---
> 
> Notes:
>     v3:
>     - add watchdog compatible string
> 
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index c7aab0418a32..bccd27a1e470 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -31,6 +31,7 @@ properties:
>                - rockchip,rk3568-wdt
>                - rockchip,rk3588-wdt
>                - rockchip,rv1108-wdt
> +              - rockchip,rv1126-wdt
>            - const: snps,dw-wdt
>  
>    reg:
> -- 
> 2.39.2
>
Heiko Stübner Sept. 17, 2024, 11:16 p.m. UTC | #2
Hey,

Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan Krishnasamy:
> Add rockchip,rv1126-wdt compatible string.
> 
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>

I think this patch misses some recipients because neither
the watchdog maintainers nor the watchdog list is included.

We'll need for them to at least Ack this patch, so they'll
need to be included. Please check your scripts/get_maintainer.pl
call


Thanks
Heiko

> ---
> 
> Notes:
>     v3:
>     - add watchdog compatible string
> 
>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> index c7aab0418a32..bccd27a1e470 100644
> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> @@ -31,6 +31,7 @@ properties:
>                - rockchip,rk3568-wdt
>                - rockchip,rk3588-wdt
>                - rockchip,rv1108-wdt
> +              - rockchip,rv1126-wdt
>            - const: snps,dw-wdt
>  
>    reg:
>
karthikeyan Sept. 18, 2024, 7:29 a.m. UTC | #3
On 9/18/24 04:46, Heiko Stuebner wrote:
> Hey,
> 
> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan Krishnasamy:
>> Add rockchip,rv1126-wdt compatible string.
>>
>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> 
> I think this patch misses some recipients because neither
> the watchdog maintainers nor the watchdog list is included.
> 
> We'll need for them to at least Ack this patch, so they'll
> need to be included. Please check your scripts/get_maintainer.pl
> call
> 
> 
> Thanks
> Heiko
> 
Apologies for missing them. Adding them in this reply mail.
>> ---
>>
>> Notes:
>>      v3:
>>      - add watchdog compatible string
>>
>>   Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>> index c7aab0418a32..bccd27a1e470 100644
>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>> @@ -31,6 +31,7 @@ properties:
>>                 - rockchip,rk3568-wdt
>>                 - rockchip,rk3588-wdt
>>                 - rockchip,rv1108-wdt
>> +              - rockchip,rv1126-wdt
>>             - const: snps,dw-wdt
>>   
>>     reg:
>>
> 
> 
> 
> 

Best Regards,
Karthikeyan
karthikeyan Oct. 7, 2024, 1:56 p.m. UTC | #4
On 9/18/24 12:59, karthikeyan wrote:
> 
> 
> On 9/18/24 04:46, Heiko Stuebner wrote:
>> Hey,
>>
>> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan 
>> Krishnasamy:
>>> Add rockchip,rv1126-wdt compatible string.
>>>
>>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
>>
>> I think this patch misses some recipients because neither
>> the watchdog maintainers nor the watchdog list is included.
>>
>> We'll need for them to at least Ack this patch, so they'll
>> need to be included. Please check your scripts/get_maintainer.pl
>> call
>>
>>
>> Thanks
>> Heiko
>>
> Apologies for missing them. Adding them in this reply mail.
>>> ---
>>>
>>> Notes:
>>>      v3:
>>>      - add watchdog compatible string
>>>
>>>   Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml 
>>> b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> index c7aab0418a32..bccd27a1e470 100644
>>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
>>> @@ -31,6 +31,7 @@ properties:
>>>                 - rockchip,rk3568-wdt
>>>                 - rockchip,rk3588-wdt
>>>                 - rockchip,rv1108-wdt
>>> +              - rockchip,rv1126-wdt
>>>             - const: snps,dw-wdt
>>>     reg:
>>>
>>
>>
>>
>>
> 
> Best Regards,
> Karthikeyan

Gentle remainder.

Best Regards,
Karthikeyan
Heiko Stübner Oct. 8, 2024, 7:26 p.m. UTC | #5
Hi,

Am Montag, 7. Oktober 2024, 15:56:58 CEST schrieb karthikeyan:
> 
> On 9/18/24 12:59, karthikeyan wrote:
> > 
> > 
> > On 9/18/24 04:46, Heiko Stuebner wrote:
> >> Hey,
> >>
> >> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan 
> >> Krishnasamy:
> >>> Add rockchip,rv1126-wdt compatible string.
> >>>
> >>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> >>
> >> I think this patch misses some recipients because neither
> >> the watchdog maintainers nor the watchdog list is included.
> >>
> >> We'll need for them to at least Ack this patch, so they'll
> >> need to be included. Please check your scripts/get_maintainer.pl
> >> call
> >>
> >>
> >> Thanks
> >> Heiko
> >>
> > Apologies for missing them. Adding them in this reply mail.

I don't think that will have worked.

Ideally can you include Conor's Ack and resend only the watchdog binding
patch to the watchdog maintainers (and lists and me too please) .

Because just adding more people to a reply probably won't tell them
that some action is expected.

Heiko
karthikeyan Oct. 9, 2024, 8:44 a.m. UTC | #6
On 10/9/24 00:56, Heiko Stübner wrote:
> Hi,
> 
> Am Montag, 7. Oktober 2024, 15:56:58 CEST schrieb karthikeyan:
>>
>> On 9/18/24 12:59, karthikeyan wrote:
>>>
>>>
>>> On 9/18/24 04:46, Heiko Stuebner wrote:
>>>> Hey,
>>>>
>>>> Am Donnerstag, 12. September 2024, 16:24:46 CEST schrieb Karthikeyan
>>>> Krishnasamy:
>>>>> Add rockchip,rv1126-wdt compatible string.
>>>>>
>>>>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
>>>>
>>>> I think this patch misses some recipients because neither
>>>> the watchdog maintainers nor the watchdog list is included.
>>>>
>>>> We'll need for them to at least Ack this patch, so they'll
>>>> need to be included. Please check your scripts/get_maintainer.pl
>>>> call
>>>>
>>>>
>>>> Thanks
>>>> Heiko
>>>>
>>> Apologies for missing them. Adding them in this reply mail.
> 
> I don't think that will have worked.
> 
> Ideally can you include Conor's Ack and resend only the watchdog binding
> patch to the watchdog maintainers (and lists and me too please) .
> 
> Because just adding more people to a reply probably won't tell them
> that some action is expected.
> 
> Heiko
> 
> 

Thanks for your info. It's my mistake. I will resend the watchdog patch 
alone.

Best regards,
Karthikeyan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
index c7aab0418a32..bccd27a1e470 100644
--- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
@@ -31,6 +31,7 @@  properties:
               - rockchip,rk3568-wdt
               - rockchip,rk3588-wdt
               - rockchip,rv1108-wdt
+              - rockchip,rv1126-wdt
           - const: snps,dw-wdt
 
   reg: