| Message ID | 20230518113643.420806-4-biju.das.jz@bp.renesas.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add Renesas PMIC RAA215300 and built-in RTC support | expand |
On Thu, May 18, 2023 at 12:36:35PM +0100, Biju Das wrote: > As per the HW manual, XTOSCB bit setting is as follows > > If using an external clock signal, set the XTOSCB bit as 1 to > disable the crystal oscillator. > > If using an external crystal, the XTOSCB bit needs to be set at 0 > to enable the crystal oscillator. > > Document clock and clock-names properties. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> I notice on v3 you appealed to Rob or Krzysztof for approval about this approach. Clearly I not either of them, but it seems reasonable to me. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > v4: > * New patch > --- > .../devicetree/bindings/rtc/isil,isl1208.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > index 565965147ce6..6c270dd53605 100644 > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > @@ -25,6 +25,19 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > + clock-names: > + description: | > + Use xin, if connected to an external crystal. > + Use clkin, if connected to an external clock signal. > + oneOf: > + - items: > + - const: xin > + - items: > + - const: clkin > + > interrupts: > minItems: 1 > maxItems: 2 > -- > 2.25.1 >
Hi Biju, On Thu, May 18, 2023 at 1:37 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > As per the HW manual, XTOSCB bit setting is as follows > > If using an external clock signal, set the XTOSCB bit as 1 to > disable the crystal oscillator. > > If using an external crystal, the XTOSCB bit needs to be set at 0 > to enable the crystal oscillator. > > Document clock and clock-names properties. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v4: > * New patch Thanks for your patch! > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > @@ -25,6 +25,19 @@ properties: > reg: > maxItems: 1 > > + clocks: > + maxItems: 1 > + > + clock-names: > + description: | > + Use xin, if connected to an external crystal. > + Use clkin, if connected to an external clock signal. > + oneOf: > + - items: > + - const: xin > + - items: > + - const: clkin > + I guess that oneOf scheme is equivalent to the simpler enum: - xin - clkin ? Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v4 03/11] dt-bindings: rtc: isil,isl1208: Document > clock and clock-names properties > > Hi Biju, > > On Thu, May 18, 2023 at 1:37 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > As per the HW manual, XTOSCB bit setting is as follows > > > > If using an external clock signal, set the XTOSCB bit as 1 to disable > > the crystal oscillator. > > > > If using an external crystal, the XTOSCB bit needs to be set at 0 to > > enable the crystal oscillator. > > > > Document clock and clock-names properties. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v4: > > * New patch > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml > > @@ -25,6 +25,19 @@ properties: > > reg: > > maxItems: 1 > > > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + description: | > > + Use xin, if connected to an external crystal. > > + Use clkin, if connected to an external clock signal. > > + oneOf: > > + - items: > > + - const: xin > > + - items: > > + - const: clkin > > + > > I guess that oneOf scheme is equivalent to the simpler > > enum: > - xin > - clkin Agreed. Cheers, Biju
diff --git a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml index 565965147ce6..6c270dd53605 100644 --- a/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml +++ b/Documentation/devicetree/bindings/rtc/isil,isl1208.yaml @@ -25,6 +25,19 @@ properties: reg: maxItems: 1 + clocks: + maxItems: 1 + + clock-names: + description: | + Use xin, if connected to an external crystal. + Use clkin, if connected to an external clock signal. + oneOf: + - items: + - const: xin + - items: + - const: clkin + interrupts: minItems: 1 maxItems: 2
As per the HW manual, XTOSCB bit setting is as follows If using an external clock signal, set the XTOSCB bit as 1 to disable the crystal oscillator. If using an external crystal, the XTOSCB bit needs to be set at 0 to enable the crystal oscillator. Document clock and clock-names properties. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v4: * New patch --- .../devicetree/bindings/rtc/isil,isl1208.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)