| Message ID | 20220520082500.489248-1-miquel.raynal@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | rtc: rzn1: Fix a variable type | expand |
On Fri, 20 May 2022 10:25:00 +0200, Miquel Raynal wrote: > The calculation in ->set_offset() handles both negative and positive > offsets. The 'steps' variable will be checked to be in a specific [-x; > +x] range, which means it must be a signed integer rather than > unsigned. > > This also fixes the following smatch warning: > > [...] Applied, thanks! [1/1] rtc: rzn1: Fix a variable type commit: 3f3489248927a53fcfec571ff603163f6b676a46 Best regards,
diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c index bdd4ebd5c887..66405b43ae7e 100644 --- a/drivers/rtc/rtc-rzn1.c +++ b/drivers/rtc/rtc-rzn1.c @@ -270,8 +270,7 @@ static int rzn1_rtc_read_offset(struct device *dev, long *offset) static int rzn1_rtc_set_offset(struct device *dev, long offset) { struct rzn1_rtc *rtc = dev_get_drvdata(dev); - unsigned int steps; - int stepsh, stepsl; + int stepsh, stepsl, steps; u32 subu = 0, ctl2; int ret;
The calculation in ->set_offset() handles both negative and positive offsets. The 'steps' variable will be checked to be in a specific [-x; +x] range, which means it must be a signed integer rather than unsigned. This also fixes the following smatch warning: warn: 'steps' 'true' implies 'steps > 0' is 'true' Fixes: be4a11cf98af ("rtc: rzn1: Add oscillator offset support") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/rtc/rtc-rzn1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)