| Message ID | 1453877171-30510-1-git-send-email-k.kozlowski@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello Krzysztof, On 01/27/2016 03:46 AM, Krzysztof Kozlowski wrote: > Cleanup of entire driver of its dmesg output: > 1. Remove printing of the function name, because printing device name is > sufficient. This also makes the dev_err()-like functions more compact > and readable (not need of line break). > 2. Lower from info to debug printing of each RTC interrupt (no need to > make noise on each alarm). > 3. Remove dev_info() at beginning of probe because a message is already > always printed by either probe failure or from registering the RTC > device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On Wed, Jan 27, 2016 at 03:46:11PM +0900, Krzysztof Kozlowski wrote: > Cleanup of entire driver of its dmesg output: > 1. Remove printing of the function name, because printing device name is > sufficient. This also makes the dev_err()-like functions more compact > and readable (not need of line break). > 2. Lower from info to debug printing of each RTC interrupt (no need to > make noise on each alarm). > 3. Remove dev_info() at beginning of probe because a message is already > always printed by either probe failure or from registering the RTC > device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Looks good, Reviewed-by: Andi Shyti <andi.shyti@samsung.com> > --- > > Patch rebased on top of Javier's v4: > [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support > http://www.spinics.net/lists/arm-kernel/msg477194.html > > Feel free to join with these series. > --- > drivers/rtc/rtc-max77686.c | 39 ++++++++++++++------------------------- > 1 file changed, 14 insertions(+), 25 deletions(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index da47b1d85793..5a03e1ecad83 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -271,8 +271,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > info->drv_data->map[REG_RTC_UPDATE0], > data, data); > if (ret < 0) > - dev_err(info->dev, "%s: fail to write update reg(ret=%d, data=0x%x)\n", > - __func__, ret, data); > + dev_err(info->dev, "Fail to write update reg(ret=%d, data=0x%x)\n", > + ret, data); > else { > /* Minimum delay required before RTC update. */ > usleep_range(delay, delay * 2); > @@ -297,7 +297,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) > info->drv_data->map[REG_RTC_SEC], > data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to read time reg(%d)\n", __func__, ret); > + dev_err(info->dev, "Fail to read time reg(%d)\n", ret); > goto out; > } > > @@ -326,8 +326,7 @@ static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) > info->drv_data->map[REG_RTC_SEC], > data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write time reg(%d)\n", __func__, > - ret); > + dev_err(info->dev, "Fail to write time reg(%d)\n", ret); > goto out; > } > > @@ -355,8 +354,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > ret = regmap_bulk_read(info->max77686->rtc_regmap, > map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s:%d fail to read alarm reg(%d)\n", > - __func__, __LINE__, ret); > + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); > goto out; > } > > @@ -394,8 +392,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > alrm->pending = 0; > ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val); > if (ret < 0) { > - dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n", > - __func__, __LINE__, ret); > + dev_err(info->dev, "Fail to read status2 reg(%d)\n", ret); > goto out; > } > > @@ -426,8 +423,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > map[REG_ALARM1_SEC], data, > ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); > goto out; > } > > @@ -452,8 +448,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) > } > > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); > goto out; > } > > @@ -481,8 +476,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) > map[REG_ALARM1_SEC], data, > ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); > goto out; > } > > @@ -508,8 +502,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) > } > > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); > goto out; > } > > @@ -539,8 +532,7 @@ static int max77686_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > data, ARRAY_SIZE(data)); > > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); > goto out; > } > > @@ -575,7 +567,7 @@ static irqreturn_t max77686_rtc_alarm_irq(int irq, void *data) > { > struct max77686_rtc_info *info = data; > > - dev_info(info->dev, "%s:irq(%d)\n", __func__, irq); > + dev_dbg(info->dev, "RTC alarm IRQ: %d\n", irq); > > rtc_update_irq(info->rtc_dev, 1, RTC_IRQF | RTC_AF); > > @@ -605,8 +597,7 @@ static int max77686_rtc_init_reg(struct max77686_rtc_info *info) > info->drv_data->map[REG_RTC_CONTROLM], > data, ARRAY_SIZE(data)); > if (ret < 0) { > - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", > - __func__, ret); > + dev_err(info->dev, "Fail to write controlm reg(%d)\n", ret); > return ret; > } > > @@ -621,8 +612,6 @@ static int max77686_rtc_probe(struct platform_device *pdev) > const struct platform_device_id *id = platform_get_device_id(pdev); > int ret; > > - dev_info(&pdev->dev, "%s\n", __func__); > - > info = devm_kzalloc(&pdev->dev, sizeof(struct max77686_rtc_info), > GFP_KERNEL); > if (!info) > @@ -662,7 +651,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) > > if (!max77686->rtc_irq_data) { > ret = -EINVAL; > - dev_err(&pdev->dev, "%s: no RTC regmap IRQ chip\n", __func__); > + dev_err(&pdev->dev, "No RTC regmap IRQ chip\n"); > goto err_rtc; > } > > -- > 1.9.1
On 27/01/2016 at 15:46:11 +0900, Krzysztof Kozlowski wrote : > Cleanup of entire driver of its dmesg output: > 1. Remove printing of the function name, because printing device name is > sufficient. This also makes the dev_err()-like functions more compact > and readable (not need of line break). > 2. Lower from info to debug printing of each RTC interrupt (no need to > make noise on each alarm). > 3. Remove dev_info() at beginning of probe because a message is already > always printed by either probe failure or from registering the RTC > device as /dev/rtcX. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > Patch rebased on top of Javier's v4: > [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support > http://www.spinics.net/lists/arm-kernel/msg477194.html > > Feel free to join with these series. > --- > drivers/rtc/rtc-max77686.c | 39 ++++++++++++++------------------------- > 1 file changed, 14 insertions(+), 25 deletions(-) > Applied, thanks.
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index da47b1d85793..5a03e1ecad83 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -271,8 +271,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, info->drv_data->map[REG_RTC_UPDATE0], data, data); if (ret < 0) - dev_err(info->dev, "%s: fail to write update reg(ret=%d, data=0x%x)\n", - __func__, ret, data); + dev_err(info->dev, "Fail to write update reg(ret=%d, data=0x%x)\n", + ret, data); else { /* Minimum delay required before RTC update. */ usleep_range(delay, delay * 2); @@ -297,7 +297,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) info->drv_data->map[REG_RTC_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to read time reg(%d)\n", __func__, ret); + dev_err(info->dev, "Fail to read time reg(%d)\n", ret); goto out; } @@ -326,8 +326,7 @@ static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) info->drv_data->map[REG_RTC_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to write time reg(%d)\n", __func__, - ret); + dev_err(info->dev, "Fail to write time reg(%d)\n", ret); goto out; } @@ -355,8 +354,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) ret = regmap_bulk_read(info->max77686->rtc_regmap, map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s:%d fail to read alarm reg(%d)\n", - __func__, __LINE__, ret); + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); goto out; } @@ -394,8 +392,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) alrm->pending = 0; ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val); if (ret < 0) { - dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n", - __func__, __LINE__, ret); + dev_err(info->dev, "Fail to read status2 reg(%d)\n", ret); goto out; } @@ -426,8 +423,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); goto out; } @@ -452,8 +448,7 @@ static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) } if (ret < 0) { - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); goto out; } @@ -481,8 +476,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) map[REG_ALARM1_SEC], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to read alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to read alarm reg(%d)\n", ret); goto out; } @@ -508,8 +502,7 @@ static int max77686_rtc_start_alarm(struct max77686_rtc_info *info) } if (ret < 0) { - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); goto out; } @@ -539,8 +532,7 @@ static int max77686_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to write alarm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write alarm reg(%d)\n", ret); goto out; } @@ -575,7 +567,7 @@ static irqreturn_t max77686_rtc_alarm_irq(int irq, void *data) { struct max77686_rtc_info *info = data; - dev_info(info->dev, "%s:irq(%d)\n", __func__, irq); + dev_dbg(info->dev, "RTC alarm IRQ: %d\n", irq); rtc_update_irq(info->rtc_dev, 1, RTC_IRQF | RTC_AF); @@ -605,8 +597,7 @@ static int max77686_rtc_init_reg(struct max77686_rtc_info *info) info->drv_data->map[REG_RTC_CONTROLM], data, ARRAY_SIZE(data)); if (ret < 0) { - dev_err(info->dev, "%s: fail to write controlm reg(%d)\n", - __func__, ret); + dev_err(info->dev, "Fail to write controlm reg(%d)\n", ret); return ret; } @@ -621,8 +612,6 @@ static int max77686_rtc_probe(struct platform_device *pdev) const struct platform_device_id *id = platform_get_device_id(pdev); int ret; - dev_info(&pdev->dev, "%s\n", __func__); - info = devm_kzalloc(&pdev->dev, sizeof(struct max77686_rtc_info), GFP_KERNEL); if (!info) @@ -662,7 +651,7 @@ static int max77686_rtc_probe(struct platform_device *pdev) if (!max77686->rtc_irq_data) { ret = -EINVAL; - dev_err(&pdev->dev, "%s: no RTC regmap IRQ chip\n", __func__); + dev_err(&pdev->dev, "No RTC regmap IRQ chip\n"); goto err_rtc; }
Cleanup of entire driver of its dmesg output: 1. Remove printing of the function name, because printing device name is sufficient. This also makes the dev_err()-like functions more compact and readable (not need of line break). 2. Lower from info to debug printing of each RTC interrupt (no need to make noise on each alarm). 3. Remove dev_info() at beginning of probe because a message is already always printed by either probe failure or from registering the RTC device as /dev/rtcX. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- Patch rebased on top of Javier's v4: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support http://www.spinics.net/lists/arm-kernel/msg477194.html Feel free to join with these series. --- drivers/rtc/rtc-max77686.c | 39 ++++++++++++++------------------------- 1 file changed, 14 insertions(+), 25 deletions(-)