From patchwork Sun Jul 26 21:48:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 500175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-wi0-x237.google.com (mail-wi0-x237.google.com [IPv6:2a00:1450:400c:c05::237]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 280A4140D57 for ; Mon, 27 Jul 2015 07:48:51 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b=E1xs1n6y; dkim-atps=neutral Received: by wicmv11 with SMTP id mv11sf27745588wic.1 for ; Sun, 26 Jul 2015 14:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20120806; h=mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :reply-to:content-type:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe; bh=EWuqWmuCGMZbwxqK9tUbgi4FMsg7B370UV9dKnQTAnM=; b=E1xs1n6ypRvn/R4M6EO87W3DT1o/xREdXRRvhUSg6QVZ5+JwMd78axes5bvc4286Xg J5XSeUUNVJcc/9NG5RMDgnfBvjl7A7drW6qLCP+MnJyS5pna+yEVv7LF/VjnUjC3Yc8y akB3MLVTxJ8qAboCWJSWyS8gbWa46/82jPjkr4aRo984kbXehDAPqM05VsF82mg9m2W7 M9sRq1mBGoZaaIyFJHordEzGxbaQlqvP/iJb45kNM9pFqkC2IyIVmoxItQecU9CEsJdH egZmYiefMR/kxd1pJ6+oLsq9G7WBzz8KuKCe+ybE/dEwmZe67omT1KD9JB+O9nS0SWcY GxUw== X-Received: by 10.152.26.132 with SMTP id l4mr354298lag.17.1437947329043; Sun, 26 Jul 2015 14:48:49 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.152.44.228 with SMTP id h4ls579603lam.23.gmail; Sun, 26 Jul 2015 14:48:48 -0700 (PDT) X-Received: by 10.112.253.135 with SMTP id aa7mr10746873lbd.11.1437947328523; Sun, 26 Jul 2015 14:48:48 -0700 (PDT) Received: from mail.mleia.com (li271-223.members.linode.com. [178.79.152.223]) by gmr-mx.google.com with ESMTPS id cj6si259423wib.1.2015.07.26.14.48.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jul 2015 14:48:48 -0700 (PDT) Received-SPF: neutral (google.com: 178.79.152.223 is neither permitted nor denied by best guess record for domain of vz@mleia.com) client-ip=178.79.152.223; Received: from mail.mleia.com (localhost [127.0.0.1]) by mail.mleia.com (Postfix) with ESMTP id 8FB26101215; Sun, 26 Jul 2015 22:54:00 +0100 (BST) Received: from localhost.localdomain (a91-152-106-128.elisa-laajakaista.fi [91.152.106.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mleia.com (Postfix) with ESMTPSA id 4D9B7101213; Sun, 26 Jul 2015 22:54:00 +0100 (BST) From: Vladimir Zapolskiy To: Alessandro Zummo , Alexandre Belloni Cc: rtc-linux@googlegroups.com, Greg Kroah-Hartman Subject: [rtc-linux] [PATCH 11/11] rtc: tx4939: clean up tx4939_rtc_nvram_read()/tx4939_rtc_nvram_write() Date: Mon, 27 Jul 2015 00:48:36 +0300 Message-Id: <1437947316-5652-12-git-send-email-vz@mleia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1437947316-5652-1-git-send-email-vz@mleia.com> References: <1437947316-5652-1-git-send-email-vz@mleia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20150726_225400_610672_B33E627B X-CRM114-Status: GOOD ( 14.94 ) X-Original-Sender: vz@mleia.com X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 178.79.152.223 is neither permitted nor denied by best guess record for domain of vz@mleia.com) smtp.mail=vz@mleia.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: rtc-linux@googlegroups.com X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy --- drivers/rtc/rtc-tx4939.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c index cb7f94e..560d9a5 100644 --- a/drivers/rtc/rtc-tx4939.c +++ b/drivers/rtc/rtc-tx4939.c @@ -199,8 +199,7 @@ static ssize_t tx4939_rtc_nvram_read(struct file *filp, struct kobject *kobj, ssize_t count; spin_lock_irq(&pdata->lock); - for (count = 0; size > 0 && pos < TX4939_RTC_REG_RAMSIZE; - count++, size--) { + for (count = 0; count < size; count++) { __raw_writel(pos++, &rtcreg->adr); *buf++ = __raw_readl(&rtcreg->dat); } @@ -218,8 +217,7 @@ static ssize_t tx4939_rtc_nvram_write(struct file *filp, struct kobject *kobj, ssize_t count; spin_lock_irq(&pdata->lock); - for (count = 0; size > 0 && pos < TX4939_RTC_REG_RAMSIZE; - count++, size--) { + for (count = 0; count < size; count++) { __raw_writel(pos++, &rtcreg->adr); __raw_writel(*buf++, &rtcreg->dat); }