From patchwork Wed Nov 18 19:45:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Matyukevich X-Patchwork-Id: 38784 Return-Path: <3RVAESwgJCeQMKUSGZYOMSGOR.IUSXZI-ROTadMUUMRKMXUaVY.IUS@listserv.bounces.google.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-gx0-f202.google.com (mail-gx0-f202.google.com [209.85.217.202]) by ozlabs.org (Postfix) with ESMTP id 8F51E1007D3 for ; Thu, 19 Nov 2009 06:51:34 +1100 (EST) Received: by gxk26 with SMTP id 26sf2016239gxk.1 for ; Wed, 18 Nov 2009 11:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:x-beenthere:received :received:received:received:received-spf:received:received:received :from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:x-thread-url:x-message-url :content-type; bh=/JgXAuEwNn09jtHPf2W/q8z7L2uHPJoycmCnTtcvVaM=; b=dJFjlUoK15K/o6cEhra3gmIWYAxjjEZs4M7gneFs7Vrc8KPEYsFGpjYIJzDGE3gtXW m5xlk1XGR8lv1pYxpR5h0R0ST84MbAkvVMBkZMMiLMXmMpKizcWLTt3bFtl8R/Slzeq2 avTRQqittLACIgpQouRQfoBJPDLxbYly5huiU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:x-beenthere:received-spf:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:list-post:list-help:list-archive:x-thread-url:x-message-url :content-type; b=SpZ91j/sBGueWCsWNiyfTHxMaw81yxVzSM2NEvG2RMfHqnaEy61d6y7CpBuU7X1PqW dkBZ9LXwiAOnzJ7KqbCfjd0TmXGtooOxJKr5A6urKqRRTI3d7K/8GjI72BY5iCjQ6Mq4 +MDBQ3La+HgthEc6gWNuOIf7IznY2Tv/OwutA= Received: by 10.91.63.35 with SMTP id q35mr276083agk.32.1258573893173; Wed, 18 Nov 2009 11:51:33 -0800 (PST) MIME-Version: 1.0 X-BeenThere: rtc-linux@googlegroups.com Received: by 10.90.40.27 with SMTP id n27ls35997agn.0.p; Wed, 18 Nov 2009 11:51:32 -0800 (PST) Received: by 10.91.72.12 with SMTP id z12mr2257375agk.1.1258573892279; Wed, 18 Nov 2009 11:51:32 -0800 (PST) Received: by 10.91.72.12 with SMTP id z12mr2257373agk.1.1258573892243; Wed, 18 Nov 2009 11:51:32 -0800 (PST) Received: from mail-yw0-f172.google.com (mail-yw0-f172.google.com [209.85.211.172]) by gmr-mx.google.com with ESMTP id 18si43996gxk.11.2009.11.18.11.51.31; Wed, 18 Nov 2009 11:51:31 -0800 (PST) Received-SPF: pass (google.com: domain of geomatsi@gmail.com designates 209.85.211.172 as permitted sender) client-ip=209.85.211.172; Received: by ywh2 with SMTP id 2so1543770ywh.27 for ; Wed, 18 Nov 2009 11:51:31 -0800 (PST) Received: by 10.213.23.156 with SMTP id r28mr510769ebb.86.1258573889195; Wed, 18 Nov 2009 11:51:29 -0800 (PST) Received: from localhost.localdomain (ppp78-37-170-87.pppoe.avangarddsl.ru [78.37.170.87]) by mx.google.com with ESMTPS id 13sm69099ewy.9.2009.11.18.11.51.28 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 18 Nov 2009 11:51:28 -0800 (PST) From: Sergey Matyukevich To: rtc-linux@googlegroups.com Cc: Alessandro Zummo , Sergey Lapin , Sergey Matyukevich Subject: [rtc-linux] [PATCH 1/3] rtc-fm3130 fix: add missing braces Date: Wed, 18 Nov 2009 22:45:07 +0300 Message-Id: <1258573509-12263-2-git-send-email-geomatsi@gmail.com> X-Mailer: git-send-email 1.6.2.5 In-Reply-To: <1258573509-12263-1-git-send-email-geomatsi@gmail.com> References: <1256408743-6644-1-git-send-email-geomatsi@gmail.com> <1258573509-12263-1-git-send-email-geomatsi@gmail.com> X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of geomatsi@gmail.com designates 209.85.211.172 as permitted sender) smtp.mail=geomatsi@gmail.com; dkim=pass (test mode) header.i=@gmail.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: X-Thread-Url: http://groups.google.com/group/rtc-linux/t/740ba9cd535b6cee X-Message-Url: http://groups.google.com/group/rtc-linux/msg/4e6f18cf0e0c528 Add missing braces for multiline 'if' statements in fm3130_probe. Signed-off-by: Sergey Matyukevich --- drivers/rtc/rtc-fm3130.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-fm3130.c b/drivers/rtc/rtc-fm3130.c index 3a7be11..812c667 100644 --- a/drivers/rtc/rtc-fm3130.c +++ b/drivers/rtc/rtc-fm3130.c @@ -376,20 +376,22 @@ static int __devinit fm3130_probe(struct i2c_client *client, } /* Disabling calibration mode */ - if (fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_CAL) + if (fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_CAL) { i2c_smbus_write_byte_data(client, FM3130_RTC_CONTROL, fm3130->regs[FM3130_RTC_CONTROL] & ~(FM3130_RTC_CONTROL_BIT_CAL)); dev_warn(&client->dev, "Disabling calibration mode!\n"); + } /* Disabling read and write modes */ if (fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_WRITE || - fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_READ) + fm3130->regs[FM3130_RTC_CONTROL] & FM3130_RTC_CONTROL_BIT_READ) { i2c_smbus_write_byte_data(client, FM3130_RTC_CONTROL, fm3130->regs[FM3130_RTC_CONTROL] & ~(FM3130_RTC_CONTROL_BIT_READ | FM3130_RTC_CONTROL_BIT_WRITE)); dev_warn(&client->dev, "Disabling READ or WRITE mode!\n"); + } /* oscillator off? turn it on, so clock can tick. */ if (fm3130->regs[FM3130_CAL_CONTROL] & FM3130_CAL_CONTROL_BIT_nOSCEN)