From patchwork Thu Jan 19 21:39:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dennis Lambe X-Patchwork-Id: 1729195 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-rtc-owner@vger.kernel.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="key not found in DNS" header.d=sparkcharge.io header.i=@sparkcharge.io header.a=rsa-sha256 header.s=google header.b=xZayoIa3; dkim-atps=neutral Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4Nyc6M5dRnz23fT for ; Fri, 20 Jan 2023 09:01:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbjASWBk (ORCPT ); Thu, 19 Jan 2023 17:01:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjASWBK (ORCPT ); Thu, 19 Jan 2023 17:01:10 -0500 Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F345C380A for ; Thu, 19 Jan 2023 13:39:29 -0800 (PST) Received: by mail-qt1-x82d.google.com with SMTP id jr19so1467560qtb.7 for ; Thu, 19 Jan 2023 13:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sparkcharge.io; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=diUS7SbW+4cNCdAZHjd5Rb9WzsMVmloUYnR4biBBhXI=; b=xZayoIa34oX8jpXw5WEG7a1XwkbdqXP7TWyTJXPzHmxAgsQgZyCK7miSfSHLuTxwQT IePLF8SK3U8Hx6tl9ole8Op4kDgozndWjmtij8TNRJqqLxJxZBwnFkAbOOhmO6vGXBX+ KnpvRquWY/6tESSK+Tk2lFB3MRz77pHkdJMHIINmXV3Xi8Em81/fRMqeaEQUnixeqDfB IggX6yHiULbL/z9Ws62zZLdVMG2pzKnHL5ACRNw7y86yfD9ekSmnlX1l5GNV2hZkj5du P1j14kebMDOU4+Wwwth2PUCBi0ZhUYYdILBwxgYz8ZRJXRkq4ZGZ72j2njvmqnlzwa/m 8Njg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=diUS7SbW+4cNCdAZHjd5Rb9WzsMVmloUYnR4biBBhXI=; b=ChuyiAmHi8Smh0QD338lZcg9jwTfiOdMVynjyKYG4snOuOjcD8CddN+P7mw2b1hrs/ DEoo78q8uS9WsvUZA/kklj0w4jYAqTOAwlD4bz1Wvt+VsSgTV6US8pE5VDtkSd4nUTZP 7/cYJ5Ko5WhZZzIaLqPryg8nzCJz166Xqbxaon1rnZsygVPefRD7a4jPYyYyTL6+fbGK JJFrbFu05zEA+05HcmyrmFd4yTMsNlT/GfZBAWe639kURY20qi728RaTX9dO9BYsFL/2 ehIX5itfcXyygV5guKU+4BvvEi9Rxex8QHspaMpirwy5vtW5YyU41jRfdu+SzQ6DDN61 Dy7w== X-Gm-Message-State: AFqh2koArDyZSPw0dITuoWLNqqv1xXMRiC0mYkAOhqie+vwBmpFpenJb abWyyn9RYOMMmmg50B2wDdcXDQ== X-Google-Smtp-Source: AMrXdXu20D+eAnx/j7BRIFAVfNKdOhXio7U6ZSQzIOr1FUFoa4y0uo3eY/M2amHQ3H0kkH8huV7Q8Q== X-Received: by 2002:ac8:66da:0:b0:3a7:e9a2:4f4a with SMTP id m26-20020ac866da000000b003a7e9a24f4amr18376043qtp.8.1674164367865; Thu, 19 Jan 2023 13:39:27 -0800 (PST) Received: from localhost.localdomain (c-66-31-16-167.hsd1.ma.comcast.net. [66.31.16.167]) by smtp.gmail.com with ESMTPSA id l13-20020a05620a28cd00b0070531c5d655sm2600676qkp.90.2023.01.19.13.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 13:39:27 -0800 (PST) From: Dennis Lambe Jr To: Alessandro Zummo , Alexandre Belloni , Krzysztof Kozlowski , Rob Herring , Atsushi Nemoto Cc: =?utf-8?q?Myl=C3=A8ne_Josserand?= , Gary Bisson , Javier Martinez Canillas , Troy Kisky , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Dennis Lambe Jr Subject: [PATCH v3 0/3] rtc: Set M41T82 & M41T83 xtal load capacitance from DT Date: Thu, 19 Jan 2023 21:39:00 +0000 Message-Id: <20230119213903.899756-1-dennis@sparkcharge.io> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org Other than adding a sign-off to one of the changelogs, this is a RESEND. Alexandre Belloni, what do you need for this before you'd want to apply it? In case it's additional reviewers, I have CC'd some more potentially-interested parties this time and updated Atsushi Nemoto's email address to one that's hopefully more current. I think the original author listed in the header for this driver, Alexander Bigga, is inaccurate. It looks to me like his name got copied over by Atsushi Nemoto when he created m41t82.c by deriving it from a similar driver. At any rate, Alexander Bigga's listed email address bounces, I didn't find a newer one for him, and he doesn't show up in the kernel commit log after 2007. I don't think he can be considered the maintainer for this driver anymore if he ever was. Changes in v3: * dt-bindings: added Krzysztof Kozlowski sign-off to changelog Changes in v2: * dt-bindings: remove accidental wakeup-sources line suggested by Krzysztof Kozlowski * spelling fixes in changelogs The m41t82 and m41t83 have an adjustable internal capacitance that defaults to 25 pF per xtal pin. This patch series adds the ability to configure it via the devicetree. Patch 1 just changes `#ifdef CONFIG_OF` to `if (IS_ENABLED(CONFIG_OF))` in m41t80_probe() so that I don't need to use __maybe_unused on my new functions and variables. Patch 2 is the dt-bindings. Patch 3 is the actual feature implementation. The desired capacitance comes from the quartz-load-femtofarads property, following the example of two other RTC ICs that have adjustable internal load capacitance, the NXP pcf85063 and pcf8523. The m41t82 and m41t83 support much finer-grained control over the capacitance than those chips, and ST calls the feature "analog calibration", but it looks to me like it's essentially the same kind of thing. My use case for this is: ST specifies not to add any additional external load capacitance[1], but the MikroElektronika RTC 9 Click board[2] has a 22 pF cap on each xtal pin[3]. The resulting combined capacitance appears to be outside of the operating range of the xtal, because when power is removed from the boards I'm testing with, the RTC reports an Oscillator-Fail flag on the next power on. I found I could work around the problem by reducing the internal load capacitance as low as it will go. References: [1] https://www.st.com/resource/en/application_note/an3060-applications-guide-for-serial-realtime-clocks-rtcs-stmicroelectronics.pdf [2] https://www.mikroe.com/rtc-9-click [3] https://download.mikroe.com/documents/add-on-boards/click/rtc-9/rtc-9-click-schematic-v100.pdf Previous versions: v1: https://lore.kernel.org/linux-rtc/20221219190915.3912384-1-dennis@sparkcharge.io/T/ Dennis Lambe Jr (3): rtc: m41t80: probe: use IS_ENABLED for CONFIG_OF dt-bindings: m41t80: add xtal load capacitance rtc: m41t80: set xtal load capacitance from DT .../devicetree/bindings/rtc/st,m41t80.yaml | 16 ++++ drivers/rtc/rtc-m41t80.c | 84 +++++++++++++++++-- 2 files changed, 92 insertions(+), 8 deletions(-)