mbox series

[v1,0/2] rtc: fix race condition between uie enable and rtc set time

Message ID 20221109064147.1836133-1-liaoyu15@huawei.com
Headers show
Series rtc: fix race condition between uie enable and rtc set time | expand

Message

Yu Liao Nov. 9, 2022, 6:41 a.m. UTC
The patch series fixes two issues in rtc_set_time caused by race
conditions:
- rtc_timer_do_work will loop for a while when setting rtc time in the
  future with uie enabled.
- RTC_UIE_OFF does not work when RTC_UIE_OFF and RTC_SET_TIME are
  running in parallel.

Patch #1 extracts lockless version from rtc_update_irq_enable, and
patch #2 addresses the race condition issue.

Changlog:

rfc -> V1:
1. fix smatch warnings reported by Dan Carpenter and kernel test robot:
	rtc_set_time() warn: inconsistent returns '&rtc->ops_lock'.

Yu Liao (2):
  rtc: add lockless rtc_update_irq_enable
  rtc: fix race condition in rtc_set_time()

 drivers/rtc/interface.c | 43 ++++++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 18 deletions(-)