From patchwork Thu Sep 14 20:42:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1834480 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=QbJUkOlf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Rmq5W2fWwz1yh0 for ; Fri, 15 Sep 2023 06:42:55 +1000 (AEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qgtAH-000364-DY; Thu, 14 Sep 2023 16:42:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgtAD-00035T-6V for qemu-ppc@nongnu.org; Thu, 14 Sep 2023 16:42:13 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qgtAB-000633-CQ for qemu-ppc@nongnu.org; Thu, 14 Sep 2023 16:42:12 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-99c93638322so310313966b.1 for ; Thu, 14 Sep 2023 13:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694724129; x=1695328929; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MUMu/RjMRNg/e06IUEJmt9iKdjw1m+hGQfjqbaKgZlE=; b=QbJUkOlfQBtKSf4UJEzmm6zPavCcgC9XhUWK8f7OyfUiJImewnWL1WkCygSrlEgkPC o5VKvy8tYT/haTxJfs5VeIbGHY/mGMcdBMP4f3yhqsiE61ap8uRyZXCaJKZ68Eh+bjC/ TIfvg9fPO96Y1TqPB+xkKiro/zJn2+ZWCAjVM/tyz+R+R2MOuxUgJFd1Xz8k4Mii3UHw BTTSH/S120aZyIOaqu53zz43b+TReh6XpnqFcmhLqinAOQJjn0vTWvkR56Yc8n3gjzb0 M406HXxv6PCOH/FeeGgnz1Oqthtu41LetcAJ7+VYVBsSDMMR4oF/7W/4yVKBUveaGyQ5 /xoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694724129; x=1695328929; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MUMu/RjMRNg/e06IUEJmt9iKdjw1m+hGQfjqbaKgZlE=; b=QyCrmYBXQar/HgWGPaPEOJqcf6lVCSkkv3sqa1qN5qFVvt2vy+pwyD8nYQHPXxn8BM W3ZHkZMGfWxgMK0VEgptpNkYnn8Rqg4YXoLonL3diQVPkuapwFQzRob/qMOqAL9yxjDE MJ1R85Tm9Hrmvfui2YfyGyXWLYf/VyHBif3kkR6t6vDaNzSU9byzFb0zMIKmUdA8Quok apKMbwxTIb0Z735iLEqFuO5eYv0qf44k1Cz43fCx2gsiAJzRS4ZMmPC2z9l/lDyJGq8h mFx8jOzPukbnXLImQsvcVhI31dajrXbmnJqCOoaLXNU1Vpx3WmeLbxcxqWToCNyLBJ/O OXJQ== X-Gm-Message-State: AOJu0YxXHzidHTGfdheG2AM6+QyPuJibnxFRtSkaxcHUr4vO4ngBGQ5R PpjvgqIuz57735Q9q+JHNNqFYQ== X-Google-Smtp-Source: AGHT+IG8AXEUJLJOqsbBEoGfVk8a54E//KT3I8GELjDecfQYFou9+U0+3oXd+C9x7FO3IyNL+rM4Dw== X-Received: by 2002:a17:906:73cc:b0:9a9:f0e6:904e with SMTP id n12-20020a17090673cc00b009a9f0e6904emr4139944ejl.16.1694724129113; Thu, 14 Sep 2023 13:42:09 -0700 (PDT) Received: from m1x-phil.lan (176-131-223-129.abo.bbox.fr. [176.131.223.129]) by smtp.gmail.com with ESMTPSA id g21-20020a170906595500b00992f2befcbcsm1477519ejr.180.2023.09.14.13.42.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Sep 2023 13:42:08 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: BALATON Zoltan , =?utf-8?q?Fran=C3=A7ois_Revol?= , Michael Ellerman , =?utf-8?q?C=C3=A9dric_Le_Goater?= , qemu-ppc@nongnu.org, Stefan Agner , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH] pc-bios/canyonlands.dts: Fix some DeviceTree warnings Date: Thu, 14 Sep 2023 22:42:05 +0200 Message-ID: <20230914204206.79351-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=philmd@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org canyonlands.dts was imported in 2018, in commit 4b387f9ee1 ("ppc: Add aCube Sam460ex board"). The file content is based on Linux file arch/powerpc/boot/dts/canyonlands.dts from commit 5edc2aae16bc. Then Linux added 2 commits on top: - 86bc917d2ac1 ("powerpc/boot/dts: Fix dtc "pciex" warnings") - eca213152a36 ("powerpc/4xx: Complete removal of MSI support") Backport the same commits in order to fix some of the following warnings which started to appear since commit 6e0dc9d2a8 ("meson: compile bundled device trees"): [7831/8926] Generating pc-bios/canyonlands.dts with a custom command pc-bios/canyonlands.dts:47.9-50.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name pc-bios/canyonlands.dts:210.13-429.5: Warning (unit_address_vs_reg): /plb/opb: node has a reg or ranges property, but no unit name pc-bios/canyonlands.dts:464.26-504.5: Warning (pci_bridge): /plb/pciex@d00000000: node name is not "pci" or "pcie" pc-bios/canyonlands.dts:506.26-546.5: Warning (pci_bridge): /plb/pciex@d20000000: node name is not "pci" or "pcie" pc-bios/canyonlands.dtb: Warning (unit_address_format): Failed prerequisite 'pci_bridge' pc-bios/canyonlands.dtb: Warning (pci_device_reg): Failed prerequisite 'pci_bridge' pc-bios/canyonlands.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' pc-bios/canyonlands.dts:268.14-289.7: Warning (avoid_unnecessary_addr_size): /plb/opb/ebc/ndfc@3,0: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Signed-off-by: Philippe Mathieu-Daudé --- pc-bios/canyonlands.dts | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/pc-bios/canyonlands.dts b/pc-bios/canyonlands.dts index 0d6ac92d0f..5db1bff6b2 100644 --- a/pc-bios/canyonlands.dts +++ b/pc-bios/canyonlands.dts @@ -461,7 +461,7 @@ interrupt-map = < 0x0 0x0 0x0 0x0 &UIC1 0x0 0x8 >; }; - PCIE0: pciex@d00000000 { + PCIE0: pcie@d00000000 { device_type = "pci"; #interrupt-cells = <1>; #size-cells = <2>; @@ -503,7 +503,7 @@ 0x0 0x0 0x0 0x4 &UIC3 0xf 0x4 /* swizzled int D */>; }; - PCIE1: pciex@d20000000 { + PCIE1: pcie@d20000000 { device_type = "pci"; #interrupt-cells = <1>; #size-cells = <2>; @@ -544,23 +544,5 @@ 0x0 0x0 0x0 0x3 &UIC3 0x12 0x4 /* swizzled int C */ 0x0 0x0 0x0 0x4 &UIC3 0x13 0x4 /* swizzled int D */>; }; - - MSI: ppc4xx-msi@C10000000 { - compatible = "amcc,ppc4xx-msi", "ppc4xx-msi"; - reg = < 0xC 0x10000000 0x100>; - sdr-base = <0x36C>; - msi-data = <0x00000000>; - msi-mask = <0x44440000>; - interrupt-count = <3>; - interrupts = <0 1 2 3>; - interrupt-parent = <&UIC3>; - #interrupt-cells = <1>; - #address-cells = <0>; - #size-cells = <0>; - interrupt-map = <0 &UIC3 0x18 1 - 1 &UIC3 0x19 1 - 2 &UIC3 0x1A 1 - 3 &UIC3 0x1B 1>; - }; }; };