| Message ID | 20211222064025.1541490-4-clg@kaod.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ppc/ppc405: Fixes | expand |
On 12/21/21 10:40 PM, Cédric Le Goater wrote: > There is no need to deactivate MMU logging at compile time. > > Signed-off-by: Cédric Le Goater<clg@kaod.org> > --- > target/ppc/mmu_common.c | 4 ++-- > target/ppc/mmu_helper.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) There's also no need to use #defines. You should just remove these and the ifdefs. r~
On Thu, 23 Dec 2021, Richard Henderson wrote: > On 12/21/21 10:40 PM, Cédric Le Goater wrote: >> There is no need to deactivate MMU logging at compile time. >> >> Signed-off-by: Cédric Le Goater<clg@kaod.org> >> --- >> target/ppc/mmu_common.c | 4 ++-- >> target/ppc/mmu_helper.c | 2 +- >> 2 files changed, 3 insertions(+), 3 deletions(-) > > There's also no need to use #defines. > You should just remove these and the ifdefs. I thought the same unless these are disabled by default for performance reasons. MMU is already quite slow, would this make it even slower? Regards, BALATON Zoltan
On 12/24/21 4:57 AM, BALATON Zoltan wrote: > On Thu, 23 Dec 2021, Richard Henderson wrote: >> On 12/21/21 10:40 PM, Cédric Le Goater wrote: >>> There is no need to deactivate MMU logging at compile time. >>> >>> Signed-off-by: Cédric Le Goater<clg@kaod.org> >>> --- >>> target/ppc/mmu_common.c | 4 ++-- >>> target/ppc/mmu_helper.c | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> There's also no need to use #defines. >> You should just remove these and the ifdefs. > > I thought the same unless these are disabled by default for performance reasons. MMU is > already quite slow, would this make it even slower? I don't believe the difference will be measurable. r~
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.c index 4e278365ca55..c0d3d32fafaa 100644 --- a/target/ppc/mmu_common.c +++ b/target/ppc/mmu_common.c @@ -34,9 +34,9 @@ #include "mmu-book3s-v3.h" #include "mmu-radix64.h" -/* #define DEBUG_MMU */ +#define DEBUG_MMU /* #define DEBUG_BATS */ -/* #define DEBUG_SOFTWARE_TLB */ +#define DEBUG_SOFTWARE_TLB /* #define DUMP_PAGE_TABLES */ /* #define FLUSH_ALL_TLBS */ diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index 2ec3d203a081..6788577f449f 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -37,7 +37,7 @@ #include "exec/cpu_ldst.h" /* #define DEBUG_BATS */ -/* #define DEBUG_SOFTWARE_TLB */ +#define DEBUG_SOFTWARE_TLB /* #define DUMP_PAGE_TABLES */ /* #define FLUSH_ALL_TLBS */
There is no need to deactivate MMU logging at compile time. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- target/ppc/mmu_common.c | 4 ++-- target/ppc/mmu_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)