[v2,00/13] misc: Remove sprintf() due to macOS deprecation

Message ID	20240411101550.99392-1-philmd@linaro.org
Headers	show Return-Path: <qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org> To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-ppc@nongnu.org, Philippe =?unknown-8bit?q?Mathieu-Daud=C3=A9?= <philmd@linaro.org> Subject: [PATCH v2 00/13] misc: Remove sprintf() due to macOS deprecation Date: Thu, 11 Apr 2024 12:15:36 +0200 Message-ID: <20240411101550.99392-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Series	misc: Remove sprintf() due to macOS deprecation \| expand [v2,00/13] misc: Remove sprintf() due to macOS deprecation [v2,01/13] ui/console-vc: Replace sprintf() by snprintf() [v2,02/13] hw/vfio/pci: Replace sprintf() by snprintf() [v2,03/13] hw/ppc/spapr: Replace sprintf() by snprintf() [v2,04/13] hw/mips/malta: Add re-usable rng_seed_hex_new() method [v2,05/13] hw/mips/malta: Replace sprintf() by snprintf() [v2,06/13] system/qtest: Replace sprintf() by g_string_append_printf() [v2,07/13] util/hexdump: Rename @offset argument in qemu_hexdump_line() [v2,08/13] util/hexdump: Have qemu_hexdump_line() return heap allocated buffer [v2,09/13] util/hexdump: Replace sprintf() by g_string_append_printf() [v2,10/13] hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf() [v2,11/13] hw/ide/atapi: Use qemu_hexdump_line() to avoid sprintf() [v2,12/13] hw/dma/pl330: Use qemu_hexdump_line() to avoid sprintf() [v2,13/13] backends/tpm: Use qemu_hexdump_line() to avoid sprintf()

Message ID

20240411101550.99392-1-philmd@linaro.org

Headers

From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-ppc@nongnu.org, Philippe
	=?unknown-8bit?q?Mathieu-Daud=C3=A9?= <philmd@linaro.org>
Subject: [PATCH v2 00/13] misc: Remove sprintf() due to macOS deprecation
Date: Thu, 11 Apr 2024 12:15:36 +0200
Message-ID: <20240411101550.99392-1-philmd@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::334;
 envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-ppc@nongnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <qemu-ppc.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-ppc>,
 <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-ppc>
List-Post: <mailto:qemu-ppc@nongnu.org>
List-Help: <mailto:qemu-ppc-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,
 <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>
Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org

Series

misc: Remove sprintf() due to macOS deprecation | expand

Message

Philippe Mathieu-Daudé April 11, 2024, 10:15 a.m. UTC

Since v1:
- Use snprintf() in patches 1-5

Hi,

sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
resulting in painful developper experience.

Suggestion to avoid the super-noisy warning on macOS forum are [*]:

* use -Wno-deprecated-declarations on the whole build
* surgically add #pragma clang diagnostic around each use.

None of these options seem reasonable, so we are somehow forced to
spend time converting each sprintf() call, even if they are safe
enough.

I'm so tired of seeing them than I started the conversion. This is
the first part. Help for the rest is welcomed.

Regards,

Phil.

[*] https://forums.developer.apple.com/forums/thread/714675

Philippe Mathieu-Daudé (13):
  ui/console-vc: Replace sprintf() by snprintf()
  hw/vfio/pci: Replace sprintf() by snprintf()
  hw/ppc/spapr: Replace sprintf() by snprintf()
  hw/mips/malta: Add re-usable rng_seed_hex_new() method
  hw/mips/malta: Replace sprintf() by snprintf()
  system/qtest: Replace sprintf() by g_string_append_printf()
  util/hexdump: Rename @offset argument in qemu_hexdump_line()
  util/hexdump: Have qemu_hexdump_line() return heap allocated buffer
  util/hexdump: Replace sprintf() by g_string_append_printf()
  hw/scsi/scsi-disk: Use qemu_hexdump_line() to avoid sprintf()
  hw/ide/atapi: Use qemu_hexdump_line() to avoid sprintf()
  hw/dma/pl330: Use qemu_hexdump_line() to avoid sprintf()
  backends/tpm: Use qemu_hexdump_line() to avoid sprintf()

 include/qemu/cutils.h   | 17 ++++++++++++++---
 backends/tpm/tpm_util.c | 24 ++++++++----------------
 hw/dma/pl330.c          | 12 +++---------
 hw/ide/atapi.c          |  8 ++------
 hw/mips/malta.c         | 23 ++++++++++++++---------
 hw/ppc/spapr.c          |  2 +-
 hw/scsi/scsi-disk.c     |  8 ++------
 hw/vfio/pci.c           |  2 +-
 hw/virtio/vhost-vdpa.c  | 11 ++++++-----
 system/qtest.c          |  8 +++-----
 ui/console-vc.c         |  2 +-
 util/hexdump.c          | 33 ++++++++++++++++++---------------
 12 files changed, 73 insertions(+), 77 deletions(-)