| Message ID | 20240111164652.908182-1-thuth@redhat.com |
|---|---|
| Headers | show |
| Series | ppc: Rename power5+ and power7+ for the new QOM naming rules | expand |
On Thu, Jan 11, 2024 at 17:46:50 +0100, Thomas Huth wrote: > We can get rid of the "power5+" / "power7+" hack in qom/object.c > by using CPU aliases for those names instead (first patch). > > I think in the long run, we should get rid of the names with a "+" > in it completely, so the second patch suggests to deprecate those, > but I'd also be fine if we keep the aliases around, so in that case > please ignore the second patch. > > Thomas Huth (2): > target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming > rules > docs/about: Deprecate the old "power5+" and "power7+" CPU names libvirt seems to be explicitly referencing power7+ in the code, so I guess we'll need code to translate the + versions to the spellt-out version to preserve compatibility.
On 12/01/2024 13.48, Peter Krempa wrote: > On Thu, Jan 11, 2024 at 17:46:50 +0100, Thomas Huth wrote: >> We can get rid of the "power5+" / "power7+" hack in qom/object.c >> by using CPU aliases for those names instead (first patch). >> >> I think in the long run, we should get rid of the names with a "+" >> in it completely, so the second patch suggests to deprecate those, >> but I'd also be fine if we keep the aliases around, so in that case >> please ignore the second patch. >> >> Thomas Huth (2): >> target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming >> rules >> docs/about: Deprecate the old "power5+" and "power7+" CPU names > > libvirt seems to be explicitly referencing power7+ in the code, so I > guess we'll need code to translate the + versions to the spellt-out > version to preserve compatibility. If it's too cumbersome, we could also keep the alias enabled in QEMU, i.e. drop the second patch...? Thomas
We can get rid of the "power5+" / "power7+" hack in qom/object.c by using CPU aliases for those names instead (first patch). I think in the long run, we should get rid of the names with a "+" in it completely, so the second patch suggests to deprecate those, but I'd also be fine if we keep the aliases around, so in that case please ignore the second patch. Thomas Huth (2): target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules docs/about: Deprecate the old "power5+" and "power7+" CPU names docs/about/deprecated.rst | 9 +++++++++ hw/ppc/spapr_cpu_core.c | 4 ++-- qom/object.c | 4 ---- target/ppc/cpu-models.c | 10 ++++++---- 4 files changed, 17 insertions(+), 10 deletions(-)