From patchwork Mon Oct 25 19:11:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Fernando Fujita Pires X-Patchwork-Id: 1545896 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HdPmp46b4z9sfG for ; Tue, 26 Oct 2021 06:15:37 +1100 (AEDT) Received: from localhost ([::1]:40554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mf5RV-00024e-O9 for incoming@patchwork.ozlabs.org; Mon, 25 Oct 2021 15:15:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mf5OP-00060W-7N; Mon, 25 Oct 2021 15:12:21 -0400 Received: from [201.28.113.2] (port=19851 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mf5OK-0005n6-Ed; Mon, 25 Oct 2021 15:12:20 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Mon, 25 Oct 2021 16:12:11 -0300 Received: from eldorado.org.br (unknown [10.10.70.45]) by power9a (Postfix) with ESMTP id 119B6800145; Mon, 25 Oct 2021 16:12:11 -0300 (-03) From: Luis Pires To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Subject: [PATCH v4 00/19] target/ppc: DFP instructions using decodetree Date: Mon, 25 Oct 2021 16:11:35 -0300 Message-Id: <20211025191154.350831-1-luis.pires@eldorado.org.br> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-OriginalArrivalTime: 25 Oct 2021 19:12:11.0389 (UTC) FILETIME=[366A12D0:01D7C9D4] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=luis.pires@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, PDS_HP_HELO_NORDNS=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Luis Pires , richard.henderson@linaro.org, groug@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-ppc" This series moves all existing DFP instructions to decodetree and implements the 2 new instructions (dcffixqq and dctfixqq) from Power ISA 3.1. In order to implement dcffixqq, divu128/divs128 were modified to support 128-bit quotients (previously, they were limited to 64-bit quotients), along with adjustments being made to their existing callers. libdecnumber was also expanded to allow creating decimal numbers from 128-bit integers. Similarly, for dctfixqq, mulu128 (host-utils) and decNumberIntegralToInt128 (libdecnumber) were introduced to support 128-bit integers. The remaining patches of this series move all of the already existing DFP instructions to decodetree, and end up removing dfp-ops.c.inc, which is no longer needed. NOTE 1: The previous, non-decodetree code, was updating ctx->nip for all the DFP instructions. I've removed that, but it would be great if someone could confirm that updating nip really wasn't necessary. NOTE 2: Some arithmetic function support for 128-bit integers was added, for now, still using 64-bit pairs. In the near future, I think we should modify all of them to use Int128 (and introduce UInt128). But I'll send out an RFC to discuss how to do that in another patch series. NOTE 3: The helper names are in uppercase, to match the instruction names and to simplify the macros that define trans* functions. Previously, this wasn't the case, as we were using lowercase instruction names in the pre-decodetree code. Another standalone patch will be sent later on, changing to uppercase the other new (decodetree) helpers whose names are directly related to instruction names, eventually making PPC helper names consistent. The only patch still needing review is: [PATCH v4 12/19] target/ppc: Do not update nip on DFP instructions Changes in v4: - Rebased against dgibson/ppc-for-6.2 - Skipped patches that were already applied (v3 1-4) - Changed divu128/divs128 to return the remainder (rth) - Moved changes that drop nip updates to a separate patch (rth) Changes in v3: - Split the uabs64 patch in 2 - Included patch to fix missing zero-extension in divs128 - Folded divisor == 0 into the dhi == 0 case in divu128 - Moved udiv_qrnnd from softfloat-macros.h to host-utils.h - Used udiv_qrnnd in divu128 - Replaced int with bool in divs128 - Added unit test to check the divisor normalization in divu128 - Removed 'inline' from times_* functions in ppc/translate.c - Used uadd64_overflow in mulu128 - Removed unnecessary 'else' from decNumberIntegralToInt128 Changes in v2: - Renamed abs64() to uabs64() Bruno Larsen (1): target/ppc: Move REQUIRE_ALTIVEC/VECTOR to translate.c Fernando Valle (1): target/ppc: Introduce REQUIRE_FPU Luis Pires (17): host-utils: move checks out of divu128/divs128 host-utils: move udiv_qrnnd() to host-utils host-utils: add 128-bit quotient support to divu128/divs128 host-utils: add unit tests for divu128/divs128 libdecnumber: introduce decNumberFrom[U]Int128 target/ppc: Implement DCFFIXQQ host-utils: Introduce mulu128 libdecnumber: Introduce decNumberIntegralToInt128 target/ppc: Implement DCTFIXQQ target/ppc: Do not update nip on DFP instructions target/ppc: Move dtstdc[q]/dtstdg[q] to decodetree target/ppc: Move d{add,sub,mul,div,iex}[q] to decodetree target/ppc: Move dcmp{u,o}[q],dts{tex,tsf,tsfi}[q] to decodetree target/ppc: Move dquai[q], drint{x,n}[q] to decodetree target/ppc: Move dqua[q], drrnd[q] to decodetree target/ppc: Move dct{dp,qpq},dr{sp,dpq},dc{f,t}fix[q],dxex[q] to decodetree target/ppc: Move ddedpd[q],denbcd[q],dscli[q],dscri[q] to decodetree include/fpu/softfloat-macros.h | 82 ----- include/hw/clock.h | 5 +- include/libdecnumber/decNumber.h | 4 + include/libdecnumber/decNumberLocal.h | 2 +- include/qemu/host-utils.h | 157 +++++++-- libdecnumber/decContext.c | 7 +- libdecnumber/decNumber.c | 131 ++++++++ target/ppc/dfp_helper.c | 168 +++++++--- target/ppc/helper.h | 106 ++++--- target/ppc/insn32.decode | 171 ++++++++++ target/ppc/int_helper.c | 23 +- target/ppc/translate.c | 23 +- target/ppc/translate/dfp-impl.c.inc | 419 ++++++++++++------------- target/ppc/translate/dfp-ops.c.inc | 165 ---------- target/ppc/translate/vector-impl.c.inc | 10 +- tests/unit/meson.build | 1 + tests/unit/test-div128.c | 197 ++++++++++++ util/host-utils.c | 137 +++++--- 18 files changed, 1148 insertions(+), 660 deletions(-) delete mode 100644 target/ppc/translate/dfp-ops.c.inc create mode 100644 tests/unit/test-div128.c