| Message ID | cover.1693228686.git.yong.huang@smartx.com |
|---|---|
| State | New |
| Headers | show |
On Mon, 28 Aug 2023 at 10:36, Hyman Huang <yong.huang@smartx.com> wrote: > > From: Hyman <yong.huang@smartx.com> > > The following changes since commit 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > > Merge tag 'pull-target-arm-20230824' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 10:08:33 -0400) > > are available in the git repository at: > > https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-fixes-pull-request Hi, This is not a signed tag. Please use "git tag -s" so the tag is signed with your GPG key. I also noticed that this pull request email thread only has a cover letter. Please also send the individual patches along with the pull request email. This makes it easier for people to reply if they have comments about a patch. After pushing a signed tag, please send the pull request again with "PULL v2" in the subject line. Thanks! Thanks, Stefan > > for you to fetch changes up to e424d9f7e749c84de4a6ce532981271db1c14b23: > > migration/dirtyrate: Fix precision losses and g_usleep overshoot (2023-08-28 21:03:58 +0800) > > ---------------------------------------------------------------- > Dirty page limit and dirty page rate PULL request > > Hi, this is the fix for dirty page limit and dirty page rate. > > Please apply. > > Thanks, Yong. > ---------------------------------------------------------------- > Andrei Gudkov (1): > migration/dirtyrate: Fix precision losses and g_usleep overshoot > > alloc.young (2): > softmmu: Fix dirtylimit memory leak > softmmu/dirtylimit: Convert free to g_free > > migration/dirtyrate.c | 10 ++++++++-- > softmmu/dirtylimit.c | 26 ++++++++++++-------------- > 2 files changed, 20 insertions(+), 16 deletions(-) > > -- > 1.8.3.1 > >
I see you sent a second pull request that includes the emails. Please send a v3 with a signed tag. Thanks! Stefan
On Tue, Aug 29, 2023 at 4:01 AM Stefan Hajnoczi <stefanha@gmail.com> wrote: > On Mon, 28 Aug 2023 at 10:36, Hyman Huang <yong.huang@smartx.com> wrote: > > > > From: Hyman <yong.huang@smartx.com> > > > > The following changes since commit > 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > > > > Merge tag 'pull-target-arm-20230824' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 > 10:08:33 -0400) > > > > are available in the git repository at: > > > > https://github.com/newfriday/qemu.git > tags/dirtylimit-dirtyrate-fixes-pull-request > > Hi, > This is not a signed tag. Please use "git tag -s" so the tag is signed > with your GPG key. > > I also noticed that this pull request email thread only has a cover > letter. Please also send the individual patches along with the pull > request email. This makes it easier for people to reply if they have > comments about a patch. > > After pushing a signed tag, please send the pull request again with > "PULL v2" in the subject line. Thanks! > Sorry for not noticing this earlier and I have sent a pull request with "PULL" in the subject line instead of "PULL v3" that you mentioned above, please ping me if PULL request resending is required indeed. Yong > Thanks, > Stefan > > > > > for you to fetch changes up to e424d9f7e749c84de4a6ce532981271db1c14b23: > > > > migration/dirtyrate: Fix precision losses and g_usleep overshoot > (2023-08-28 21:03:58 +0800) > > > > ---------------------------------------------------------------- > > Dirty page limit and dirty page rate PULL request > > > > Hi, this is the fix for dirty page limit and dirty page rate. > > > > Please apply. > > > > Thanks, Yong. > > ---------------------------------------------------------------- > > Andrei Gudkov (1): > > migration/dirtyrate: Fix precision losses and g_usleep overshoot > > > > alloc.young (2): > > softmmu: Fix dirtylimit memory leak > > softmmu/dirtylimit: Convert free to g_free > > > > migration/dirtyrate.c | 10 ++++++++-- > > softmmu/dirtylimit.c | 26 ++++++++++++-------------- > > 2 files changed, 20 insertions(+), 16 deletions(-) > > > > -- > > 1.8.3.1 > > > > >
On Tue, 29 Aug 2023 at 12:30, Yong Huang <yong.huang@smartx.com> wrote: > On Tue, Aug 29, 2023 at 4:01 AM Stefan Hajnoczi <stefanha@gmail.com> wrote: >> >> On Mon, 28 Aug 2023 at 10:36, Hyman Huang <yong.huang@smartx.com> wrote: >> > >> > From: Hyman <yong.huang@smartx.com> >> > >> > The following changes since commit 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: >> > >> > Merge tag 'pull-target-arm-20230824' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 10:08:33 -0400) >> > >> > are available in the git repository at: >> > >> > https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-fixes-pull-request >> >> Hi, >> This is not a signed tag. Please use "git tag -s" so the tag is signed >> with your GPG key. >> >> I also noticed that this pull request email thread only has a cover >> letter. Please also send the individual patches along with the pull >> request email. This makes it easier for people to reply if they have >> comments about a patch. >> >> After pushing a signed tag, please send the pull request again with >> "PULL v2" in the subject line. Thanks! > > > Sorry for not noticing this earlier and I have sent a pull request with "PULL" > in the subject line instead of "PULL v3" that you mentioned above, please > ping me if PULL request resending is required indeed. I have applied the pull request. To make it easier to verify future pull requests, please publish your public key to a keyserver: $ gpg --send-keys DFF223D6B3FECB9C Thanks! Stefan
On Wed, Aug 30, 2023 at 1:31 AM Stefan Hajnoczi <stefanha@gmail.com> wrote: > On Tue, 29 Aug 2023 at 12:30, Yong Huang <yong.huang@smartx.com> wrote: > > On Tue, Aug 29, 2023 at 4:01 AM Stefan Hajnoczi <stefanha@gmail.com> > wrote: > >> > >> On Mon, 28 Aug 2023 at 10:36, Hyman Huang <yong.huang@smartx.com> > wrote: > >> > > >> > From: Hyman <yong.huang@smartx.com> > >> > > >> > The following changes since commit > 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > >> > > >> > Merge tag 'pull-target-arm-20230824' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 > 10:08:33 -0400) > >> > > >> > are available in the git repository at: > >> > > >> > https://github.com/newfriday/qemu.git > tags/dirtylimit-dirtyrate-fixes-pull-request > >> > >> Hi, > >> This is not a signed tag. Please use "git tag -s" so the tag is signed > >> with your GPG key. > >> > >> I also noticed that this pull request email thread only has a cover > >> letter. Please also send the individual patches along with the pull > >> request email. This makes it easier for people to reply if they have > >> comments about a patch. > >> > >> After pushing a signed tag, please send the pull request again with > >> "PULL v2" in the subject line. Thanks! > > > > > > Sorry for not noticing this earlier and I have sent a pull request with > "PULL" > > in the subject line instead of "PULL v3" that you mentioned above, please > > ping me if PULL request resending is required indeed. > > I have applied the pull request. To make it easier to verify future > pull requests, please publish your public key to a keyserver: > > $ gpg --send-keys DFF223D6B3FECB9C > Ok, get it. Thanks. Yong > > Thanks! > > Stefan >
From: Hyman <yong.huang@smartx.com> The following changes since commit 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: Merge tag 'pull-target-arm-20230824' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 10:08:33 -0400) are available in the git repository at: https://github.com/newfriday/qemu.git tags/dirtylimit-dirtyrate-fixes-pull-request for you to fetch changes up to e424d9f7e749c84de4a6ce532981271db1c14b23: migration/dirtyrate: Fix precision losses and g_usleep overshoot (2023-08-28 21:03:58 +0800) ---------------------------------------------------------------- Dirty page limit and dirty page rate PULL request Hi, this is the fix for dirty page limit and dirty page rate. Please apply. Thanks, Yong. ---------------------------------------------------------------- Andrei Gudkov (1): migration/dirtyrate: Fix precision losses and g_usleep overshoot alloc.young (2): softmmu: Fix dirtylimit memory leak softmmu/dirtylimit: Convert free to g_free migration/dirtyrate.c | 10 ++++++++-- softmmu/dirtylimit.c | 26 ++++++++++++-------------- 2 files changed, 20 insertions(+), 16 deletions(-)