From patchwork Wed Apr 19 23:02:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 752561 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w7cwb3xPTz9s3s for ; Thu, 20 Apr 2017 09:02:54 +1000 (AEST) Received: from localhost ([::1]:50881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0yca-0005Xb-Th for incoming@patchwork.ozlabs.org; Wed, 19 Apr 2017 19:02:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0ycI-0005XV-MH for qemu-devel@nongnu.org; Wed, 19 Apr 2017 19:02:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0ycE-0003Wd-B8 for qemu-devel@nongnu.org; Wed, 19 Apr 2017 19:02:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:46032) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0ycE-0003WH-3D for qemu-devel@nongnu.org; Wed, 19 Apr 2017 19:02:26 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5A3DA20154; Wed, 19 Apr 2017 23:02:23 +0000 (UTC) Received: from [10.149.184.130] (unknown [99.165.194.18]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7D9520149; Wed, 19 Apr 2017 23:02:21 +0000 (UTC) Date: Wed, 19 Apr 2017 16:02:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-X260 To: Paul Durrant In-Reply-To: <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> Message-ID: References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 198.145.29.136 Subject: Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "jgross@suse.com" , 'Stefano Stabellini' , Wei Liu , "qemu-devel@nongnu.org" , "julien.grall@arm.com" , Anthony Perard , "xen-devel@lists.xenproject.org" Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On Wed, 19 Apr 2017, Paul Durrant wrote: > > -----Original Message----- > > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > > Sent: 18 April 2017 18:41 > > To: Paul Durrant > > Cc: 'Stefano Stabellini' ; qemu-devel@nongnu.org; > > Anthony Perard ; Wei Liu > > ; jgross@suse.com; julien.grall@arm.com; xen- > > devel@lists.xenproject.org > > Subject: RE: QEMU build breakage on ARM against Xen 4.9 caused by > > libxendevicemodel > > > > On Tue, 18 Apr 2017, Paul Durrant wrote: > > > > -----Original Message----- > > > > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > > > > Sent: 15 April 2017 01:40 > > > > To: Stefano Stabellini > > > > Cc: Paul Durrant ; qemu-devel@nongnu.org; > > > > Anthony Perard ; Wei Liu > > > > ; jgross@suse.com; julien.grall@arm.com; xen- > > > > devel@lists.xenproject.org > > > > Subject: Re: QEMU build breakage on ARM against Xen 4.9 caused by > > > > libxendevicemodel > > > > > > > > On Fri, 14 Apr 2017, Stefano Stabellini wrote: > > > > > Hi Paul, > > > > > > > > > > The following commit in my qemu "next" branch breaks the build on > > arm > > > > > and arm64: > > > > > > > > > > commit 670271647ad15e9d937ced7a72c892349c709216 > > > > > Author: Paul Durrant > > > > > Date: Tue Mar 7 10:55:34 2017 +0000 > > > > > > > > > > xen: use libxendevicemodel when available > > > > > > > > > > See the appended build log. Sorry for not realizing it sooner. > > > > > > > > As I imagined, this bug is easy to solve. It is reproducible on x86 too, > > > > if you pass -DXC_WANT_COMPAT_DEVICEMODEL_API=1 to configure > > and > > > > forcefully disable Xen 4.9 detection in the configure script. > > > > > > > > If QEMU detects xen_ctrl_version = 480, the build will fail against Xen > > > > 4.9, even when -DXC_WANT_COMPAT_DEVICEMODEL_API=1 is > > specified. > > > > > > > > The appended patch solves the problem. However, Xen 4.9 detection > > and > > > > compilation remain broken. > > > > > > Ok, that fix looks fine to me. > > > > I merged this change into "use libxendevicemodel when available" in my > > next branch. > > > > Are you going to take care of getting the QEMU build on ARM to work > > against Xen 4.9 (properly detecting 4.9, without > > -DXC_WANT_COMPAT_DEVICEMODEL_API=1)? > > > > I can take a look once I get access to some h/w. Since the 4.9 detection should merely be based upon the presence of libxendevicemodel, I can't really imagine why ARM should behave any differently to x86. I managed to find the time to do some debugging. You are right that is not anything major. The bug is due to a missing -lxencall in the QEMU configure script, I wonder why it works on x86. diff --git a/configure b/configure index 99d6cbc..363a126 100755 --- a/configure +++ b/configure @@ -2027,9 +2027,9 @@ int main(void) { return 0; } EOF - compile_prog "" "$xen_libs $xen_stable_libs -lxendevicemodel" + compile_prog "" "$xen_libs $xen_stable_libs -lxendevicemodel -lxencall" then - xen_stable_libs="$xen_stable_libs -lxendevicemodel" + xen_stable_libs="$xen_stable_libs -lxendevicemodel -lxencall" xen_ctrl_version=40900 xen=yes elif