From patchwork Fri Mar 3 15:55:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Programmingkid X-Patchwork-Id: 735158 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vZYgB1M1Dz9s0Z for ; Sat, 4 Mar 2017 02:55:34 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="uQa4fh1F"; dkim-atps=neutral Received: from localhost ([::1]:58743 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpYJ-0006wP-MX for incoming@patchwork.ozlabs.org; Fri, 03 Mar 2017 10:55:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpXy-0006u7-8V for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:55:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjpXu-0004sV-CJ for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:55:10 -0500 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]:35585) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjpXu-0004sM-7j for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:55:06 -0500 Received: by mail-it0-x243.google.com with SMTP id 203so2726626ith.2 for ; Fri, 03 Mar 2017 07:55:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=in-reply-to:references:mime-version:message-id:cc :content-transfer-encoding:from:subject:date:to; bh=ctMXpGi0hLDq/MIBTdMNFNSZ5VYVVuuiY0Tto2bHBlg=; b=uQa4fh1FdYxTu7Rxr3IikVO8r6g4ArmdTNUU1RY0dc5GV9JMPEb9ybCJpLvB/sBa6K aPgrjh98Ot2GejuRh3JECjcKJRivabF90la+/TMTgWyVNnrmXLcyffAf4aDxCsP00IxE OAZLTXSxkHsi0WEaeDUGmf6CxfJwX83iF8Y9gcM8V5j5l0CtkRpfa7zNQ7bV0ffyAYGa tk7sWGeC5vg2ibrGPYLqxPJLoQMNLFk/qTuTG1C/0WLGocGQ8K85TsfohMsjbOiuId4j ELjmO4U3qeiuxVN6Xj5tmkc4BugaCs+Sdsla2UoNxJ+XMnf7mkhNM60W+i4ymjfYeiKd aS5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:in-reply-to:references:mime-version:message-id :cc:content-transfer-encoding:from:subject:date:to; bh=ctMXpGi0hLDq/MIBTdMNFNSZ5VYVVuuiY0Tto2bHBlg=; b=PKGyMStGks8nmgLUvcLPN/C+ban9w61d59ZmGog9MA2r5mNNZPcpls2dlpp2ia4CNZ iDxGxlzfSE3wqjja8HzwcmFj/p0oYk82DuKKfIoVNtzYr/kLXFNs9Z9kazhRztvfmWQU HXsI7OWXrT3CpdVpvlAyi5NittiK90v3W0TKvj+0uAI3TT1gD5pkzTqVGbTf6v8LoOxr 8vwvDuNDX7x6PKPkgdUd2GoXx+IG20vwz+6a4vibytQf/ke/QLNH1mdUZeh+37MPKqhT u5Bh2BpsBvJtWaZb1Mpbnvc+FRsJWBiv6WOyQpG4KDPshSUvRohfMD07+69/mNe6GKHC i0SA== X-Gm-Message-State: AMke39mivoX+7T18rTm7C5iiocTtWjLxSt/Og7fW9syPfUenAd8YoyUqPEUVFA7yV6vsVw== X-Received: by 10.36.178.12 with SMTP id u12mr3186013ite.109.1488556505323; Fri, 03 Mar 2017 07:55:05 -0800 (PST) Received: from [192.168.0.4] (d199-74-164-53.col.wideopenwest.com. [74.199.53.164]) by smtp.gmail.com with ESMTPSA id a129sm4760807ioe.15.2017.03.03.07.55.04 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 03 Mar 2017 07:55:04 -0800 (PST) In-Reply-To: <20170303164426.42472535@bahia.lan> References: <8FB6923C-8F97-497C-95DC-6F2D937725BC@gmail.com> <20170303164426.42472535@bahia.lan> Mime-Version: 1.0 (Apple Message framework v753.1) Message-Id: From: G 3 Date: Fri, 3 Mar 2017 10:55:01 -0500 To: Greg Kurz X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c0b::243 Subject: Re: [Qemu-devel] git master build failure in 9pfs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland , qemu-devel qemu-devel Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" On Mar 3, 2017, at 10:44 AM, Greg Kurz wrote: > On Fri, 3 Mar 2017 10:28:00 -0500 > G 3 wrote: > >> On Mar 3, 2017, at 9:59 AM, qemu-devel-request@nongnu.org wrote: >>> On 02/03/17 17:40, Daniel P. Berrange wrote: >>> >>>> On Thu, Mar 02, 2017 at 05:28:24PM +0000, Mark Cave-Ayland wrote: >>>>> Does anyone else see the following error when trying to build git >>>>> master? >>>>> >>>>> cc -I/home/build/src/qemu/git/qemu/hw/9pfs -Ihw/9pfs >>>>> -I/home/build/src/qemu/git/qemu/tcg >>>>> -I/home/build/src/qemu/git/qemu/tcg/i386 >>>>> -I/home/build/src/qemu/git/qemu/linux-headers >>>>> -I/home/build/src/qemu/git/qemu/linux-headers -I. >>>>> -I/home/build/src/qemu/git/qemu -I/home/build/src/qemu/git/qemu/ >>>>> include >>>>> -I/usr/include/pixman-1 -I/home/build/src/qemu/git/qemu/dtc/ >>>>> libfdt >>>>> -Werror -pthread -I/usr/include/glib-2.0 >>>>> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -mcx16 - >>>>> D_GNU_SOURCE >>>>> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes >>>>> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing- >>>>> prototypes >>>>> -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels >>>>> -Wno-missing-include-dirs -Wempty-body -Wnested-externs >>>>> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers >>>>> -Wold-style-declaration -Wold-style-definition -Wtype-limits >>>>> -fstack-protector-all -I/usr/include/p11-kit-1 >>>>> -I/usr/include/libpng12 -I/home/build/src/qemu/git/qemu/tests - >>>>> MMD -MP >>>>> -MT hw/9pfs/9p-util.o -MF hw/9pfs/9p-util.d -O2 -U_FORTIFY_SOURCE >>>>> -D_FORTIFY_SOURCE=2 -g -c -o hw/9pfs/9p-util.o hw/9pfs/9p-util.c >>>>> In file included from hw/9pfs/9p-util.c:15:0: >>>>> hw/9pfs/9p-util.h: In function ?openat_dir?: >>>>> hw/9pfs/9p-util.h:25:57: error: ?O_PATH? undeclared (first use in >>>>> this >>>>> function) >>>>> hw/9pfs/9p-util.h:25:57: note: each undeclared identifier is >>>>> reported >>>>> only once for each function it appears in >>>>> hw/9pfs/9p-util.h:26:1: error: control reaches end of non-void >>>>> function >>>>> [-Werror=return-type] >>>>> >>>>> Build platform is Debian Wheezy on an x86_64 host. >>>> >>>> IIUC, O_PATH was introduced in glibc 2.14 and Wheezy only has 2.13. >>>> >>>> So unless we want to make this 9pfs code a configurable option, >>>> this >>>> means Debian Wheezy is no longer a supportable platform for QEMU. >>> >>> Oh sure, I appreciate that wheezy is getting towards then end of its >>> lifetime - it's just a little bit inconvenient to break my >>> development >>> environment just as we enter 2.9 freeze ;) >>> >>> If everyone agrees that wheezy is no longer supported after 2.9 >>> then I >>> can look to upgrading, however my QEMU development is done on my >>> laptop >>> which is also setup for my day job so it's not a simple case of just >>> switching the repository and running dist-upgrade to get me going >>> again... >> >> I remember years ago something like O_PATH was not defined on Mac >> OS X, >> so the solution was to define the constant as zero. Something like >> this: >> >> #ifndef O_PATH >> #define O_PATH 0 >> #endif >> >> Maybe this might work in 9p-util.h. >> > > Yes. Please send a patch and I'll merge it. > > Cheers. > > -- > Greg Here is the patch. I think we should let Mark or some else test it to see if it does fix the problem before a real patch is submitted. --- hw/9pfs/9p-util.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h index 091f3ce..254d2a9 100644 --- a/hw/9pfs/9p-util.h +++ b/hw/9pfs/9p-util.h @@ -13,6 +13,10 @@ #ifndef QEMU_9P_UTIL_H #define QEMU_9P_UTIL_H +#ifndef O_PATH + #define O_PATH 0 +#endif + static inline void close_preserve_errno(int fd) { int serrno = errno;