From patchwork Tue Sep 22 23:32:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Programmingkid X-Patchwork-Id: 521482 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 67239140783 for ; Wed, 23 Sep 2015 09:32:25 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=GDiI7r8I; dkim-atps=neutral Received: from localhost ([::1]:43754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeX2t-0002DU-DQ for incoming@patchwork.ozlabs.org; Tue, 22 Sep 2015 19:32:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeX2e-0001v2-0L for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:32:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeX2a-00011e-Qp for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:32:07 -0400 Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]:33355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeX2a-00011V-N4 for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:32:04 -0400 Received: by vkgd64 with SMTP id d64so17235110vkg.0 for ; Tue, 22 Sep 2015 16:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:date:message-id :cc:to:mime-version; bh=9R2pduBy8yYpTUfPUQiBKxcdKXbqjAUBCKLuugfwQp4=; b=GDiI7r8I/1g3UQV1CWLdDqBE4AP1WCPOj0Wg61YmOrkZYBtelRKQSeBUPV2dSbUzsC sx8ftZT5kuLTWqml10uTTXv/PBmlVKw1jKeKOhEI2XmO6RfBz+ocUsLbfY2WlF4fzhbq nZuPCS78kwGttCGJ6H6LGVb7Vt1yiuce7SMR+NDpNwEiyiAgdHPftmrY0xykTC/O+wwz 9BrFz0WVn3V0cRoGiKFyXNlE5uKfHkACZfzWRZIo/3zdFNEFKyLReLOB5GHPoy0jrALE yeSHMGro5OmwyJQ9l4pXKtXXRiiUoHudT4bCK8t4YPJHmttS05ltdUcCuZX5voJjD78V uaPQ== X-Received: by 10.31.3.133 with SMTP id f5mr18003820vki.91.1442964723761; Tue, 22 Sep 2015 16:32:03 -0700 (PDT) Received: from [192.168.0.3] (d199-74-164-53.col.wideopenwest.com. [74.199.53.164]) by smtp.gmail.com with ESMTPSA id h125sm497010vke.23.2015.09.22.16.32.02 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 22 Sep 2015 16:32:02 -0700 (PDT) From: Programmingkid Date: Tue, 22 Sep 2015 19:32:01 -0400 Message-Id: <8AEDA8BB-5138-47AF-98B7-D8E5BCE0E1FB@gmail.com> To: qemu-devel qemu-devel Mime-Version: 1.0 (Apple Message framework v1084) X-Mailer: Apple Mail (2.1084) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400c:c05::22f Cc: Stefan Hajnoczi , "H. Peter Anvin" , Gerd Hoffmann Subject: [Qemu-devel] [PATCH] hw/usb/dev-audio.c: make USB audio card sound perfect X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The USB audio card would not play audio well because its buffer was too small. Increasing it made it play perfectly. All the crackling and dropouts are gone. Signed-off-by: John Arbuckle --- This patch was tested on qemu-system-ppc running Linux and qemu-system-i386 running Windows XP. Windows XP sound output thru the USB audio card sounded perfect. Linux did improve in sound quality, but it still wasn't perfect. I think there are problems with the hcd-ohci.c file. The Mac OS 10.2 guest in qemu-system-ppc did not play sound due to USB issues unrelated to this patch. hw/usb/dev-audio.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c index f092bb8..e4e4989 100644 --- a/hw/usb/dev-audio.c +++ b/hw/usb/dev-audio.c @@ -88,6 +88,7 @@ static const USBDescStrings usb_audio_stringtable = { #define USBAUDIO_PACKET_SIZE 192 #define USBAUDIO_SAMPLE_RATE 48000 #define USBAUDIO_PACKET_INTERVAL 1 +#define BUFFER_MULTIPLIER 32 static const USBDescIface desc_iface[] = { { @@ -664,7 +665,7 @@ static const VMStateDescription vmstate_usb_audio = { static Property usb_audio_properties[] = { DEFINE_PROP_UINT32("debug", USBAudioState, debug, 0), DEFINE_PROP_UINT32("buffer", USBAudioState, buffer, - 8 * USBAUDIO_PACKET_SIZE), + BUFFER_MULTIPLIER * USBAUDIO_PACKET_SIZE), DEFINE_PROP_END_OF_LIST(), };