diff mbox

ui/cocoa.m: addRemovableDevicesMenuItems() warning fix

Message ID 7B365FC2-072B-4E8D-A1D9-922C2D691A83@gmail.com
State New
Headers show

Commit Message

Programmingkid Sept. 25, 2015, 10:44 p.m. UTC
Eliminate this warning associated with the addRemovableDevicesMenuItems()
function:

ui/cocoa.m:1344:13: warning: function declaration isn't a prototype
[-Wstrict-prototypes]
 static void addRemovableDevicesMenuItems()
             ^
ui/cocoa.m: In function 'addRemovableDevicesMenuItems':
ui/cocoa.m:1344:13: warning: old-style function definition [-Wold-style-definition]


Signed-off-by: John Arbuckle <programmingkidx@gmail.com>

---
 ui/cocoa.m |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Peter Maydell Oct. 13, 2015, 8:33 p.m. UTC | #1
On 25 September 2015 at 23:44, Programmingkid <programmingkidx@gmail.com> wrote:
> Eliminate this warning associated with the addRemovableDevicesMenuItems()
> function:
>
> ui/cocoa.m:1344:13: warning: function declaration isn't a prototype
> [-Wstrict-prototypes]
>  static void addRemovableDevicesMenuItems()
>              ^
> ui/cocoa.m: In function 'addRemovableDevicesMenuItems':
> ui/cocoa.m:1344:13: warning: old-style function definition [-Wold-style-definition]
>
>
> Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
>
> ---
>  ui/cocoa.m |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 334e6f6..a94cc68 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -1341,7 +1341,7 @@ static void add_console_menu_entries(void)
>  /* Make menu items for all removable devices.
>   * Each device is given an 'Eject' and 'Change' menu item.
>   */
> -static void addRemovableDevicesMenuItems()
> +static void addRemovableDevicesMenuItems(void)
>  {
>      NSMenu *menu;
>      NSMenuItem *menuItem;
> --
> 1.7.5.4
>

Thanks, applied to cocoa.next.

-- PMM
diff mbox

Patch

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 334e6f6..a94cc68 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1341,7 +1341,7 @@  static void add_console_menu_entries(void)
 /* Make menu items for all removable devices.
  * Each device is given an 'Eject' and 'Change' menu item.
  */
-static void addRemovableDevicesMenuItems()
+static void addRemovableDevicesMenuItems(void)
 {
     NSMenu *menu;
     NSMenuItem *menuItem;