From patchwork Fri Jun 24 12:34:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artyom Tarasenko X-Patchwork-Id: 640162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rbd8y44Pyz9t0f for ; Fri, 24 Jun 2016 22:35:46 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=kYCBP76n; dkim-atps=neutral Received: from localhost ([::1]:43167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGQKm-0002Fm-Hq for incoming@patchwork.ozlabs.org; Fri, 24 Jun 2016 08:35:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGQK4-0001mD-9l for qemu-devel@nongnu.org; Fri, 24 Jun 2016 08:35:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGQK0-0002nE-1X for qemu-devel@nongnu.org; Fri, 24 Jun 2016 08:34:59 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:35348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGQJz-0002mq-Py for qemu-devel@nongnu.org; Fri, 24 Jun 2016 08:34:55 -0400 Received: by mail-wm0-x241.google.com with SMTP id a66so4617249wme.2 for ; Fri, 24 Jun 2016 05:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=PYBmnHN7npETKngSJViNQ1U5WjnOzWoJ+dUVtW+NNcA=; b=kYCBP76nh+bKhK8H7RtssGM0UhuK0LG0LgsxImF5+QfUWAhD3y15yK1qrGyFrt9kIr md8GspZNHF7BVtxctsEiGLqGK+US5mQIV2naN4egB+yaGhOsYLw3kYMQW3/KbMLE5hAz vsrwc+vcJRMFoFGvScIgrEOAl8hTSRRmHSeImzCW6JN8PX1uaA+G+2KgA+ZAB4bz7BF1 0fTmb//SAtgAWy1UnIl1jTwrXdm8aizgTHGwY3OUgeC59Cb+k2f7Zf8JIoWcF0WFJ5Yn KBKSWN9Xo2mhqwLLLXcunIl5DkUaiHIvr68n2FCYFEzpp6s2yqXF/ggfa/LgdoFQJLlj 5tZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=PYBmnHN7npETKngSJViNQ1U5WjnOzWoJ+dUVtW+NNcA=; b=J8+QT0wdW/iW4AYiAvRgYmaTRkJ/acsD0mVyeEPjTXmliv3Yd3ijkJKTggMRnFqWPx un+VMeKq28q6gnFOReTQfqGk9Fme7RDZUVYqHjwflQ2B8694LJr290QZwzeWDpkKHG3+ NqDeWccvDIS3q/jGeXt+z0IJWcGiKC6X32KvUK+FCb8MTk+uIla+1oWNcJ7ahsFcQXxz /qPsHTrXaaU0WR3YrEeWgHDHtTvs23EVFFbm9UWwnSUX6k2n4NW52vWJaulGk1CBJW3n R4YM4tf5UzsASb7LQ3ZbKeE0bO9ROBl5CzXvn+FKklg82nXbBUCzqZryBcLI/saon7co YArw== X-Gm-Message-State: ALyK8tK/dII+LkGQExQ93S8Dxi6Ld6pjy3kHa2pcjNH4bMcZhpNoJIi72MA9u4wRmtoLGQ== X-Received: by 10.28.109.137 with SMTP id b9mr18716858wmi.68.1466771694712; Fri, 24 Jun 2016 05:34:54 -0700 (PDT) Received: from localhost (x55b5c10e.dyn.telefonica.de. [85.181.193.14]) by smtp.gmail.com with ESMTPSA id z5sm2949482wme.5.2016.06.24.05.34.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jun 2016 05:34:53 -0700 (PDT) From: Artyom Tarasenko To: qemu-devel@nongnu.org Date: Fri, 24 Jun 2016 14:34:30 +0200 Message-Id: <576786e68176302163d09977c6c8c3eb6d7a8ee5.1466771151.git.atar4qemu@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PATCH] target-sparc: fix register corruption in ldstub if there is no write permission X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.cave-ayland@ilande.co.uk, Artyom Tarasenko , rth@twiddle.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Artyom Tarasenko Tested-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- target-sparc/translate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 5111cf0..065326c 100644 --- a/target-sparc/translate.c +++ b/target-sparc/translate.c @@ -5187,12 +5187,15 @@ printf("ops, illegal rdhpr\n"); case 0xd: /* ldstub -- XXX: should be atomically */ { TCGv r_const; + TCGv tmp = tcg_temp_new(); gen_address_mask(dc, cpu_addr); - tcg_gen_qemu_ld8u(cpu_val, cpu_addr, dc->mem_idx); + tcg_gen_qemu_ld8u(tmp, cpu_addr, dc->mem_idx); r_const = tcg_const_tl(0xff); tcg_gen_qemu_st8(r_const, cpu_addr, dc->mem_idx); + tcg_gen_mov_tl(cpu_val, tmp); tcg_temp_free(r_const); + tcg_temp_free(tmp); } break; case 0x0f: