From patchwork Mon Apr 29 12:35:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 240362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 307FE2C00C0 for ; Mon, 29 Apr 2013 22:35:38 +1000 (EST) Received: from localhost ([::1]:40431 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWnIr-0001Fb-M7 for incoming@patchwork.ozlabs.org; Mon, 29 Apr 2013 08:35:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWnIa-0001DR-Qv for qemu-devel@nongnu.org; Mon, 29 Apr 2013 08:35:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWnIV-0005Mo-Nu for qemu-devel@nongnu.org; Mon, 29 Apr 2013 08:35:16 -0400 Received: from thoth.sbs.de ([192.35.17.2]:28154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWnIV-0005MK-FR for qemu-devel@nongnu.org; Mon, 29 Apr 2013 08:35:11 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id r3TCZ8JB001366; Mon, 29 Apr 2013 14:35:09 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id r3TCZ8SL011578; Mon, 29 Apr 2013 14:35:08 +0200 Message-ID: <517E68FC.6030400@siemens.com> Date: Mon, 29 Apr 2013 14:35:08 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: qemu-devel , =?ISO-8859-1?Q?Andreas_F=E4rber?= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 192.35.17.2 Cc: Paolo Bonzini Subject: [Qemu-devel] [PATCH] qdev: Report errors collected during device realization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Better than just releasing the error object silently. Signed-off-by: Jan Kiszka Reviewed-by: Andreas Färber --- hw/core/qdev.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 4eb0134..ab1d8f5 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev) object_property_set_bool(OBJECT(dev), true, "realized", &local_err); if (local_err != NULL) { + qerror_report_err(local_err); error_free(local_err); qdev_free(dev); return -1;