From patchwork Thu Nov 22 19:56:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 201174 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4B2D72C0089 for ; Fri, 23 Nov 2012 06:56:33 +1100 (EST) Received: from localhost ([::1]:57318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbcsx-0005US-59 for incoming@patchwork.ozlabs.org; Thu, 22 Nov 2012 14:56:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbcsl-0005UK-Us for qemu-devel@nongnu.org; Thu, 22 Nov 2012 14:56:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tbcsh-0003hS-Tx for qemu-devel@nongnu.org; Thu, 22 Nov 2012 14:56:19 -0500 Received: from goliath.siemens.de ([192.35.17.28]:31298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tbcsh-0003hJ-KT for qemu-devel@nongnu.org; Thu, 22 Nov 2012 14:56:15 -0500 Received: from mail1.siemens.de (localhost [127.0.0.1]) by goliath.siemens.de (8.13.6/8.13.6) with ESMTP id qAMJuCf7014556; Thu, 22 Nov 2012 20:56:12 +0100 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id qAMJuBiI020909; Thu, 22 Nov 2012 20:56:12 +0100 Message-ID: <50AE835B.1020706@siemens.com> Date: Thu, 22 Nov 2012 20:56:11 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Anthony Liguori , qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 192.35.17.28 Cc: Paolo Bonzini , Stefan Hajnoczi Subject: [Qemu-devel] [PATCH] event notifier: Fix setup for win32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The event notifier state is only reset by test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events. Signed-off-by: Jan Kiszka Reviewed-by: Stefan Hajnoczi --- Grr, the last place I looked at after hours of debugging... event_notifier-win32.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/event_notifier-win32.c b/event_notifier-win32.c index c723dad..4ed21c2 100644 --- a/event_notifier-win32.c +++ b/event_notifier-win32.c @@ -16,7 +16,7 @@ int event_notifier_init(EventNotifier *e, int active) { - e->event = CreateEvent(NULL, FALSE, FALSE, NULL); + e->event = CreateEvent(NULL, TRUE, FALSE, NULL); assert(e->event); return 0; }