From patchwork Mon Aug 20 18:11:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 178912 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 321B52C00AC for ; Tue, 21 Aug 2012 04:11:52 +1000 (EST) Received: from localhost ([::1]:53535 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3WS6-00014G-84 for incoming@patchwork.ozlabs.org; Mon, 20 Aug 2012 14:11:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3WRx-0000wS-Aw for qemu-devel@nongnu.org; Mon, 20 Aug 2012 14:11:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3WRv-00085A-Gy for qemu-devel@nongnu.org; Mon, 20 Aug 2012 14:11:41 -0400 Received: from thoth.sbs.de ([192.35.17.2]:16540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3WRv-00084u-6k for qemu-devel@nongnu.org; Mon, 20 Aug 2012 14:11:39 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id q7KIBasA003941; Mon, 20 Aug 2012 20:11:37 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q7KIBaFl001853; Mon, 20 Aug 2012 20:11:36 +0200 Message-ID: <50327DD8.8070205@siemens.com> Date: Mon, 20 Aug 2012 20:11:36 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: qemu-devel X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.2 Cc: Paolo Bonzini Subject: [Qemu-devel] [PATCH] Drop redundant resume_all_vcpus from main X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org VCPUs are either resumed directly via vm_start, after the incoming migration is done, or when a continue command is issued. We don't need the explicit resume before entering main_loop. Signed-off-by: Jan Kiszka --- I was adding nesting support to pause/resume_all_vcpus, and that stumbled over the imbalance below. vl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index ebee867..231d3ab 100644 --- a/vl.c +++ b/vl.c @@ -3757,7 +3757,6 @@ int main(int argc, char **argv, char **envp) os_setup_post(); - resume_all_vcpus(); main_loop(); bdrv_close_all(); pause_all_vcpus();