From patchwork Fri Aug 17 10:56:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 178187 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9F9052C0090 for ; Fri, 17 Aug 2012 20:56:55 +1000 (EST) Received: from localhost ([::1]:52778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2KEX-0000So-S5 for incoming@patchwork.ozlabs.org; Fri, 17 Aug 2012 06:56:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2KEQ-0000Sj-TE for qemu-devel@nongnu.org; Fri, 17 Aug 2012 06:56:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2KEP-0008K5-Pg for qemu-devel@nongnu.org; Fri, 17 Aug 2012 06:56:46 -0400 Received: from thoth.sbs.de ([192.35.17.2]:17094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2KEP-0008Jx-Ej for qemu-devel@nongnu.org; Fri, 17 Aug 2012 06:56:45 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id q7HAuiwL018024; Fri, 17 Aug 2012 12:56:44 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q7HAui1O004966; Fri, 17 Aug 2012 12:56:44 +0200 Message-ID: <502E236C.6090508@siemens.com> Date: Fri, 17 Aug 2012 12:56:44 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Anthony Liguori X-MIME-Autoconverted: from 8bit to quoted-printable by thoth.sbs.de id q7HAuiwL018024 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.2 Cc: =?ISO-8859-1?Q?Herv=E9_Poussine?= =?ISO-8859-1?Q?au?= , qemu-devel Subject: [Qemu-devel] [RESEND][PATCH for 1.2] i82378: Remove bogus MMIO coalescing X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. Acked-by: Hervé Poussineau Signed-off-by: Jan Kiszka Acked-by: Andreas Färber --- hw/i82378.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/i82378.c b/hw/i82378.c index 9b11d90..2123c14 100644 --- a/hw/i82378.c +++ b/hw/i82378.c @@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev) pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io); memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000); - memory_region_set_coalescing(&s->mem); pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem); /* Make I/O address read only */