| Message ID | 20240624-b4-move-to-freebsd-v3-1-71496bf119d4@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tests/avocado: updates for sbsa-ref testing | expand |
On Mon, 24 Jun 2024 at 17:20, Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> wrote: > > FreeBSD has longer support cycle for stable release (14.x EoL in 2028) > than OpenBSD (7.3 we used is already EoL). Also bugfixes are backported > so we can stay on 14.x for longer. Tests done on OpenBSD will now be > done using FreeBSD. > > OpenBSD 7.3 stays with Cortex-A57 test for local runs only. > > Moved from Neoverse-N1 to Neoverse-N2 as sbsa-ref defaults were changed. > > Timeout messages expanded to mention being affected by PAuth emulation. > > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > --- > tests/avocado/machine_aarch64_sbsaref.py | 75 ++++++++++++++++++++++++-------- > 1 file changed, 56 insertions(+), 19 deletions(-) > > diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py > index 6bb82f2a03..bb2c098aac 100644 > --- a/tests/avocado/machine_aarch64_sbsaref.py > +++ b/tests/avocado/machine_aarch64_sbsaref.py > @@ -1,4 +1,4 @@ > -# Functional test that boots a Linux kernel and checks the console > +# Functional test that boots a kernel and checks the console > # > # SPDX-FileCopyrightText: 2023-2024 Linaro Ltd. > # SPDX-FileContributor: Philippe Mathieu-Daudé <philmd@linaro.org> > @@ -8,7 +8,7 @@ > > import os > > -from avocado import skipUnless > +from avocado import skipIf, skipUnless > from avocado.utils import archive > > from avocado_qemu import QemuSystemTest > @@ -165,7 +165,8 @@ def test_sbsaref_alpine_linux_max_pauth_impdef(self): > """ > self.boot_alpine_linux("max,pauth-impdef=on") > > - @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') > + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), > + 'Test might timeout due to PAuth emulation') > def test_sbsaref_alpine_linux_max(self): > """ > :avocado: tags=cpu:max > @@ -173,7 +174,6 @@ def test_sbsaref_alpine_linux_max(self): > """ > self.boot_alpine_linux("max") > > - > # This tests the whole boot chain from EFI to Userspace > # We only boot a whole OS for the current top level CPU and GIC > # Other test profiles should use more minimal boots > @@ -200,6 +200,9 @@ def boot_openbsd73(self, cpu): > "Welcome to the OpenBSD/arm64" > " 7.3 installation program.") > > + > + # we keep OpenBSD 7.3 on Cortex-A57 by request > + @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') Don't skip stuff if GITLAB_CI, please. If we don't want to run it on the CI then we shouldn't be running it by default when a local user runs check-avocado either. Any skip should have a clear description of the reason why we're skipping it. thanks -- PMM
On 1/7/24 15:37, Peter Maydell wrote: > On Mon, 24 Jun 2024 at 17:20, Marcin Juszkiewicz > <marcin.juszkiewicz@linaro.org> wrote: >> >> FreeBSD has longer support cycle for stable release (14.x EoL in 2028) >> than OpenBSD (7.3 we used is already EoL). Also bugfixes are backported >> so we can stay on 14.x for longer. Tests done on OpenBSD will now be >> done using FreeBSD. >> >> OpenBSD 7.3 stays with Cortex-A57 test for local runs only. >> >> Moved from Neoverse-N1 to Neoverse-N2 as sbsa-ref defaults were changed. >> >> Timeout messages expanded to mention being affected by PAuth emulation. >> >> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> >> --- >> tests/avocado/machine_aarch64_sbsaref.py | 75 ++++++++++++++++++++++++-------- >> 1 file changed, 56 insertions(+), 19 deletions(-) >> >> diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py >> index 6bb82f2a03..bb2c098aac 100644 >> --- a/tests/avocado/machine_aarch64_sbsaref.py >> +++ b/tests/avocado/machine_aarch64_sbsaref.py >> @@ -1,4 +1,4 @@ >> -# Functional test that boots a Linux kernel and checks the console >> +# Functional test that boots a kernel and checks the console >> # >> # SPDX-FileCopyrightText: 2023-2024 Linaro Ltd. >> # SPDX-FileContributor: Philippe Mathieu-Daudé <philmd@linaro.org> >> @@ -8,7 +8,7 @@ >> >> import os >> >> -from avocado import skipUnless >> +from avocado import skipIf, skipUnless >> from avocado.utils import archive >> >> from avocado_qemu import QemuSystemTest >> @@ -165,7 +165,8 @@ def test_sbsaref_alpine_linux_max_pauth_impdef(self): >> """ >> self.boot_alpine_linux("max,pauth-impdef=on") >> >> - @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') >> + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), >> + 'Test might timeout due to PAuth emulation') >> def test_sbsaref_alpine_linux_max(self): >> """ >> :avocado: tags=cpu:max >> @@ -173,7 +174,6 @@ def test_sbsaref_alpine_linux_max(self): >> """ >> self.boot_alpine_linux("max") >> >> - >> # This tests the whole boot chain from EFI to Userspace >> # We only boot a whole OS for the current top level CPU and GIC >> # Other test profiles should use more minimal boots >> @@ -200,6 +200,9 @@ def boot_openbsd73(self, cpu): >> "Welcome to the OpenBSD/arm64" >> " 7.3 installation program.") >> >> + >> + # we keep OpenBSD 7.3 on Cortex-A57 by request >> + @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') > > Don't skip stuff if GITLAB_CI, please. If we don't want to > run it on the CI then we shouldn't be running it by default > when a local user runs check-avocado either. I did request that. > Any skip should have a clear description of the reason why > we're skipping it. Right. Maybe replace by: @skipUnless(os.getenv('AVOCADO_TEST_LEGACY_OS'), 'OpenBSD 7.3 is EoL') Or AVOCADO_TEST_LEGACY_OPENBSD... Naming is hard. Regards, Phil.
diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index 6bb82f2a03..bb2c098aac 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -1,4 +1,4 @@ -# Functional test that boots a Linux kernel and checks the console +# Functional test that boots a kernel and checks the console # # SPDX-FileCopyrightText: 2023-2024 Linaro Ltd. # SPDX-FileContributor: Philippe Mathieu-Daudé <philmd@linaro.org> @@ -8,7 +8,7 @@ import os -from avocado import skipUnless +from avocado import skipIf, skipUnless from avocado.utils import archive from avocado_qemu import QemuSystemTest @@ -165,7 +165,8 @@ def test_sbsaref_alpine_linux_max_pauth_impdef(self): """ self.boot_alpine_linux("max,pauth-impdef=on") - @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), + 'Test might timeout due to PAuth emulation') def test_sbsaref_alpine_linux_max(self): """ :avocado: tags=cpu:max @@ -173,7 +174,6 @@ def test_sbsaref_alpine_linux_max(self): """ self.boot_alpine_linux("max") - # This tests the whole boot chain from EFI to Userspace # We only boot a whole OS for the current top level CPU and GIC # Other test profiles should use more minimal boots @@ -200,6 +200,9 @@ def boot_openbsd73(self, cpu): "Welcome to the OpenBSD/arm64" " 7.3 installation program.") + + # we keep OpenBSD 7.3 on Cortex-A57 by request + @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') def test_sbsaref_openbsd73_cortex_a57(self): """ :avocado: tags=cpu:cortex-a57 @@ -207,32 +210,66 @@ def test_sbsaref_openbsd73_cortex_a57(self): """ self.boot_openbsd73("cortex-a57") - def test_sbsaref_openbsd73_neoverse_n1(self): + + # This tests the whole boot chain from EFI to Userspace + # We only boot a whole OS for the current top level CPU and GIC + # Other test profiles should use more minimal boots + def boot_freebsd(self, cpu): + self.fetch_firmware() + + img_url = ( + "https://download.freebsd.org/releases/arm64/aarch64/ISO-IMAGES/" + "14.1/FreeBSD-14.1-RELEASE-arm64-aarch64-bootonly.iso" + ) + + img_hash = "44cdbae275ef1bb6dab1d5fbb59473d4f741e1c8ea8a80fd9e906b531d6ad461" + img_path = self.fetch_asset(img_url, algorithm="sha256", asset_hash=img_hash) + + self.vm.set_console() + self.vm.add_args( + "-cpu", + cpu, + "-drive", + f"file={img_path},format=raw", + ) + + self.vm.launch() + wait_for_console_pattern(self, "Welcome to FreeBSD!") + + def test_sbsaref_freebsd_cortex_a57(self): """ - :avocado: tags=cpu:neoverse-n1 - :avocado: tags=os:openbsd + :avocado: tags=cpu:cortex-a57 + :avocado: tags=os:freebsd + """ + self.boot_freebsd("cortex-a57") + + # We use Neoverse-N2 as default cpu + def test_sbsaref_freebsd_neoverse_n2(self): """ - self.boot_openbsd73("neoverse-n1") + :avocado: tags=cpu:neoverse-n2 + :avocado: tags=os:freebsd + """ + self.boot_freebsd("neoverse-n2") - def test_sbsaref_openbsd73_max_pauth_off(self): + def test_sbsaref_freebsd_max_pauth_off(self): """ :avocado: tags=cpu:max - :avocado: tags=os:openbsd + :avocado: tags=os:freebsd """ - self.boot_openbsd73("max,pauth=off") + self.boot_freebsd("max,pauth=off") - @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') - def test_sbsaref_openbsd73_max_pauth_impdef(self): + def test_sbsaref_freebsd_max_pauth_impdef(self): """ :avocado: tags=cpu:max - :avocado: tags=os:openbsd + :avocado: tags=os:freebsd """ - self.boot_openbsd73("max,pauth-impdef=on") + self.boot_freebsd("max,pauth-impdef=on") - @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout') - def test_sbsaref_openbsd73_max(self): + @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), + 'Test might timeout due to PAuth emulation') + def test_sbsaref_freebsd_max(self): """ :avocado: tags=cpu:max - :avocado: tags=os:openbsd + :avocado: tags=os:freebsd """ - self.boot_openbsd73("max") + self.boot_freebsd("max")
FreeBSD has longer support cycle for stable release (14.x EoL in 2028) than OpenBSD (7.3 we used is already EoL). Also bugfixes are backported so we can stay on 14.x for longer. Tests done on OpenBSD will now be done using FreeBSD. OpenBSD 7.3 stays with Cortex-A57 test for local runs only. Moved from Neoverse-N1 to Neoverse-N2 as sbsa-ref defaults were changed. Timeout messages expanded to mention being affected by PAuth emulation. Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> --- tests/avocado/machine_aarch64_sbsaref.py | 75 ++++++++++++++++++++++++-------- 1 file changed, 56 insertions(+), 19 deletions(-)