diff mbox series

[3/6] target/ppc: fix REQUIRE_HV macro definition

Message ID 20221006200654.725390-4-matheus.ferst@eldorado.org.br
State New
Headers show
Series Enable doorbell instruction for POWER8 CPUs | expand

Commit Message

Matheus K. Ferst Oct. 6, 2022, 8:06 p.m. UTC 
The macro is missing a '{' after the if condition. Any use of REQUIRE_HV
would cause a compilation error.

Fixes: fc34e81acd51 ("target/ppc: add macros to check privilege level")
Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
---
 target/ppc/translate.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Fabiano Rosas Oct. 7, 2022, 7:07 p.m. UTC | #1 
Matheus Ferst <matheus.ferst@eldorado.org.br> writes:

> The macro is missing a '{' after the if condition. Any use of REQUIRE_HV
> would cause a compilation error.
>
> Fixes: fc34e81acd51 ("target/ppc: add macros to check privilege level")
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>

Reviewed-by: Fabiano Rosas <farosas@linux.ibm.com>

> ---
>  target/ppc/translate.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index eaac8670b1..435066c4a3 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -6545,12 +6545,12 @@ static int64_t dw_compose_ea(DisasContext *ctx, int x)
>          }                           \
>      } while (0)
>  
> -#define REQUIRE_HV(CTX)                         \
> -    do {                                        \
> -        if (unlikely((CTX)->pr || !(CTX)->hv))  \
> -            gen_priv_opc(CTX);                  \
> -            return true;                        \
> -        }                                       \
> +#define REQUIRE_HV(CTX)                             \
> +    do {                                            \
> +        if (unlikely((CTX)->pr || !(CTX)->hv)) {    \
> +            gen_priv_opc(CTX);                      \
> +            return true;                            \
> +        }                                           \
>      } while (0)
>  #else
>  #define REQUIRE_SV(CTX) do { gen_priv_opc(CTX); return true; } while (0)
diff mbox series

Patch

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index eaac8670b1..435066c4a3 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -6545,12 +6545,12 @@  static int64_t dw_compose_ea(DisasContext *ctx, int x)
         }                           \
     } while (0)
 
-#define REQUIRE_HV(CTX)                         \
-    do {                                        \
-        if (unlikely((CTX)->pr || !(CTX)->hv))  \
-            gen_priv_opc(CTX);                  \
-            return true;                        \
-        }                                       \
+#define REQUIRE_HV(CTX)                             \
+    do {                                            \
+        if (unlikely((CTX)->pr || !(CTX)->hv)) {    \
+            gen_priv_opc(CTX);                      \
+            return true;                            \
+        }                                           \
     } while (0)
 #else
 #define REQUIRE_SV(CTX) do { gen_priv_opc(CTX); return true; } while (0)