| Message ID | 20220710170014.1673480-3-ani@anisinha.ca |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce new acpi/smbios python tests using biosbits | expand |
On Sun, Jul 10, 2022 at 10:30:05PM +0530, Ani Sinha wrote: > Added the SPDX license identifiers based on the following output from the > licensee tool for bios bits: > > $ licensee detect bits/ > License: NOASSERTION > Matched files: COPYING > COPYING: > Content hash: 7a1fdfa894728ea69588977442c92073aad69e50 > License: NOASSERTION > Closest non-matching licenses: > BSD-3-Clause-Clear similarity: 85.82% > BSD-4-Clause similarity: 83.69% > BSD-3-Clause similarity: 77.27% This report looks pretty bogus to me. smbios.py license header pretty clearly matches BSD-3-Clause with 99% similarity. https://spdx.org/licenses/BSD-3-Clause.html and is pretty different from https://spdx.org/licenses/BSD-3-Clause-Clear.html which adds a statement about patent rights which doens't exist. If we're going to add SPDX tags to existing files it needs to be done by a human, not an automated tool. If not possible, we should leave off SPDX tags, because adding incorrect SPDX tags creates more harm With regards, Daniel
On Thu, 14 Jul 2022, Daniel P. Berrangé wrote: > On Sun, Jul 10, 2022 at 10:30:05PM +0530, Ani Sinha wrote: > > Added the SPDX license identifiers based on the following output from the > > licensee tool for bios bits: > > > > $ licensee detect bits/ > > License: NOASSERTION > > Matched files: COPYING > > COPYING: > > Content hash: 7a1fdfa894728ea69588977442c92073aad69e50 > > License: NOASSERTION > > Closest non-matching licenses: > > BSD-3-Clause-Clear similarity: 85.82% > > BSD-4-Clause similarity: 83.69% > > BSD-3-Clause similarity: 77.27% > > This report looks pretty bogus to me. > > smbios.py license header pretty clearly matches BSD-3-Clause with > 99% similarity. OK in the next iteration I will fix this. This tool likely just looked at the COPYING file in bits and not the individual python files. > > https://spdx.org/licenses/BSD-3-Clause.html > > and is pretty different from > > https://spdx.org/licenses/BSD-3-Clause-Clear.html > > which adds a statement about patent rights which doens't exist. > > > If we're going to add SPDX tags to existing files it needs to be > done by a human, not an automated tool. If not possible, we should > leave off SPDX tags, because adding incorrect SPDX tags creates > more harm > > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > >
diff --git a/tests/pytest/acpi-bits/bits-tests/smbios.py b/tests/pytest/acpi-bits/bits-tests/smbios.py index 9667d0542c..05ee8661c2 100644 --- a/tests/pytest/acpi-bits/bits-tests/smbios.py +++ b/tests/pytest/acpi-bits/bits-tests/smbios.py @@ -1,6 +1,8 @@ # Copyright (c) 2015, Intel Corporation # All rights reserved. # +# SPDX-License-Identifier: BSD-3-Clause-Clear +# # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions are met: # diff --git a/tests/pytest/acpi-bits/bits-tests/testacpi.py b/tests/pytest/acpi-bits/bits-tests/testacpi.py index 9ec452f330..8e6bb3bbc6 100644 --- a/tests/pytest/acpi-bits/bits-tests/testacpi.py +++ b/tests/pytest/acpi-bits/bits-tests/testacpi.py @@ -1,6 +1,8 @@ # Copyright (c) 2015, Intel Corporation # All rights reserved. # +# SPDX-License-Identifier: BSD-3-Clause-Clear +# # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions are met: # diff --git a/tests/pytest/acpi-bits/bits-tests/testcpuid.py b/tests/pytest/acpi-bits/bits-tests/testcpuid.py index ac55d912e1..94cc149556 100644 --- a/tests/pytest/acpi-bits/bits-tests/testcpuid.py +++ b/tests/pytest/acpi-bits/bits-tests/testcpuid.py @@ -1,6 +1,8 @@ # Copyright (c) 2012, Intel Corporation # All rights reserved. # +# SPDX-License-Identifier: BSD-3-Clause-Clear +# # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions are met: #
Added the SPDX license identifiers based on the following output from the licensee tool for bios bits: $ licensee detect bits/ License: NOASSERTION Matched files: COPYING COPYING: Content hash: 7a1fdfa894728ea69588977442c92073aad69e50 License: NOASSERTION Closest non-matching licenses: BSD-3-Clause-Clear similarity: 85.82% BSD-4-Clause similarity: 83.69% BSD-3-Clause similarity: 77.27% Signed-off-by: Ani Sinha <ani@anisinha.ca> --- tests/pytest/acpi-bits/bits-tests/smbios.py | 2 ++ tests/pytest/acpi-bits/bits-tests/testacpi.py | 2 ++ tests/pytest/acpi-bits/bits-tests/testcpuid.py | 2 ++ 3 files changed, 6 insertions(+)