diff mbox series

[5/9] tests/avocado/linux_ssh_mips_malta.py: add missing accel (tcg) tag

Message ID 20220225210156.2032055-6-crosa@redhat.com
State New
Headers show
Series Avocado tests: filter out tests using TCG booting full blown distros | expand

Commit Message

Cleber Rosa Feb. 25, 2022, 9:01 p.m. UTC
Being explicit about the accelerator used on these tests is a good
thing in itself, but it will also be used in the filtering rules
applied on "make check-avocado".

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/avocado/linux_ssh_mips_malta.py | 3 +++
 1 file changed, 3 insertions(+)

Comments

Philippe Mathieu-Daudé Feb. 27, 2022, 6:47 p.m. UTC | #1
On 25/2/22 22:01, Cleber Rosa wrote:
> Being explicit about the accelerator used on these tests is a good
> thing in itself, but it will also be used in the filtering rules
> applied on "make check-avocado".
> 
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   tests/avocado/linux_ssh_mips_malta.py | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tests/avocado/linux_ssh_mips_malta.py b/tests/avocado/linux_ssh_mips_malta.py
> index c0f0be5ade..0179d8a6ca 100644
> --- a/tests/avocado/linux_ssh_mips_malta.py
> +++ b/tests/avocado/linux_ssh_mips_malta.py
> @@ -23,6 +23,9 @@
>   @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')

Should we remove this line then? ^^^

>   @skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
>   class LinuxSSH(QemuSystemTest, LinuxSSHMixIn):
> +    """
> +    :avocado: tags=accel:tcg
> +    """
>   
>       timeout = 150 # Not for 'configure --enable-debug --enable-debug-tcg'
>
Cleber Rosa March 3, 2022, 12:13 p.m. UTC | #2
Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:

> On 25/2/22 22:01, Cleber Rosa wrote:
>> Being explicit about the accelerator used on these tests is a good
>> thing in itself, but it will also be used in the filtering rules
>> applied on "make check-avocado".
>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>> ---
>>   tests/avocado/linux_ssh_mips_malta.py | 3 +++
>>   1 file changed, 3 insertions(+)
>> diff --git a/tests/avocado/linux_ssh_mips_malta.py
>> b/tests/avocado/linux_ssh_mips_malta.py
>> index c0f0be5ade..0179d8a6ca 100644
>> --- a/tests/avocado/linux_ssh_mips_malta.py
>> +++ b/tests/avocado/linux_ssh_mips_malta.py
>> @@ -23,6 +23,9 @@
>>   @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>
> Should we remove this line then? ^^^
>

Yes, we definitely should.  But, I thought it should be a next step.
The reason being that manual invocations of avocado or a custom list of
tests to "make check-avocado" will still respect that at this point.

What do you think?

Cheers,
- Cleber.
Philippe Mathieu-Daudé March 6, 2022, 11:57 p.m. UTC | #3
On 3/3/22 13:13, Cleber Rosa wrote:
> 
> Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> writes:
> 
>> On 25/2/22 22:01, Cleber Rosa wrote:
>>> Being explicit about the accelerator used on these tests is a good
>>> thing in itself, but it will also be used in the filtering rules
>>> applied on "make check-avocado".
>>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>>> ---
>>>    tests/avocado/linux_ssh_mips_malta.py | 3 +++
>>>    1 file changed, 3 insertions(+)
>>> diff --git a/tests/avocado/linux_ssh_mips_malta.py
>>> b/tests/avocado/linux_ssh_mips_malta.py
>>> index c0f0be5ade..0179d8a6ca 100644
>>> --- a/tests/avocado/linux_ssh_mips_malta.py
>>> +++ b/tests/avocado/linux_ssh_mips_malta.py
>>> @@ -23,6 +23,9 @@
>>>    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>>
>> Should we remove this line then? ^^^
>>
> 
> Yes, we definitely should.  But, I thought it should be a next step.

OK.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

And queued to mips-next.
diff mbox series

Patch

diff --git a/tests/avocado/linux_ssh_mips_malta.py b/tests/avocado/linux_ssh_mips_malta.py
index c0f0be5ade..0179d8a6ca 100644
--- a/tests/avocado/linux_ssh_mips_malta.py
+++ b/tests/avocado/linux_ssh_mips_malta.py
@@ -23,6 +23,9 @@ 
 @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
 @skipUnless(ssh.SSH_CLIENT_BINARY, 'No SSH client available')
 class LinuxSSH(QemuSystemTest, LinuxSSHMixIn):
+    """
+    :avocado: tags=accel:tcg
+    """
 
     timeout = 150 # Not for 'configure --enable-debug --enable-debug-tcg'