| Message ID | 20210415215141.1865467-8-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Tests: introduce custom jobs | expand |
On 4/15/21 6:51 PM, Cleber Rosa wrote: > Because s390x targets it can not currently migrate without a guest > running. > > Future work may provide a proper guest, but for now, it's safer to > cancel the test. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/migration.py | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py > index b4d46becc6..4174d55c81 100644 > --- a/tests/acceptance/migration.py > +++ b/tests/acceptance/migration.py > @@ -48,6 +48,12 @@ def do_migrate(self, dest_uri, src_uri=None): > dest_vm = self.get_vm('-incoming', dest_uri) > dest_vm.add_args('-nodefaults', '-no-shutdown') > dest_vm.launch() > + > + cpus = dest_vm.command('query-cpus-fast') > + if cpus: > + if cpus[0].get('target') == 's390x': > + self.cancel('Migration without a guest not possible on s390') > + > if src_uri is None: > src_uri = dest_uri > source_vm = self.get_vm()
On Thu, Apr 15, 2021 at 6:52 PM Cleber Rosa <crosa@redhat.com> wrote: > > Because s390x targets it can not currently migrate without a guest > running. > > Future work may provide a proper guest, but for now, it's safer to > cancel the test. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/migration.py | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
diff --git a/tests/acceptance/migration.py b/tests/acceptance/migration.py index b4d46becc6..4174d55c81 100644 --- a/tests/acceptance/migration.py +++ b/tests/acceptance/migration.py @@ -48,6 +48,12 @@ def do_migrate(self, dest_uri, src_uri=None): dest_vm = self.get_vm('-incoming', dest_uri) dest_vm.add_args('-nodefaults', '-no-shutdown') dest_vm.launch() + + cpus = dest_vm.command('query-cpus-fast') + if cpus: + if cpus[0].get('target') == 's390x': + self.cancel('Migration without a guest not possible on s390') + if src_uri is None: src_uri = dest_uri source_vm = self.get_vm()
Because s390x targets it can not currently migrate without a guest running. Future work may provide a proper guest, but for now, it's safer to cancel the test. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/migration.py | 6 ++++++ 1 file changed, 6 insertions(+)