| Message ID | 20210415215141.1865467-6-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Tests: introduce custom jobs | expand |
On 4/15/21 11:51 PM, Cleber Rosa wrote: > The test contains methods for the proper log of test related "The Test class ..."? > information. Let's use that and remove the print and the unused > logging import. > > Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log This test predates Avocado 87.0 :) Maybe mention this is an update to the recent API? Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/cpu_queries.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py > index 293dccb89a..cc9e380cc7 100644 > --- a/tests/acceptance/cpu_queries.py > +++ b/tests/acceptance/cpu_queries.py > @@ -8,8 +8,6 @@ > # This work is licensed under the terms of the GNU GPL, version 2 or > # later. See the COPYING file in the top-level directory. > > -import logging > - > from avocado_qemu import Test > > class QueryCPUModelExpansion(Test): > @@ -27,7 +25,7 @@ def test(self): > > cpus = self.vm.command('query-cpu-definitions') > for c in cpus: > - print(repr(c)) > + self.log.info("Checking CPU: %s", c) > self.assertNotIn('', c['unavailable-features'], c['name']) > > for c in cpus: >
On Fri, Apr 16, 2021 at 2:15 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > On 4/15/21 11:51 PM, Cleber Rosa wrote: > > The test contains methods for the proper log of test related > > "The Test class ..."? > > > information. Let's use that and remove the print and the unused > > logging import. > > > > Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log > > This test predates Avocado 87.0 :) Maybe mention this is an update > to the recent API? This is not a new feature of Avocado 87.0, it has been there since before Avocado was used on QEMU.
On Thu, Apr 15, 2021 at 6:52 PM Cleber Rosa <crosa@redhat.com> wrote: > > The test contains methods for the proper log of test related > information. Let's use that and remove the print and the unused > logging import. > > Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/cpu_queries.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
On Fri, Apr 16, 2021 at 07:15:07AM +0200, Philippe Mathieu-Daudé wrote: > On 4/15/21 11:51 PM, Cleber Rosa wrote: > > The test contains methods for the proper log of test related > > "The Test class ..."? > Yes, good catch! > > information. Let's use that and remove the print and the unused > > logging import. > > > > Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log > > This test predates Avocado 87.0 :) Maybe mention this is an update > to the recent API? > In fact, that API is *ages* old. I just happened to post a link to the latest stable release, because the build of ancient versions are disable on readthedocs.io. Regards, - Cleber.
Hi, On 4/15/21 6:51 PM, Cleber Rosa wrote: > The test contains methods for the proper log of test related > information. Let's use that and remove the print and the unused > logging import. > > Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/cpu_queries.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py > index 293dccb89a..cc9e380cc7 100644 > --- a/tests/acceptance/cpu_queries.py > +++ b/tests/acceptance/cpu_queries.py > @@ -8,8 +8,6 @@ > # This work is licensed under the terms of the GNU GPL, version 2 or > # later. See the COPYING file in the top-level directory. > > -import logging > - > from avocado_qemu import Test > > class QueryCPUModelExpansion(Test): > @@ -27,7 +25,7 @@ def test(self): > > cpus = self.vm.command('query-cpu-definitions') > for c in cpus: > - print(repr(c)) > + self.log.info("Checking CPU: %s", c) > self.assertNotIn('', c['unavailable-features'], c['name']) > > for c in cpus: While you are here, maybe merge the two `for c in cpus` loops? :D Anyway, Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries.py index 293dccb89a..cc9e380cc7 100644 --- a/tests/acceptance/cpu_queries.py +++ b/tests/acceptance/cpu_queries.py @@ -8,8 +8,6 @@ # This work is licensed under the terms of the GNU GPL, version 2 or # later. See the COPYING file in the top-level directory. -import logging - from avocado_qemu import Test class QueryCPUModelExpansion(Test): @@ -27,7 +25,7 @@ def test(self): cpus = self.vm.command('query-cpu-definitions') for c in cpus: - print(repr(c)) + self.log.info("Checking CPU: %s", c) self.assertNotIn('', c['unavailable-features'], c['name']) for c in cpus:
The test contains methods for the proper log of test related information. Let's use that and remove the print and the unused logging import. Reference: https://avocado-framework.readthedocs.io/en/87.0/api/test/avocado.html#avocado.Test.log Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/cpu_queries.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)