| Message ID | 20210203172357.1422425-14-crosa@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Acceptance Test: introduce base class for Linux based tests | expand |
On 2/3/21 6:23 PM, Cleber Rosa wrote: > Which is useful to select tests that depend/use a particular feature. Is that a question? Why keep this last in your series? > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtiofs_submounts.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virtiofs_submounts.py > index c998b297ee..1e745f15a2 100644 > --- a/tests/acceptance/virtiofs_submounts.py > +++ b/tests/acceptance/virtiofs_submounts.py > @@ -75,6 +75,7 @@ def has_cmds(*cmds): > class VirtiofsSubmountsTest(BootLinux): > """ > :avocado: tags=arch:x86_64 > + :avocado: tags=accel:kvm > """ > > def ssh_connect(self, username, keyfile): >
On 2/3/21 2:23 PM, Cleber Rosa wrote: > Which is useful to select tests that depend/use a particular feature. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtiofs_submounts.py | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> > > diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virtiofs_submounts.py > index c998b297ee..1e745f15a2 100644 > --- a/tests/acceptance/virtiofs_submounts.py > +++ b/tests/acceptance/virtiofs_submounts.py > @@ -75,6 +75,7 @@ def has_cmds(*cmds): > class VirtiofsSubmountsTest(BootLinux): > """ > :avocado: tags=arch:x86_64 > + :avocado: tags=accel:kvm > """ > > def ssh_connect(self, username, keyfile):
On Mon, Feb 08, 2021 at 12:28:22PM +0100, Philippe Mathieu-Daudé wrote: > On 2/3/21 6:23 PM, Cleber Rosa wrote: > > Which is useful to select tests that depend/use a particular feature. > > Is that a question? > No, it's not a question. I meant: "add a tag which is useful to select tests...". I guess this statement followed a similar previous broken approach of mine, reusing the commit title to give it meaning. I'll try to keep avoid that in the future, thanks for asking about it. > Why keep this last in your series? > No reason... it doesn't impact any pre or post patches in the series AFAICT. Cheers, - Cleber.
On Wed, Feb 3, 2021 at 2:24 PM Cleber Rosa <crosa@redhat.com> wrote: > > Which is useful to select tests that depend/use a particular feature. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/acceptance/virtiofs_submounts.py | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
diff --git a/tests/acceptance/virtiofs_submounts.py b/tests/acceptance/virtiofs_submounts.py index c998b297ee..1e745f15a2 100644 --- a/tests/acceptance/virtiofs_submounts.py +++ b/tests/acceptance/virtiofs_submounts.py @@ -75,6 +75,7 @@ def has_cmds(*cmds): class VirtiofsSubmountsTest(BootLinux): """ :avocado: tags=arch:x86_64 + :avocado: tags=accel:kvm """ def ssh_connect(self, username, keyfile):
Which is useful to select tests that depend/use a particular feature. Signed-off-by: Cleber Rosa <crosa@redhat.com> --- tests/acceptance/virtiofs_submounts.py | 1 + 1 file changed, 1 insertion(+)