diff mbox series

[1/3] Acceptance tests: bump pycdlib version for easier installation

Message ID 20201009205513.751968-2-crosa@redhat.com
State New
Headers show
Series Acceptance Tests: improve usage on GitLab CI | expand

Commit Message

Cleber Rosa Oct. 9, 2020, 8:55 p.m. UTC
On with certain versions of "pip", package installations will attempt
to create wheels.  And, on environments without a "complete" Python
installation (as described in the acceptance tests requirements docs),
that will fail.

pycdlib, starting with version 1.11.0, is now being made available
as wheels, so its instalation on those constrained environments is
now possible.

Cc: Bug 1897783 <1897783@bugs.launchpad.net>
Buglink: https://bugs.launchpad.net/qemu/+bug/1880189
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/requirements.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Oct. 10, 2020, 7:36 a.m. UTC | #1
On 10/9/20 10:55 PM, Cleber Rosa wrote:
> On with certain versions of "pip", package installations will attempt
> to create wheels.  And, on environments without a "complete" Python
> installation (as described in the acceptance tests requirements docs),
> that will fail.
> 
> pycdlib, starting with version 1.11.0, is now being made available
> as wheels, so its instalation on those constrained environments is
> now possible.
> 
> Cc: Bug 1897783 <1897783@bugs.launchpad.net>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1880189

This BZ is different. The correct URL is:
https://bugs.launchpad.net/qemu/+bug/1897783

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>   tests/requirements.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/requirements.txt b/tests/requirements.txt
> index 036691c922..a1c631fa59 100644
> --- a/tests/requirements.txt
> +++ b/tests/requirements.txt
> @@ -2,4 +2,4 @@
>   # in the tests/venv Python virtual environment. For more info,
>   # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
>   avocado-framework==81.0
> -pycdlib==1.9.0
> +pycdlib==1.11.0
>
Cleber Rosa Oct. 12, 2020, 1:16 a.m. UTC | #2
On Sat, Oct 10, 2020 at 09:36:17AM +0200, Philippe Mathieu-Daudé wrote:
> On 10/9/20 10:55 PM, Cleber Rosa wrote:
> > On with certain versions of "pip", package installations will attempt
> > to create wheels.  And, on environments without a "complete" Python
> > installation (as described in the acceptance tests requirements docs),
> > that will fail.
> > 
> > pycdlib, starting with version 1.11.0, is now being made available
> > as wheels, so its instalation on those constrained environments is
> > now possible.
> > 
> > Cc: Bug 1897783 <1897783@bugs.launchpad.net>
> > Buglink: https://bugs.launchpad.net/qemu/+bug/1880189
> 
> This BZ is different. The correct URL is:
> https://bugs.launchpad.net/qemu/+bug/1897783
>

Good catch, thanks!

- Cleber.
Willian Rampazzo Oct. 19, 2020, 4:02 p.m. UTC | #3
On Fri, Oct 9, 2020 at 5:55 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> On with certain versions of "pip", package installations will attempt
> to create wheels.  And, on environments without a "complete" Python
> installation (as described in the acceptance tests requirements docs),
> that will fail.
>
> pycdlib, starting with version 1.11.0, is now being made available
> as wheels, so its instalation on those constrained environments is
> now possible.
>
> Cc: Bug 1897783 <1897783@bugs.launchpad.net>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1880189
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
>  tests/requirements.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/requirements.txt b/tests/requirements.txt
> index 036691c922..a1c631fa59 100644
> --- a/tests/requirements.txt
> +++ b/tests/requirements.txt
> @@ -2,4 +2,4 @@
>  # in the tests/venv Python virtual environment. For more info,
>  # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
>  avocado-framework==81.0
> -pycdlib==1.9.0
> +pycdlib==1.11.0
> --
> 2.25.4
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
diff mbox series

Patch

diff --git a/tests/requirements.txt b/tests/requirements.txt
index 036691c922..a1c631fa59 100644
--- a/tests/requirements.txt
+++ b/tests/requirements.txt
@@ -2,4 +2,4 @@ 
 # in the tests/venv Python virtual environment. For more info,
 # refer to: https://pip.pypa.io/en/stable/user_guide/#id1
 avocado-framework==81.0
-pycdlib==1.9.0
+pycdlib==1.11.0