diff mbox series

[2/4] migration/postcopy: fix typo in mark_postcopy_blocktime_begin's comment

Message ID 20191005220517.24029-3-richardw.yang@linux.intel.com
State New
Headers show
Series migration: trivial cleanup and refine | expand

Commit Message

Wei Yang Oct. 5, 2019, 10:05 p.m. UTC 
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 migration/postcopy-ram.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé Oct. 7, 2019, 10:08 a.m. UTC | #1 
On 10/6/19 12:05 AM, Wei Yang wrote:
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
>   migration/postcopy-ram.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> index d2bdd21ae3..a394c7c3a6 100644
> --- a/migration/postcopy-ram.c
> +++ b/migration/postcopy-ram.c
> @@ -768,9 +768,11 @@ static void mark_postcopy_blocktime_begin(uintptr_t addr, uint32_t ptid,
>       atomic_xchg(&dc->page_fault_vcpu_time[cpu], low_time_offset);
>       atomic_xchg(&dc->vcpu_addr[cpu], addr);
>   
> -    /* check it here, not at the begining of the function,
> -     * due to, check could accur early than bitmap_set in
> -     * qemu_ufd_copy_ioctl */
> +    /*
> +     * check it here, not at the beginning of the function,
> +     * due to, check could occur early than bitmap_set in
> +     * qemu_ufd_copy_ioctl
> +     */
>       already_received = ramblock_recv_bitmap_test(rb, (void *)addr);
>       if (already_received) {
>           atomic_xchg(&dc->vcpu_addr[cpu], 0);
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index d2bdd21ae3..a394c7c3a6 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -768,9 +768,11 @@  static void mark_postcopy_blocktime_begin(uintptr_t addr, uint32_t ptid,
     atomic_xchg(&dc->page_fault_vcpu_time[cpu], low_time_offset);
     atomic_xchg(&dc->vcpu_addr[cpu], addr);
 
-    /* check it here, not at the begining of the function,
-     * due to, check could accur early than bitmap_set in
-     * qemu_ufd_copy_ioctl */
+    /*
+     * check it here, not at the beginning of the function,
+     * due to, check could occur early than bitmap_set in
+     * qemu_ufd_copy_ioctl
+     */
     already_received = ramblock_recv_bitmap_test(rb, (void *)addr);
     if (already_received) {
         atomic_xchg(&dc->vcpu_addr[cpu], 0);