| Message ID | 20190212145322.30974-1-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/dma/i8257: Use qemu_log_mask(UNIMP) instead of fprintf | expand |
On 2019-02-12 15:53, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested (with -d unimp): > > $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin > dma: command df not supported > dma: command df not supported > dma: command df not supported > dma: command df not supported > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/dma/i8257.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c > index 52675e97c9..3e1f13a4aa 100644 > --- a/hw/dma/i8257.c > +++ b/hw/dma/i8257.c > @@ -26,6 +26,7 @@ > #include "hw/isa/isa.h" > #include "hw/dma/i8257.h" > #include "qemu/main-loop.h" > +#include "qemu/log.h" > #include "trace.h" > > #define I8257(obj) \ > @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data, > switch (iport) { > case 0x00: /* command */ > if ((data != 0) && (data & CMD_NOT_SUPPORTED)) { > - dolog("command %"PRIx64" not supported\n", data); > + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n", > + __func__, data); > return; > } > d->command = data; > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Tue, Feb 12, 2019 at 03:53:22PM +0100, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested (with -d unimp): > > $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin > dma: command df not supported > dma: command df not supported > dma: command df not supported > dma: command df not supported > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/dma/i8257.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com> Thanks, Stefano
On 12/02/2019 15:53, Philippe Mathieu-Daudé wrote: > Avoid to clutter stdout until explicitly requested (with -d unimp): > > $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin > dma: command df not supported > dma: command df not supported > dma: command df not supported > dma: command df not supported > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/dma/i8257.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c > index 52675e97c9..3e1f13a4aa 100644 > --- a/hw/dma/i8257.c > +++ b/hw/dma/i8257.c > @@ -26,6 +26,7 @@ > #include "hw/isa/isa.h" > #include "hw/dma/i8257.h" > #include "qemu/main-loop.h" > +#include "qemu/log.h" > #include "trace.h" > > #define I8257(obj) \ > @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data, > switch (iport) { > case 0x00: /* command */ > if ((data != 0) && (data & CMD_NOT_SUPPORTED)) { > - dolog("command %"PRIx64" not supported\n", data); > + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n", > + __func__, data); > return; > } > d->command = data; > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index 52675e97c9..3e1f13a4aa 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -26,6 +26,7 @@ #include "hw/isa/isa.h" #include "hw/dma/i8257.h" #include "qemu/main-loop.h" +#include "qemu/log.h" #include "trace.h" #define I8257(obj) \ @@ -185,7 +186,8 @@ static void i8257_write_cont(void *opaque, hwaddr nport, uint64_t data, switch (iport) { case 0x00: /* command */ if ((data != 0) && (data & CMD_NOT_SUPPORTED)) { - dolog("command %"PRIx64" not supported\n", data); + qemu_log_mask(LOG_UNIMP, "%s: cmd 0x%02"PRIx64" not supported\n", + __func__, data); return; } d->command = data;
Avoid to clutter stdout until explicitly requested (with -d unimp): $ qemu-system-mips64el -M fulong2e -bios pmon_2e.bin dma: command df not supported dma: command df not supported dma: command df not supported dma: command df not supported Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/dma/i8257.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)