From patchwork Fri Jan 18 12:46:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 1027316 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="CgJUCigt"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43h11b6qbDz9sBn for ; Fri, 18 Jan 2019 23:47:31 +1100 (AEDT) Received: from localhost ([127.0.0.1]:38211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTYX-0003Y6-Ni for incoming@patchwork.ozlabs.org; Fri, 18 Jan 2019 07:47:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkTXm-0003W7-CI for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkTXj-0008DW-Uw for qemu-devel@nongnu.org; Fri, 18 Jan 2019 07:46:42 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:44391) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkTXj-00081u-Jp; Fri, 18 Jan 2019 07:46:39 -0500 Received: by mail-wr1-x443.google.com with SMTP id z5so14868381wrt.11; Fri, 18 Jan 2019 04:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WpXmsnHVnc4IntIIBSWdbeMEjIngri7256gtdpiHNzs=; b=CgJUCigtmJiWPsmfdwv/KHUjmMpAjarsxcL8PUER4zivgehPuWbeOvuJryCg0bRlPC 0JI1IAuSVcA82VLJlcyAQN8ky3jVTZNETSWE14MYl8hJYxDVEPLyXj2oSGr6heBQX5+d M+g4D3ojnag/d7/WRY3vbgFslf/D6NzMd8nVtHB9owuo8MyC1fVWCIeQAiAo3igrs0OJ zwwXfTAnCGWTH23VZXihpElM38u/K0r00UkXy7B76b3xjfCPU2JjL+gJcqbjJ/fdgzUm ExJLlmBDPPa0ymfpS/sXtRGXdDT0++hxzhQoJAX5LX6uo69QaKmxE198M8/woolaVXtb mdWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WpXmsnHVnc4IntIIBSWdbeMEjIngri7256gtdpiHNzs=; b=kPHByHuCbymA/letThbxMG2uLvjgiy4RGhYQfhOqf/uOP9fhXU9SSnLRDQ78Njn8nK AGLdKq6EARnoyb0yJAgdIUFsQzNd5gvdXr4M8PyNuZwThIVTOHGPEWgZWR1OwN/I0JGU VGDYiLDslGHaAOnHClv6HIIZf1KV0VWZta/6jh6xXw2cS/0YUE7yCLfaXt+A/djFHHWY T115A52OBhCDzmQBOJtPsu/pEyqgZwjONcPM9bE8iAETFmv3MXFjkEVS+Cg3rPRXRLl9 Dy8K+7c/LjhFnlXvcChAbb1CfPjauZrnBrt+54T2WAgn45UinkVJrEYQvW6uJWT3jlPI IQvg== X-Gm-Message-State: AJcUukdw9aEUvn/nKhMjmsWG4lorc4pzOE6Mh8sjJxvopToj1xC+T2Ae SMvK25DKHFzwOZYTa9GMIYhVKfHz X-Google-Smtp-Source: ALg8bN5CvyUeOxVbiip2WGrPpJWI7rJeMqFHXPuoOU3PFKSnpchInfZnk+250dBc21lbUK2qUzns3A== X-Received: by 2002:adf:9205:: with SMTP id 5mr16333474wrj.189.1547815580684; Fri, 18 Jan 2019 04:46:20 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id n15sm69542124wrt.21.2019.01.18.04.46.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Jan 2019 04:46:20 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org Date: Fri, 18 Jan 2019 14:46:13 +0200 Message-Id: <20190118124614.24548-3-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> References: <20190118124614.24548-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v2 2/3] hw/rdma: modify struct initialization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cohuck@redhat.com, qemu-stable@nongnu.org, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Do not initialize structs with {0} since some CLANG versions do not support it. Use {} construct instead. Reviewed-by: Yuval Shaia Tested-by: Cornelia Huck Signed-off-by: Marcel Apfelbaum Reviewed-by: Cornelia Huck --- contrib/rdmacm-mux/main.c | 6 +++--- hw/rdma/rdma_backend.c | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c index 64676030c5..ae88c77a1e 100644 --- a/contrib/rdmacm-mux/main.c +++ b/contrib/rdmacm-mux/main.c @@ -350,7 +350,7 @@ static int get_fd(const char *mad, int *fd, __be64 *gid_ifid) static void *umad_recv_thread_func(void *args) { int rc; - RdmaCmMuxMsg msg = {0}; + RdmaCmMuxMsg msg = {}; int fd = -2; msg.hdr.msg_type = RDMACM_MUX_MSG_TYPE_REQ; @@ -387,7 +387,7 @@ static void *umad_recv_thread_func(void *args) static int read_and_process(int fd) { int rc; - RdmaCmMuxMsg msg = {0}; + RdmaCmMuxMsg msg = {}; struct umad_hdr *hdr; uint32_t *comm_id = 0; uint16_t attr_id; @@ -744,7 +744,7 @@ static void signal_handler(int sig, siginfo_t *siginfo, void *context) static int init(void) { int rc; - struct sigaction sig = {0}; + struct sigaction sig = {}; rc = init_listener(); if (rc) { diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index c28bfbd44d..0b9767fde7 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -190,7 +190,7 @@ static inline int rdmacm_mux_can_process_async(RdmaBackendDev *backend_dev) static int check_mux_op_status(CharBackend *mad_chr_be) { - RdmaCmMuxMsg msg = {0}; + RdmaCmMuxMsg msg = {}; int ret; pr_dbg("Reading response\n"); @@ -387,7 +387,7 @@ static int build_host_sge_array(RdmaDeviceResources *rdma_dev_res, static int mad_send(RdmaBackendDev *backend_dev, uint8_t sgid_idx, union ibv_gid *sgid, struct ibv_sge *sge, uint32_t num_sge) { - RdmaCmMuxMsg msg = {0}; + RdmaCmMuxMsg msg = {}; char *hdr, *data; int ret; @@ -1112,7 +1112,7 @@ int rdma_backend_get_gid_index(RdmaBackendDev *backend_dev, int rdma_backend_add_gid(RdmaBackendDev *backend_dev, const char *ifname, union ibv_gid *gid) { - RdmaCmMuxMsg msg = {0}; + RdmaCmMuxMsg msg = {}; int ret; pr_dbg("0x%llx, 0x%llx\n", @@ -1138,7 +1138,7 @@ int rdma_backend_add_gid(RdmaBackendDev *backend_dev, const char *ifname, int rdma_backend_del_gid(RdmaBackendDev *backend_dev, const char *ifname, union ibv_gid *gid) { - RdmaCmMuxMsg msg = {0}; + RdmaCmMuxMsg msg = {}; int ret; pr_dbg("0x%llx, 0x%llx\n",