| Message ID | 20190104175847.6290-4-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw: Remove "hw/devices.h" | expand |
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Introduced in 64b40bc54a9, this definition is no more used since > a0b753dfd39. Remove it. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > include/hw/devices.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/devices.h b/include/hw/devices.h > index 0e27feb0c2..4019b3be17 100644 > --- a/include/hw/devices.h > +++ b/include/hw/devices.h > @@ -51,7 +51,6 @@ void retu_key_event(void *retu, int state); > > /* tc6393xb.c */ > typedef struct TC6393xbState TC6393xbState; > -#define TC6393XB_RAM 0x110000 /* amount of ram for Video and USB */ > TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem, > uint32_t base, qemu_irq irq); > void tc6393xb_gpio_out_set(TC6393xbState *s, int line, > I think I'd simply squash this into the next patch and mention it in the patch description there that you removed the #define. Thomas
On 1/7/19 7:32 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Introduced in 64b40bc54a9, this definition is no more used since >> a0b753dfd39. Remove it. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> >> --- >> include/hw/devices.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/hw/devices.h b/include/hw/devices.h >> index 0e27feb0c2..4019b3be17 100644 >> --- a/include/hw/devices.h >> +++ b/include/hw/devices.h >> @@ -51,7 +51,6 @@ void retu_key_event(void *retu, int state); >> >> /* tc6393xb.c */ >> typedef struct TC6393xbState TC6393xbState; >> -#define TC6393XB_RAM 0x110000 /* amount of ram for Video and USB */ >> TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem, >> uint32_t base, qemu_irq irq); >> void tc6393xb_gpio_out_set(TC6393xbState *s, int line, >> > > I think I'd simply squash this into the next patch and mention it in the > patch description there that you removed the #define. OK.
diff --git a/include/hw/devices.h b/include/hw/devices.h index 0e27feb0c2..4019b3be17 100644 --- a/include/hw/devices.h +++ b/include/hw/devices.h @@ -51,7 +51,6 @@ void retu_key_event(void *retu, int state); /* tc6393xb.c */ typedef struct TC6393xbState TC6393xbState; -#define TC6393XB_RAM 0x110000 /* amount of ram for Video and USB */ TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem, uint32_t base, qemu_irq irq); void tc6393xb_gpio_out_set(TC6393xbState *s, int line,
Introduced in 64b40bc54a9, this definition is no more used since a0b753dfd39. Remove it. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- include/hw/devices.h | 1 - 1 file changed, 1 deletion(-)