From patchwork Sat Dec 22 09:50:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 1017829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::12; helo=lists.nongnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="o2C8Fieq"; dkim-atps=neutral Received: from lists.nongnu.org (lists.nongnu.org [IPv6:2001:4830:134:3::12]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43MLr65MdPz9sPd for ; Sat, 22 Dec 2018 21:11:34 +1100 (AEDT) Received: from localhost ([::1]:34983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gaeFo-0005SW-DI for incoming@patchwork.ozlabs.org; Sat, 22 Dec 2018 05:11:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadwN-0006Zc-D3 for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadwK-0006j5-Ld for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:26 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:33813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadwJ-0006es-QP for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:51:24 -0500 Received: by mail-wm1-x341.google.com with SMTP id y185so15834187wmd.1 for ; Sat, 22 Dec 2018 01:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kFK2hK6vIxFug568DSFeRY/jEfInSuH4CRmJF+C9nX0=; b=o2C8FieqQydLjbOi3JK3ZJkx+zR7pt08YJ98OfWnD2LZ6WhptUai9PeiWt+AJHc/Wf XTMfQ1SR0wwJrhBfOVJHg/iYhIrkuthSkIJvm/EPUlHJSuWNXkUvllWpC9OIr9MsnUM2 25o4QZN9U7rtQXSC9cgIq094O4msjlegcmtLRI3Mu+jPIEfWm2VrtWwG1/L+3n0ok7KV RHwKZ0ULTKSeTzlj8Pn6jPQaw5/HV2A8ZkQVXzgnyrmv9g1Z0Mxzc/77GUCnuJSLM9/k 8/NZJiQWmt2MQcPzPH+HWIiHMG0pXKjnwU4MK5m9iDFlewU6Cp4p2Qyb3VskSCMLSUYK andA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kFK2hK6vIxFug568DSFeRY/jEfInSuH4CRmJF+C9nX0=; b=sQD8962RnJaPUYZK98OJr3AMYkKUAmvaDHKbC02TEhZMZ4WbdrVt2HIPCtKmiiqLeP 4IMMUmHrJy7ptpAFBt8H9/1G4pXKiEoXhxezHLXj666qg4y8NBOmXv8ff+xSGduZ2XKV MMaFJTbcbWS3rv9/UBV2UJfUhhYVsZ0q0/f+k7NtfbjRGYmHnDn52D1zGM4CsYaVgtOB EUwCcM7DD6VHfVLoPBPJS6HiFIJpyqJdgKwPLGZdraT6m6Sl4VeXNx5fDkufzJAUhRxR oxwiCBj2M2qKDycbkpmheL3xKzvd4u8mUK12S2xeUuscRA9CcGdbyYqvUoExTWl4LEpi gzSQ== X-Gm-Message-State: AA+aEWZZWlJIOCrxWEO+vsV53bsQVaRblUnIPu0rcAT/WJz5uSfw/Pmv ivyZawvFiJqhzcnL8/iXl1iUxqMf X-Google-Smtp-Source: ALg8bN4s/tfeV9OXjxvuXWKpLTnYS+VHQ38L50Og8WrdUsZU9V22j8xwZE6QtILlTFThTLUh5CIocg== X-Received: by 2002:a1c:3d44:: with SMTP id k65mr5822756wma.76.1545472278155; Sat, 22 Dec 2018 01:51:18 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id s3sm9557371wmj.23.2018.12.22.01.51.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 01:51:17 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 22 Dec 2018 11:50:32 +0200 Message-Id: <20181222095036.29743-28-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> References: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: [Qemu-devel] [PATCH PULL 27/31] pvrdma: add uar_read routine X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuval.shaia@oracle.com, pjp@fedoraproject.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Prasad J Pandit Define skeleton 'uar_read' routine. Avoid NULL dereference. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit Reviewed-by: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 64de16fb52..838ad8a949 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -448,6 +448,11 @@ static const MemoryRegionOps regs_ops = { }, }; +static uint64_t uar_read(void *opaque, hwaddr addr, unsigned size) +{ + return 0xffffffff; +} + static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { PVRDMADev *dev = opaque; @@ -489,6 +494,7 @@ static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) } static const MemoryRegionOps uar_ops = { + .read = uar_read, .write = uar_write, .endianness = DEVICE_LITTLE_ENDIAN, .impl = {