| Message ID | 20181207165103.3992-3-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce the hw/firmware/ namespace | expand |
On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: > All the consumers of "smbios_ipmi.h" are located in hw/smbios/. I tried to verify this statement by grepping the tree for "smbios_ipmi.h". There were zero hits. Please use the more precise pathname "hw/smbios/ipmi.h". (I can't suggest just "ipmi.h", because that isn't unique.) With this update: Reviewed-by: Laszlo Ersek <lersek@redhat.com> Thanks, Laszlo > There is no need to have this include publicly exposed, > reduce the visibility by moving it in hw/smbios/. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/smbios/smbios.c | 2 +- > include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h | 0 > hw/smbios/smbios_type_38-stub.c | 2 +- > hw/smbios/smbios_type_38.c | 2 +- > 4 files changed, 3 insertions(+), 3 deletions(-) > rename include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h (100%) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c > index 920939454e..30bd4731cf 100644 > --- a/hw/smbios/smbios.c > +++ b/hw/smbios/smbios.c > @@ -28,7 +28,7 @@ > #include "hw/loader.h" > #include "exec/cpu-common.h" > #include "smbios_build.h" > -#include "hw/smbios/ipmi.h" > +#include "smbios_ipmi.h" > > /* legacy structures and constants for <= 2.0 machines */ > struct smbios_header { > diff --git a/include/hw/smbios/ipmi.h b/hw/smbios/smbios_ipmi.h > similarity index 100% > rename from include/hw/smbios/ipmi.h > rename to hw/smbios/smbios_ipmi.h > diff --git a/hw/smbios/smbios_type_38-stub.c b/hw/smbios/smbios_type_38-stub.c > index 5b83c9b1f1..fc4516bc8a 100644 > --- a/hw/smbios/smbios_type_38-stub.c > +++ b/hw/smbios/smbios_type_38-stub.c > @@ -8,7 +8,7 @@ > */ > > #include "qemu/osdep.h" > -#include "hw/smbios/ipmi.h" > +#include "smbios_ipmi.h" > > void smbios_build_type_38_table(void) > { > diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c > index 56e8609c00..d84e87d608 100644 > --- a/hw/smbios/smbios_type_38.c > +++ b/hw/smbios/smbios_type_38.c > @@ -9,10 +9,10 @@ > > #include "qemu/osdep.h" > #include "hw/ipmi/ipmi.h" > -#include "hw/smbios/ipmi.h" > #include "hw/smbios/smbios.h" > #include "qemu/error-report.h" > #include "smbios_build.h" > +#include "smbios_ipmi.h" > > /* SMBIOS type 38 - IPMI */ > struct smbios_type_38 { >
On 12/10/18 4:00 PM, Laszlo Ersek wrote: > On 12/07/18 17:51, Philippe Mathieu-Daudé wrote: >> All the consumers of "smbios_ipmi.h" are located in hw/smbios/. > > I tried to verify this statement by grepping the tree for > "smbios_ipmi.h". There were zero hits. Please use the more precise > pathname "hw/smbios/ipmi.h". (I can't suggest just "ipmi.h", because > that isn't unique.) I did not notice I used the post-patch pathname, thanks. > > With this update: > > Reviewed-by: Laszlo Ersek <lersek@redhat.com> > > Thanks, > Laszlo
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 920939454e..30bd4731cf 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -28,7 +28,7 @@ #include "hw/loader.h" #include "exec/cpu-common.h" #include "smbios_build.h" -#include "hw/smbios/ipmi.h" +#include "smbios_ipmi.h" /* legacy structures and constants for <= 2.0 machines */ struct smbios_header { diff --git a/include/hw/smbios/ipmi.h b/hw/smbios/smbios_ipmi.h similarity index 100% rename from include/hw/smbios/ipmi.h rename to hw/smbios/smbios_ipmi.h diff --git a/hw/smbios/smbios_type_38-stub.c b/hw/smbios/smbios_type_38-stub.c index 5b83c9b1f1..fc4516bc8a 100644 --- a/hw/smbios/smbios_type_38-stub.c +++ b/hw/smbios/smbios_type_38-stub.c @@ -8,7 +8,7 @@ */ #include "qemu/osdep.h" -#include "hw/smbios/ipmi.h" +#include "smbios_ipmi.h" void smbios_build_type_38_table(void) { diff --git a/hw/smbios/smbios_type_38.c b/hw/smbios/smbios_type_38.c index 56e8609c00..d84e87d608 100644 --- a/hw/smbios/smbios_type_38.c +++ b/hw/smbios/smbios_type_38.c @@ -9,10 +9,10 @@ #include "qemu/osdep.h" #include "hw/ipmi/ipmi.h" -#include "hw/smbios/ipmi.h" #include "hw/smbios/smbios.h" #include "qemu/error-report.h" #include "smbios_build.h" +#include "smbios_ipmi.h" /* SMBIOS type 38 - IPMI */ struct smbios_type_38 {
All the consumers of "smbios_ipmi.h" are located in hw/smbios/. There is no need to have this include publicly exposed, reduce the visibility by moving it in hw/smbios/. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/smbios/smbios.c | 2 +- include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h | 0 hw/smbios/smbios_type_38-stub.c | 2 +- hw/smbios/smbios_type_38.c | 2 +- 4 files changed, 3 insertions(+), 3 deletions(-) rename include/hw/smbios/ipmi.h => hw/smbios/smbios_ipmi.h (100%)